Repository navigation
fix(onboard): report an unhealthy inference route as not ready #6862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
14f86a5
fix(onboard): report an unhealthy inference route as not ready
laitingsheng 29ce2b9
Merge remote-tracking branch 'origin/main' into fix/onboard-finalize-…
laitingsheng e5216a0
fix(inference): match loopback hostnames exactly and stop double-rewr…
laitingsheng 07cca79
test(e2e): allow combined coverage validation budget
jyaunches 59329e2
fix(onboard): block unreachable inference readiness
jyaunches 83c7173
Merge remote-tracking branch 'origin/main' into pr-6862
jyaunches 64d582c
docs(onboard): explain inference readiness failure
jyaunches aeb55f0
docs(onboard): use direct readiness guidance
jyaunches b152e60
fix(onboard): harden inference recovery guidance
jyaunches c437dec
test(onboard): keep retry fixtures linear
jyaunches 9661f7a
fix(onboard): keep failed readiness retryable
jyaunches fd49c51
merge: update PR branch from main
jyaunches 1ee8088
fix(onboard): keep unhealthy finalization resumable
cv 880df88
merge: integrate contributor branch update
jyaunches e0f34e7
test(docs): align final route verification contract
jyaunches adc90c0
docs(inference): preserve local post-ready checks
cv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| // SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| import { afterEach, describe, expect, it } from "vitest"; | ||
|
|
||
| import type { VerifyDeploymentResult } from "../verify-deployment"; | ||
| import { finalizationHandlerDeps } from "./finalization-deps"; | ||
|
|
||
| describe("finalizationHandlerDeps.reportDeploymentReadiness", () => { | ||
| const originalExitCode = process.exitCode; | ||
| afterEach(() => { | ||
| process.exitCode = originalExitCode; | ||
| }); | ||
|
|
||
| it("sets a non-zero exit code when the deployment is not ready", () => { | ||
| process.exitCode = 0; | ||
| finalizationHandlerDeps.reportDeploymentReadiness(false); | ||
| expect(process.exitCode).toBe(1); | ||
| }); | ||
|
|
||
| it("leaves the exit code unchanged when the deployment is ready", () => { | ||
| process.exitCode = 0; | ||
| finalizationHandlerDeps.reportDeploymentReadiness(true); | ||
| expect(process.exitCode).toBe(0); | ||
| }); | ||
| }); | ||
|
|
||
| describe("finalizationHandlerDeps.isDeploymentHealthy", () => { | ||
| it("reports the verification healthy flag", () => { | ||
| const healthy = { healthy: true } as unknown as VerifyDeploymentResult; | ||
| const unhealthy = { healthy: false } as unknown as VerifyDeploymentResult; | ||
| expect(finalizationHandlerDeps.isDeploymentHealthy(healthy)).toBe(true); | ||
| expect(finalizationHandlerDeps.isDeploymentHealthy(unhealthy)).toBe(false); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.