Repository navigation
test(e2e): enforce phase-aware onboard budgets #6732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 11 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
db03d61
test(e2e): enforce phase-aware onboard budgets
HOYALIM 504d93f
fix(e2e): address cjagwani blockers on phase-aware onboard budgets
prekshivyas d3d503d
fix(e2e): trim validate-config-schemas below 1500-line test budget
prekshivyas 926a80c
Merge remote-tracking branch 'origin/main' into fix/6732-cjagwani-blo…
prekshivyas 4544d07
test(e2e): harden cold onboard performance gate
prekshivyas a09b52f
Merge remote-tracking branch 'origin/main' into fix/6732-cjagwani-blo…
prekshivyas 0a1c773
test(e2e): calibrate cold onboard budgets
prekshivyas 2d0c3f9
test(e2e): keep cold path assertion linear
prekshivyas a6f90a5
Merge branch 'main' into codex/issue-6660-phase-budget
prekshivyas 0f91b6d
test(e2e): address cold path review findings
prekshivyas ab66cf0
Merge remote-tracking branch 'hoyalim/codex/issue-6660-phase-budget' …
prekshivyas e5944ab
test(onboard): cover failed gateway trace spans
prekshivyas 29238dc
Merge remote-tracking branch 'origin/main' into fix/6732-cjagwani-blo…
prekshivyas 84ac374
Merge branch 'main' into codex/issue-6660-phase-budget
cv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,164 @@ | ||
| { | ||
| "$comment": "SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.\nSPDX-License-Identifier: Apache-2.0\n\nFive independent workflow_dispatch full-e2e samples of current-main baseline 1a74b8348c2182fbf806726341186f008444e28e with the phase-measurement changes at 4544d07c8bfd500c3b64a74380ef5cd0e62089f5. All runs completed install, BuildKit prebuild without fallback, the silence assertion, and the expected first turn. Each budget is derived independently so phase caps diagnose regressions; they are not portions that must sum to the root-start budget.", | ||
| "schemaVersion": 1, | ||
| "calibratedAt": "2026-07-13", | ||
| "baselineMainSha": "1a74b8348c2182fbf806726341186f008444e28e", | ||
| "measurementHeadSha": "4544d07c8bfd500c3b64a74380ef5cd0e62089f5", | ||
| "workflowPath": ".github/workflows/e2e.yaml", | ||
| "job": "full-e2e", | ||
| "derivation": { | ||
| "percentile": 95, | ||
| "percentileMethod": "nearest-rank", | ||
| "minimumHeadroomMs": 5000, | ||
| "relativeHeadroomPercent": 10, | ||
| "roundUpMs": 1000 | ||
| }, | ||
| "samples": [ | ||
| { | ||
| "runId": 29285379553, | ||
| "runUrl": "https://github.com/NVIDIA/NemoClaw/actions/runs/29285379553", | ||
| "headSha": "4544d07c8bfd500c3b64a74380ef5cd0e62089f5", | ||
| "conclusion": "success", | ||
| "installExitCode": 0, | ||
| "firstTurnExitCode": 0, | ||
| "performancePassed": true, | ||
| "usedBuildKitPrebuild": true, | ||
| "buildKitFallback": false, | ||
| "maxSilenceSecs": 31, | ||
| "responseChars": 23, | ||
| "measurementsMs": { | ||
| "onboardRoot": 170850, | ||
| "rootStartToFirstTurnCompletion": 178403, | ||
| "rootEndToInstallCompletion": 137, | ||
| "firstTurnCommand": 7413, | ||
| "rootEndToFirstTurnCompletion": 7553, | ||
| "phases": { | ||
| "nemoclaw.onboard.phase.preflight": 1251, | ||
| "nemoclaw.onboard.phase.gateway": 65, | ||
| "nemoclaw.onboard.phase.provider_selection": 2312, | ||
| "nemoclaw.onboard.phase.inference": 669, | ||
| "nemoclaw.onboard.phase.sandbox": 126615 | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "runId": 29285384233, | ||
| "runUrl": "https://github.com/NVIDIA/NemoClaw/actions/runs/29285384233", | ||
| "headSha": "4544d07c8bfd500c3b64a74380ef5cd0e62089f5", | ||
| "conclusion": "success", | ||
| "installExitCode": 0, | ||
| "firstTurnExitCode": 0, | ||
| "performancePassed": true, | ||
| "usedBuildKitPrebuild": true, | ||
| "buildKitFallback": false, | ||
| "maxSilenceSecs": 31, | ||
| "responseChars": 23, | ||
| "measurementsMs": { | ||
| "onboardRoot": 149056, | ||
| "rootStartToFirstTurnCompletion": 155856, | ||
| "rootEndToInstallCompletion": 135, | ||
| "firstTurnCommand": 6662, | ||
| "rootEndToFirstTurnCompletion": 6800, | ||
| "phases": { | ||
| "nemoclaw.onboard.phase.preflight": 1132, | ||
| "nemoclaw.onboard.phase.gateway": 58, | ||
| "nemoclaw.onboard.phase.provider_selection": 1142, | ||
| "nemoclaw.onboard.phase.inference": 563, | ||
| "nemoclaw.onboard.phase.sandbox": 105938 | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "runId": 29285387079, | ||
| "runUrl": "https://github.com/NVIDIA/NemoClaw/actions/runs/29285387079", | ||
| "headSha": "4544d07c8bfd500c3b64a74380ef5cd0e62089f5", | ||
| "conclusion": "success", | ||
| "installExitCode": 0, | ||
| "firstTurnExitCode": 0, | ||
| "performancePassed": true, | ||
| "usedBuildKitPrebuild": true, | ||
| "buildKitFallback": false, | ||
| "maxSilenceSecs": 32, | ||
| "responseChars": 23, | ||
| "measurementsMs": { | ||
| "onboardRoot": 177334, | ||
| "rootStartToFirstTurnCompletion": 186018, | ||
| "rootEndToInstallCompletion": 168, | ||
| "firstTurnCommand": 8512, | ||
| "rootEndToFirstTurnCompletion": 8684, | ||
| "phases": { | ||
| "nemoclaw.onboard.phase.preflight": 1193, | ||
| "nemoclaw.onboard.phase.gateway": 51, | ||
| "nemoclaw.onboard.phase.provider_selection": 1358, | ||
| "nemoclaw.onboard.phase.inference": 638, | ||
| "nemoclaw.onboard.phase.sandbox": 132561 | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "runId": 29285389469, | ||
| "runUrl": "https://github.com/NVIDIA/NemoClaw/actions/runs/29285389469", | ||
| "headSha": "4544d07c8bfd500c3b64a74380ef5cd0e62089f5", | ||
| "conclusion": "success", | ||
| "installExitCode": 0, | ||
| "firstTurnExitCode": 0, | ||
| "performancePassed": true, | ||
| "usedBuildKitPrebuild": true, | ||
| "buildKitFallback": false, | ||
| "maxSilenceSecs": 32, | ||
| "responseChars": 23, | ||
| "measurementsMs": { | ||
| "onboardRoot": 175231, | ||
| "rootStartToFirstTurnCompletion": 182517, | ||
| "rootEndToInstallCompletion": 131, | ||
| "firstTurnCommand": 7152, | ||
| "rootEndToFirstTurnCompletion": 7286, | ||
| "phases": { | ||
| "nemoclaw.onboard.phase.preflight": 1205, | ||
| "nemoclaw.onboard.phase.gateway": 62, | ||
| "nemoclaw.onboard.phase.provider_selection": 1377, | ||
| "nemoclaw.onboard.phase.inference": 805, | ||
| "nemoclaw.onboard.phase.sandbox": 130203 | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "runId": 29285391845, | ||
| "runUrl": "https://github.com/NVIDIA/NemoClaw/actions/runs/29285391845", | ||
| "headSha": "4544d07c8bfd500c3b64a74380ef5cd0e62089f5", | ||
| "conclusion": "success", | ||
| "installExitCode": 0, | ||
| "firstTurnExitCode": 0, | ||
| "performancePassed": true, | ||
| "usedBuildKitPrebuild": true, | ||
| "buildKitFallback": false, | ||
| "maxSilenceSecs": 30, | ||
| "responseChars": 23, | ||
| "measurementsMs": { | ||
| "onboardRoot": 155691, | ||
| "rootStartToFirstTurnCompletion": 160740, | ||
| "rootEndToInstallCompletion": 104, | ||
| "firstTurnCommand": 4942, | ||
| "rootEndToFirstTurnCompletion": 5049, | ||
| "phases": { | ||
| "nemoclaw.onboard.phase.preflight": 5101, | ||
| "nemoclaw.onboard.phase.gateway": 211, | ||
| "nemoclaw.onboard.phase.provider_selection": 1585, | ||
| "nemoclaw.onboard.phase.inference": 583, | ||
| "nemoclaw.onboard.phase.sandbox": 118007 | ||
| } | ||
| } | ||
| } | ||
| ], | ||
| "derivedBudgetsMs": { | ||
| "rootStartToFirstTurnCompletionBudgetMs": 205000, | ||
| "rootEndToFirstTurnCompletionBudgetMs": 14000, | ||
| "phaseBudgetsMs": { | ||
| "nemoclaw.onboard.phase.preflight": 11000, | ||
| "nemoclaw.onboard.phase.gateway": 6000, | ||
| "nemoclaw.onboard.phase.provider_selection": 8000, | ||
| "nemoclaw.onboard.phase.inference": 6000, | ||
| "nemoclaw.onboard.phase.sandbox": 146000 | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.