test(vitest): strengthen coverage safeguards - #6719
Closed
souvikDevloper wants to merge 1 commit into
Closed
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
E2E Advisor RecommendationRequired E2E: None Full advisor summaryE2E Recommendation AdvisorBase: Required E2E
Optional E2E
New E2E recommendations
|
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Strengthens Vitest coverage safeguards so aggregate coverage cannot drift below its floor, security-sensitive files retain native per-file coverage minimums, and changed-file coverage is visible as a non-blocking CI advisory. It also pilots assertion-presence enforcement for the plugin project.
Related Issue
Part of #6692. Follows #6702, the preceding entry in the Vitest hardening stack.
Changes
continue-on-errorstep.Type of Change
Quality Gates
Verification
Verifiedin GitHubpre-commit,commit-msg, andpre-pushhooks passed, ornpm run check:diffpassed when hooks were skipped or unavailablevitest run test/coverage-ratchet.test.ts(5 passed); focused workflow and plugin project contract tests (1 passed each); focused SSRF coverage run (101 passed, native per-file thresholds satisfied).npm testfor broad runtime/test-harness changes;npm run checkfor repo-wide validation/coverage changes — command/result: direct root CLI and plugin production/test typechecks pass. The POSIX shell portions of the broad gate are not runnable in this Windows checkout; CI is authoritative.npm run docsbuilds without warnings (doc changes only)Windows validation note: the normal hooks passed formatting, lint, commit message, plugin TypeScript, CLI TypeScript, and version-sync checks. The repository-check aggregator and JS-config pre-push command hit Windows process/shell incompatibilities (
spawnSync tsx.cmd EINVALand POSIXifparsed bycmd.exe); their direct TypeScript equivalents passed.Signed-off-by: souvikDevloper 138186578+souvikDevloper@users.noreply.github.com