Skip to content

fix: upgrade openshell when installed version is below minimum #658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kjw3 merged 3 commits into from
Mar 22, 2026
Merged

fix: upgrade openshell when installed version is below minimum #658

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1cb6ef1
fix: upgrade openshell when installed version is below minimum
ericksoa Mar 22, 2026
155c5fc
fix: use portable version comparison (no sort -V for BSD compat)
ericksoa Mar 22, 2026
252bad9
fix: use head -1 to extract single version from openshell output
ericksoa Mar 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions scripts/install-openshell.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,28 @@ esac

info "Detected $OS_LABEL ($ARCH_LABEL)"

# Minimum version required for cgroup v2 fix (NVIDIA/OpenShell#329)
MIN_VERSION="0.0.7"

version_gte() {
# Returns 0 (true) if $1 >= $2 — portable, no sort -V (BSD compat)
local IFS=.
local -a a=($1) b=($2)
for i in 0 1 2; do
local ai=${a[$i]:-0} bi=${b[$i]:-0}
if (( ai > bi )); then return 0; fi
if (( ai < bi )); then return 1; fi
done
return 0
}
Comment thread
coderabbitai[bot] marked this conversation as resolved.

if command -v openshell > /dev/null 2>&1; then
info "openshell already installed: $(openshell --version 2>&1 || echo 'unknown')"
exit 0
INSTALLED_VERSION="$(openshell --version 2>&1 | grep -oE '[0-9]+\.[0-9]+\.[0-9]+' | head -1 || echo '0.0.0')"
if version_gte "$INSTALLED_VERSION" "$MIN_VERSION"; then
info "openshell already installed: $INSTALLED_VERSION (>= $MIN_VERSION)"
exit 0
fi
warn "openshell $INSTALLED_VERSION is below minimum $MIN_VERSION — upgrading..."
fi

info "Installing openshell CLI..."
Expand Down
Loading