-
Notifications
You must be signed in to change notification settings - Fork 3.1k
fix(dcode): preserve state across policy reloads #6503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
64f7172
fix(dcode): single-source credential name limit
ericksoa 3d990f4
test(e2e): isolate DCode sequential checks
ericksoa 6060b09
fix(dcode): preserve observability across policy reloads
ericksoa f1f0e18
test(dcode): close advisor boundary follow-ups
ericksoa 3de56cc
test(dcode): keep boundary assertions linear
ericksoa 42e0610
test(e2e): preserve observability during cleanup
cjagwani e874dac
test(e2e): keep cleanup assertion linear
cjagwani 6fa7bff
fix(e2e): align observability cleanup marker
ericksoa 11541cb
fix(e2e): capture observability before policy reload
ericksoa 66ab467
chore: merge main into DCode follow-up
ericksoa ac0492b
test(e2e): trust host observability intent
ericksoa 2051e20
fix(dcode): reject unsafe observability marker paths
ericksoa 739a4e0
test(e2e): prove marker cannot grant OTLP egress
ericksoa c207b32
chore(dcode): clarify runtime state lifetimes
ericksoa aa84a4f
chore: merge main into DCode follow-up
ericksoa 0570b87
chore: merge main into DCode follow-up
ericksoa 61199ad
Merge branch 'main' into fix/dcode-post-merge-e2e
cv b834dd0
merge: sync main into dcode policy reload branch
cv 0e4e5ac
test(dcode): exercise marker replacement on Linux
cv cf994ae
test(dcode): keep platform fixture linear
cv 3e2606c
Merge branch 'main' into fix/dcode-post-merge-e2e
cv 7a9d3da
Merge branch 'main' into fix/dcode-post-merge-e2e
cv 665bad6
Merge branch 'main' into fix/dcode-post-merge-e2e
cv 54ec796
Merge branch 'main' into fix/dcode-post-merge-e2e
cv 6d660b6
Merge branch 'main' into fix/dcode-post-merge-e2e
cv 804f664
Merge branch 'main' into fix/dcode-post-merge-e2e
cv 3ab89f3
Merge branch 'main' into fix/dcode-post-merge-e2e
cv 24588d8
merge: sync current main
cv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🩺 Stability & Availability | 🟡 Minor | ⚡ Quick win
Wait for policy enforcement to settle before probing.
The flow probes immediately after
policy-removeand resumes positive checks immediately afterpolicy-add. Unlike the Tavily cleanup at Line 158, no settlement delay protects these network assertions from asynchronous policy reloads.Proposed fix
"$CLI" "$SANDBOX_NAME" policy-add observability-otlp-local --yes >/dev/null 2>&1 \ || return 1 [ "$(observability_policy_state)" = "active" ] || return 1 + sleep "${NEMOCLAW_E2E_POLICY_SETTLE_SECONDS:-5}" ;; ... [ "$policy_state" = "inactive" ] \ || fail "removed observability policy is not exactly inactive (state: $policy_state)" +sleep "${NEMOCLAW_E2E_POLICY_SETTLE_SECONDS:-5}"Also applies to: 353-388
🤖 Prompt for AI Agents