Skip to content

refactor(rebuild): unify post-restore verification and completion gating #6491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jyaunches wants to merge 4 commits into from
Closed

refactor(rebuild): unify post-restore verification and completion gating #6491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a225c1b
refactor(rebuild): gate completion on post-restore verification
jyaunches Jul 8, 2026
d9586ce
fix(rebuild): preserve finalization failure evidence
jyaunches Jul 8, 2026
ea45195
test(rebuild): keep finalization boundary linear
jyaunches Jul 8, 2026
61e8c5d
test(rebuild): cover rejected registry reconciliation
jyaunches Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/lib/actions/sandbox/rebuild-dcode-recovery.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,7 +366,7 @@ describe("rebuildSandbox DCode flow: recovery", () => {

await expect(
harness.rebuildSandbox("alpha", ["--yes"], { throwOnError: true }),
).rejects.toThrow("Rebuild completed with unverified live policy reconciliation for 'alpha'.");
).rejects.toThrow("POLICY_RECONCILIATION_UNVERIFIED");

expect(harness.registryUpdateSpy).toHaveBeenCalledWith(
"alpha",
Expand All @@ -376,6 +376,11 @@ describe("rebuildSandbox DCode flow: recovery", () => {
policyPresetsFinalized: undefined,
}),
);
expect(harness.transactionStore.load("alpha")).toMatchObject({
status: "active",
phase: "replacement_created",
failure: { code: "POLICY_RECONCILIATION_UNVERIFIED", retryable: true },
});
expect(harness.relockSpy).toHaveBeenCalled();
});

Expand Down
187 changes: 0 additions & 187 deletions src/lib/actions/sandbox/rebuild-finalization.test.ts
View file
Open in desktop

This file was deleted.

168 changes: 0 additions & 168 deletions src/lib/actions/sandbox/rebuild-finalization.ts
View file
Open in desktop

This file was deleted.

Loading
Loading