Skip to content

test(ci): keep Deep Agents image test within ceiling - #6487

Closed
cjagwani wants to merge 2 commits into
mainfrom
fix/test-size-budget-deepagents-image
Closed

test(ci): keep Deep Agents image test within ceiling#6487
cjagwani wants to merge 2 commits into
mainfrom
fix/test-size-budget-deepagents-image

Conversation

@cjagwani

@cjagwani cjagwani commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • remove one formatter-stable blank line from test/langchain-deepagents-code-image.test.ts
  • restore test-size:check on current main after the v0.0.78 merge batch grew the file to 1,501 lines against the 1,500 default
  • keep the existing ceiling unchanged, as required by codebase growth guardrails

Verification

  • npx --yes @biomejs/biome check test/langchain-deepagents-code-image.test.ts ci/test-file-size-budget.json
  • npx --yes tsx scripts/check-test-file-size-budget.ts
  • git diff --check

Net PR diff is one blank-line deletion; no assertion or product behavior changes.

Summary by CodeRabbit

  • Style
    • Made a minor formatting-only adjustment with no impact on behavior, functionality, or test coverage.

Signed-off-by: cjagwani cjagwani@nvidia.com

Signed-off-by: cjagwani <cjagwani@nvidia.com>
@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

This change removes a single blank line between the fakePrivateKeyBlock helper and the repoRoot constant declaration in a test file. No test logic, assertions, or imports are modified.

Changes

Test File Whitespace Change

Layer / File(s) Summary
Remove blank line
test/langchain-deepagents-code-image.test.ts
A blank line between fakePrivateKeyBlock and repoRoot is removed; no functional change.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the PR's purpose of keeping the Deep Agents image test under its size ceiling.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/test-size-budget-deepagents-image

Comment @coderabbitai help to get the list of available commands.

@github-code-quality

github-code-quality Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Code Coverage Overview

Languages: TypeScript

TypeScript / code-coverage/plugin

The overall coverage remains at 96%, unchanged from the main branch.

TypeScript / code-coverage/cli

The overall coverage in the fix/test-size-budget... branch remains at 76%, unchanged from the main branch.

Show a code coverage summary of the most impacted files.
File main 5ddf9a1 fix/test-size-budget... ea892fa +/-
src/lib/inferen...el-discovery.ts 72% 0% -72%
src/lib/messagi...nnels/policy.ts 100% 91% -9%
src/lib/runner.ts 80% 73% -7%
src/lib/inference/config.ts 99% 96% -3%
src/lib/security/redact.ts 97% 95% -2%
src/lib/inferen...time-context.ts 96% 94% -2%
src/lib/inferen...ollama/proxy.ts 26% 25% -1%
src/lib/onboard.ts 28% 28% 0%

Updated July 08, 2026 19:30 UTC
Code Coverage is in Public Preview. Learn more and provide us with your feedback.

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

E2E Advisor Recommendation

Required E2E: None
Optional E2E: None

Workflow run

Full advisor summary

E2E Recommendation Advisor

Base: origin/main
Head: HEAD
Confidence: high

Required E2E

  • None. No E2E is recommended because this PR is tests-only and the actual diff is a formatting-only blank-line removal that cannot affect installer/onboarding, sandbox lifecycle, credentials, security boundaries, network policy, inference routing, deployment, or real assistant user flows.

Optional E2E

  • None.

New E2E recommendations

  • None.

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

E2E Target Recommendation

Required E2E targets: None
Optional E2E targets: None

Workflow run

Full E2E target advisor summary

E2E Target Advisor

Base: origin/main
Head: HEAD
Confidence: high

Required E2E targets

  • None. Only a non-E2E test file outside test/e2e/ changed, with no direct impact on E2E target workflow, registry, runtime support, fixtures, or live target behavior.

Optional E2E targets

  • None.

Relevant changed files

  • None.

Signed-off-by: cjagwani <cjagwani@nvidia.com>
@cjagwani cjagwani changed the title test(ci): ratchet Deep Agents image test size test(ci): keep Deep Agents image test within ceiling Jul 8, 2026
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

PR Review Advisor — No blocking findings

Merge posture: No blocking advisor findings
Primary next action: No advisor follow-up required beyond maintainer review.
Open items: 0 required · 0 warnings · 0 suggestions · 0 test follow-ups

Workflow run details

This is an automated, non-binding review; it still expects maintainers and agents to respond to each required or warning item. Treat suggestions as current-PR improvements when they touch changed code; defer only with maintainer rationale or a linked follow-up. A human maintainer must make the final merge decision.

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

PR Review Advisor (Nemotron Ultra) — No blocking findings

Merge posture: No blocking advisor findings
Primary next action: No advisor follow-up required beyond maintainer review.
Open items: 0 required · 0 warnings · 0 suggestions · 0 test follow-ups
Since last review: 0 prior items resolved · 0 still apply · 0 new items found

Workflow run details

This is an automated, non-binding review; it still expects maintainers and agents to respond to each required or warning item. Treat suggestions as current-PR improvements when they touch changed code; defer only with maintainer rationale or a linked follow-up. A human maintainer must make the final merge decision.

@cjagwani

cjagwani commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator Author

@ericksoa This one-line cleanup is now a main-branch release blocker: the current main branch CI / Main run 28968975033 fails static-checks because the image test is 1,501 lines. Exact head ea892fa2b9 keeps the existing 1,500 ceiling, passes the growth guard and both advisors, and has no behavioral diff. Independent review remains the only non-CI gate while the remaining shards finish.

@cjagwani
cjagwani requested a review from jyaunches July 8, 2026 19:31

@cv cv left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contributor-compliance blocker at exact head ea892fa2: the PR body does not contain the contributor's valid Signed-off-by: declaration. Please add the declaration matching the contributor identity and rerun the canceled commit-lint, dco-check, and require-maintainer-edits contexts. Also refresh this one-line ceiling change after #6431 settles, because #6431 splits/removes the target block and may make this patch obsolete.

@cjagwani

cjagwani commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator Author

Superseded by #6493, which split the Deep Agents Code image contracts into boundary-specific test files and removed the test-size violation on main. This one-line ceiling workaround is no longer needed.

@cjagwani cjagwani closed this Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants