test(ci): keep Deep Agents image test within ceiling - #6487
Conversation
Signed-off-by: cjagwani <cjagwani@nvidia.com>
📝 WalkthroughWalkthroughThis change removes a single blank line between the ChangesTest File Whitespace Change
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall coverage remains at 96%, unchanged from the TypeScript / code-coverage/cliThe overall coverage in the Show a code coverage summary of the most impacted files.
Updated |
E2E Advisor RecommendationRequired E2E: None Full advisor summaryE2E Recommendation AdvisorBase: Required E2E
Optional E2E
New E2E recommendations
|
E2E Target RecommendationRequired E2E targets: None Full E2E target advisor summaryE2E Target AdvisorBase: Required E2E targets
Optional E2E targets
Relevant changed files
|
Signed-off-by: cjagwani <cjagwani@nvidia.com>
PR Review Advisor — No blocking findingsMerge posture: No blocking advisor findings This is an automated, non-binding review; it still expects maintainers and agents to respond to each required or warning item. Treat suggestions as current-PR improvements when they touch changed code; defer only with maintainer rationale or a linked follow-up. A human maintainer must make the final merge decision. |
PR Review Advisor (Nemotron Ultra) — No blocking findingsMerge posture: No blocking advisor findings This is an automated, non-binding review; it still expects maintainers and agents to respond to each required or warning item. Treat suggestions as current-PR improvements when they touch changed code; defer only with maintainer rationale or a linked follow-up. A human maintainer must make the final merge decision. |
|
@ericksoa This one-line cleanup is now a main-branch release blocker: the current main branch CI / Main run 28968975033 fails |
cv
left a comment
There was a problem hiding this comment.
Contributor-compliance blocker at exact head ea892fa2: the PR body does not contain the contributor's valid Signed-off-by: declaration. Please add the declaration matching the contributor identity and rerun the canceled commit-lint, dco-check, and require-maintainer-edits contexts. Also refresh this one-line ceiling change after #6431 settles, because #6431 splits/removes the target block and may make this patch obsolete.
|
Superseded by #6493, which split the Deep Agents Code image contracts into boundary-specific test files and removed the test-size violation on main. This one-line ceiling workaround is no longer needed. |
Summary
test/langchain-deepagents-code-image.test.tstest-size:checkon currentmainafter the v0.0.78 merge batch grew the file to 1,501 lines against the 1,500 defaultVerification
npx --yes @biomejs/biome check test/langchain-deepagents-code-image.test.ts ci/test-file-size-budget.jsonnpx --yes tsx scripts/check-test-file-size-budget.tsgit diff --checkNet PR diff is one blank-line deletion; no assertion or product behavior changes.
Summary by CodeRabbit
Signed-off-by: cjagwani cjagwani@nvidia.com