refactor(e2e): expose Docker prerequisites through Vitest fixtures

[jyaunches]

Summary

Expose the existing redacting Docker probe through the live Vitest fixture with explicit required, optional, and intentionally-missing policies.

Closes #6354
Parent epic: #6346

Changes

• Add DockerPrerequisite with probeDocker, requireDocker, and expectMissingDocker.
• Centralize local-skip versus CI-failure behavior for required Docker.
• Expose the prerequisite as the docker E2E fixture.
• Migrate the sandbox-operations prerequisite block.
• Preserve isolated Docker config, redacted output, and artifacts through DockerProbe.
• Add 9 focused prerequisite/probe tests.

Verification

• Signed/Verified commit and all hooks passed
• npm run build:cli
• npm run typecheck:cli
• Docker support tests: 9 passed
• No product behavior, docs, or secrets changed

---

Signed-off-by: Julie Yaunches jyaunches@nvidia.com

Summary by CodeRabbit

• Bug Fixes
  • Improved Docker availability checks for live test runs, with clearer handling when Docker is missing.
  • Tests now skip more gracefully on local machines and fail more explicitly in CI when Docker is unavailable.
  • Added coverage for Docker-present, Docker-missing, and expected-missing scenarios to make test behavior more reliable.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: cbb23b9f-30aa-4c5f-a53b-5b7edb4e059c

📥 Commits

Reviewing files that changed from the base of the PR and between b435598 and 3acf8e1.

📒 Files selected for processing (4)

• test/e2e/fixtures/docker-probe.ts
• test/e2e/fixtures/e2e-test.ts
• test/e2e/live/sandbox-operations.test.ts
• test/e2e/support/e2e-docker-prerequisite.test.ts

---

📝 Walkthrough

Walkthrough

Adds a DockerPrerequisite class wrapping DockerProbe with probeDocker, requireDocker, and expectMissingDocker methods. Exposes it as a docker fixture in E2ETargetFixtures, migrates sandbox-operations.test.ts to use it, and adds a new support test suite.

Changes

Docker Prerequisite Fixture

Layer / File(s)	Summary
DockerPrerequisite class test/e2e/fixtures/docker-probe.ts	Adds a DockerPrerequisite class with probeDocker, requireDocker (CI throws, local calls skip), and expectMissingDocker methods; reorders node:child_process imports.
Fixture exposure test/e2e/fixtures/e2e-test.ts	Adds docker to E2ETargetFixtures, constructs DockerProbe with artifacts/redaction, and yields DockerPrerequisite from base.extend.
Live test migration test/e2e/live/sandbox-operations.test.ts	Replaces manual docker info check and skip logic with await docker.requireDocker().
Support test suite test/e2e/support/e2e-docker-prerequisite.test.ts	Adds tests for available/unavailable Docker and expectMissingDocker behavior with a temp-artifacts helper.

Estimated code review effort: 2 (Simple) | ~12 minutes

Sequence Diagram(s)

sequenceDiagram
    participant Test as sandbox-operations.test.ts
    participant Fixture as E2ETestFixtures
    participant Prereq as DockerPrerequisite
    participant Probe as DockerProbe

    Test->>Fixture: request docker fixture
    Fixture->>Probe: new DockerProbe(artifacts, redact)
    Fixture->>Prereq: new DockerPrerequisite(probe, skip)
    Fixture-->>Test: docker fixture
    Test->>Prereq: requireDocker()
    Prereq->>Probe: run(["info"])
    Probe-->>Prereq: DockerCommandResult
    alt exitCode === 0
        Prereq-->>Test: resolved (Docker available)
    else exitCode !== 0
        alt isCi
            Prereq-->>Test: throw error
        else
            Prereq->>Test: skip(reason)
        end
    end

Loading

Possibly related issues

• Epic: Deduplicate and harden the Vitest E2E test infrastructure #6346: Implements the Docker prerequisite fixture consolidation described in this epic issue's sub-task.

Suggested labels: refactor

Suggested reviewers: ericksoa

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main change: exposing Docker prerequisites through Vitest fixtures for E2E tests.
Linked Issues check	✅ Passed	The changes match the issue goals by adding a Docker prerequisite fixture, centralizing policy, migrating a live test, and adding support tests.
Out of Scope Changes check	✅ Passed	No unrelated code changes are evident; the edits stay within the Docker prerequisite fixture refactor and its supporting tests.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[cv]

Maintainer review: the Docker prerequisite fixture exposes the existing availability contract without changing skip/failure semantics, with focused fixture and target coverage. Current-main synchronization cleared the stale growth failure; all exact-head checks, DCO, signatures, and review threads are clean.