Repository navigation
fix(installer): skip unreachable running sandboxes in pre-upgrade backup #6199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
9186fdd
fix(installer): skip unreachable running sandboxes in pre-upgrade backup
laitingsheng 8b53179
fix(installer): always retry pre-upgrade backup with the current CLI
laitingsheng d86d3f7
Merge remote-tracking branch 'origin/main' into fix/preupgrade-backup…
laitingsheng cf042c3
fix(sandbox): propagate unreachable through audit and tar SSH failures
laitingsheng 9b97e7c
fix(sandbox): honor SIGHUP/SIGPIPE + tighten data-loss + exact-value …
cjagwani c16310b
fix(sandbox): propagate unreachable through state-file and ssh-config…
cjagwani 56378a5
docs(backup-all): scope restore promise to installer path + add lifec…
cjagwani fac5e3c
refactor(state): extract isSshTransportFailure to ssh-transport modul…
cjagwani 4c8ba48
Merge branch 'main' into fix/preupgrade-backup-skip-unreachable
cjagwani 64e7b3c
fix(state): actually bind isSshTransportFailure locally after extract…
cjagwani ad744cf
test(installer): assert skip flag propagates into current-CLI backup …
cjagwani File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| // SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| import { describe, expect, it } from "vitest"; | ||
|
|
||
| import { isSshTransportFailure } from "./sandbox"; | ||
|
|
||
| describe("isSshTransportFailure", () => { | ||
| it("treats an ssh transport failure exit code (255) as unreachable", () => { | ||
| expect(isSshTransportFailure({ status: 255 })).toBe(true); | ||
| }); | ||
|
|
||
| it("treats a timed-out or signal-killed probe (null status) as unreachable", () => { | ||
| expect(isSshTransportFailure({ status: null })).toBe(true); | ||
| }); | ||
|
|
||
| it("treats a spawn error as unreachable", () => { | ||
| expect(isSshTransportFailure({ status: null, error: new Error("spawn ETIMEDOUT") })).toBe(true); | ||
| }); | ||
|
|
||
| it("does not treat a reachable non-zero remote exit as unreachable", () => { | ||
| expect(isSshTransportFailure({ status: 1 })).toBe(false); | ||
| expect(isSshTransportFailure({ status: 2 })).toBe(false); | ||
| }); | ||
|
|
||
| it("does not treat a successful probe as unreachable", () => { | ||
| expect(isSshTransportFailure({ status: 0 })).toBe(false); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.