fix(inference): retire GLM 5.1 endpoint selection - #6069
Merged
Conversation
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Contributor
📝 WalkthroughWalkthroughRemoves z-ai/glm-5.1 from the NVIDIA Endpoints curated model list, keeps it in Hermes Provider, and updates docs, docs tests, prompt, onboarding, and E2E fixtures to match the revised model menus. ChangesGLM-5.1 removal from NVIDIA Endpoints
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Contributor
|
🌿 Preview your docs: https://nvidia-preview-pr-6069.docs.buildwithfern.com/nemoclaw |
Contributor
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall coverage in the Show a code coverage summary of the most covered files.
TypeScript / code-coverage/cliThe overall coverage in the Show a code coverage summary of the most covered files.
Updated |
ericksoa
added
area: inference
Contributor
PR Review Advisor (Nemotron Ultra) — Changes requestedMerge posture: Do not merge yet Action checklist
Findings index
🚨 Required before mergeAddress these before merging unless a maintainer explicitly overrides the advisor with rationale.
|
Contributor
PR Review Advisor — No blocking findingsMerge posture: No blocking advisor findings This is an automated, non-binding review; it still expects maintainers and agents to respond to each required or warning item. Treat suggestions as current-PR improvements when they touch changed code; defer only with maintainer rationale or a linked follow-up. A human maintainer must make the final merge decision. |
Contributor
E2E Advisor RecommendationRequired E2E: Dispatch hint: Full advisor summaryE2E Recommendation AdvisorBase: Required E2E
Optional E2E
New E2E recommendations
Dispatch hint
|
Contributor
E2E Target RecommendationRequired E2E targets: Dispatch required E2E targets:
Full E2E target advisor summaryE2E Target AdvisorBase: Required E2E targets
Optional E2E targets
Relevant changed files
|
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
docs/inference/inference-options.mdx (1)
77-80: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winConsider wrapping the migration guidance in a Fern
<Note>callout.This paragraph warns users about catalog divergence and sandbox migration — exactly the kind of content the Fern callout components are meant for, rather than a plain paragraph.
As per coding guidelines, "Use Fern callout components such as
<Note>,<Tip>, and<Warning>for callouts in MDX pages."📝 Proposed callout wrapping
-NVIDIA Endpoints and Hermes Provider use independent model catalogs, so a model can remain available through one provider after it leaves the other's curated list. -Curated-list updates affect new onboarding choices and do not rewrite existing sandbox configurations. -Use [Switch Inference Providers](switch-inference-providers) to move an existing sandbox before its configured model becomes unavailable. +<Note> +NVIDIA Endpoints and Hermes Provider use independent model catalogs, so a model can remain available through one provider after it leaves the other's curated list. +Curated-list updates affect new onboarding choices and do not rewrite existing sandbox configurations. +Use [Switch Inference Providers](switch-inference-providers) to move an existing sandbox before its configured model becomes unavailable. +</Note>🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/inference/inference-options.mdx` around lines 77 - 80, The migration guidance in the inference options docs is currently a plain paragraph, but it should be presented as a Fern callout. Wrap the catalog-divergence and sandbox-migration text in a `<Note>` component in the inference options MDX content, keeping the existing guidance and link to Switch Inference Providers intact so the warning is visually emphasized and consistent with the docs pattern.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@docs/inference/inference-options.mdx`:
- Around line 77-80: The migration guidance in the inference options docs is
currently a plain paragraph, but it should be presented as a Fern callout. Wrap
the catalog-divergence and sandbox-migration text in a `<Note>` component in the
inference options MDX content, keeping the existing guidance and link to Switch
Inference Providers intact so the warning is visually emphasized and consistent
with the docs pattern.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 2cc33b37-cbec-4886-900f-1bf848fa2284
📒 Files selected for processing (7)
docs/inference/inference-options.mdxsrc/lib/inference/config.test.tssrc/lib/inference/config.tssrc/lib/inference/model-prompts.test.tstest/e2e/live/hermes-inference-switch-helpers.tstest/e2e/live/openclaw-inference-switch.test.tstest/onboard-selection.test.ts
💤 Files with no reviewable changes (1)
- src/lib/inference/config.ts
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
test/inference-options-docs.test.ts (1)
131-143: 📐 Maintainability & Code Quality | 🔵 TrivialMinor duplication: split the section once.
section.split("\n")is computed twice (Lines 138-139) to find each row. Could be hoisted into a single array for both lookups.♻️ Proposed refactor
- const nvidiaRow = section.split("\n").find((line) => line.startsWith("| NVIDIA Endpoints |")); - const hermesRow = section.split("\n").find((line) => line.startsWith("| Hermes Provider |")); + const lines = section.split("\n"); + const nvidiaRow = lines.find((line) => line.startsWith("| NVIDIA Endpoints |")); + const hermesRow = lines.find((line) => line.startsWith("| Hermes Provider |"));The test logic itself correctly enforces the provider-boundary contract (GLM 5.1 excluded from NVIDIA row, present in Hermes row).
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@test/inference-options-docs.test.ts` around lines 131 - 143, The test in inference-options-docs.test.ts repeats the same section split twice while locating the NVIDIA Endpoints and Hermes Provider rows. Hoist the result of section.split("\n") into a single local array in the GLM 5.1 provider-boundary test, then reuse it for both row lookups so the assertions stay the same but the parsing is done once.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@test/inference-options-docs.test.ts`:
- Around line 131-143: The test in inference-options-docs.test.ts repeats the
same section split twice while locating the NVIDIA Endpoints and Hermes Provider
rows. Hoist the result of section.split("\n") into a single local array in the
GLM 5.1 provider-boundary test, then reuse it for both row lookups so the
assertions stay the same but the parsing is done once.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 580da245-b1c6-4a3f-b5f9-9a556cdfefcf
📒 Files selected for processing (1)
test/inference-options-docs.test.ts
Contributor
Author
|
Maintainer disposition for all PR Review Advisor feedback on head
All advisor IDs and test follow-ups are therefore addressed or explicitly justified. There are no required advisor fixes remaining. |
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Contributor
Author
|
Current-head maintainer disposition for the advisor findings on The only change since the full prior disposition is the CodeRabbit-requested test refactor that reuses
All current-head required and warning items are therefore explicitly resolved or justified. |
cv
approved these changes
Jul 1, 2026
21 tasks
24 tasks
Hadar301
pushed a commit
to Hadar301/NemoClaw-OpenShift
that referenced
this pull request
Jul 12, 2026
<!-- markdownlint-disable MD041 --> ## Summary Removes `z-ai/glm-5.1` from the NVIDIA Endpoints curated onboarding choices ahead of its provider retirement and moves direct NVIDIA inference-switch test defaults to Nemotron 3 Super. The independent Hermes Provider catalog remains unchanged, and this PR does not change Kimi models. ## Changes - Remove GLM 5.1 from the NVIDIA Endpoints picker and update menu-selection coverage. - Preserve GLM 5.1 in the Hermes Provider catalog with explicit source and documentation boundary tests. - Require the task-fit documentation table to exactly match the curated onboarding model IDs. - Keep the Provider Options cells as concise provider summaries; exact catalog parity is enforced by the source-backed task-fit contract. - Replace direct NVIDIA inference-switch test defaults with `nvidia/nemotron-3-super-120b-a12b`. - Update inference documentation with the provider-catalog boundary and migration guidance for existing sandboxes. ## Type of Change - [ ] Code change (feature, bug fix, or refactor) - [x] Code change with doc updates - [ ] Doc only (prose changes, no code sample modifications) - [ ] Doc only (includes code sample changes) ## Quality Gates <!-- Check all that apply. For any "covered by existing tests", "not applicable", or waiver entry, add a brief justification on the same line or in the Changes section. --> - [x] Tests added or updated for changed behavior - [ ] Existing tests cover changed behavior — justification: - [ ] Tests not applicable — justification: - [x] Docs updated for user-facing behavior changes - [ ] Docs not applicable — justification: - [x] Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging) - [ ] Sensitive-path review completed or maintainer-approved waiver recorded — reviewer/approval link/justification: - [ ] Non-success, skipped, or missing CI check accepted by maintainer — check name, approval link, and follow-up issue: ## Verification <!-- Check each item you ran and confirmed. Leave unchecked items you skipped. Doc-only changes do not require npm test unless you ran it. --> - [x] PR description includes the DCO sign-off declaration and every commit appears as `Verified` in GitHub - [x] Git hooks passed during commit and push, or `npx prek run --from-ref main --to-ref HEAD` passes - [x] Targeted tests pass for changed behavior - [ ] Full `npm test` passes (broad runtime changes only) - [x] Quality Gates section completed with required justifications or waivers - [x] No secrets, API keys, or credentials committed - [ ] `npm run docs` builds without warnings (doc changes only) - [x] Doc pages follow the [style guide](https://github.com/NVIDIA/NemoClaw/blob/main/docs/CONTRIBUTING.md) (doc changes only) - [ ] New doc pages include SPDX header and frontmatter (new pages only) --- <!-- DCO sign-off is required in this PR description, and every commit must appear as Verified in GitHub. Run: git config user.name && git config user.email --> Signed-off-by: Aaron Erickson <aerickson@nvidia.com> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Updated cloud model selection to remove an unavailable option and align the picker with current provider availability. * Clarified provider-specific model availability so existing setups can be migrated when a selected model is no longer offered. * Adjusted related selection flows and automated checks to match the updated model lists. * **Documentation** * Improved inference guidance to reflect the latest curated model options and provider-specific catalog behavior. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes
z-ai/glm-5.1from the NVIDIA Endpoints curated onboarding choices ahead of its provider retirement and moves direct NVIDIA inference-switch test defaults to Nemotron 3 Super. The independent Hermes Provider catalog remains unchanged, and this PR does not change Kimi models.Changes
nvidia/nemotron-3-super-120b-a12b.Type of Change
Quality Gates
Verification
Verifiedin GitHubnpx prek run --from-ref main --to-ref HEADpassesnpm testpasses (broad runtime changes only)npm run docsbuilds without warnings (doc changes only)Signed-off-by: Aaron Erickson aerickson@nvidia.com
Summary by CodeRabbit
Bug Fixes
Documentation