Skip to content

fix(messaging): install botbuilder SDK for hermes Teams channel #6045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TonyLuo-NV wants to merge 1 commit into from
Closed

fix(messaging): install botbuilder SDK for hermes Teams channel #6045

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/lib/messaging/channels/manifests.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -769,10 +769,17 @@ describe("built-in channel manifests", () => {
required: true,
});
expect(teamsManifest.agentPackages).toContainEqual({
id: "hermesTeamsAppsPackage",
id: "hermesBotbuilderCorePackage",
agent: "hermes",
manager: "hermes-uv-pip",
spec: "microsoft-teams-apps==2.0.13.4",
spec: "botbuilder-core==4.17.1",
required: true,
});
expect(teamsManifest.agentPackages).toContainEqual({
id: "hermesBotbuilderAiohttpPackage",
agent: "hermes",
manager: "hermes-uv-pip",
spec: "botbuilder-integration-aiohttp==4.17.1",
required: true,
});
expect(teamsManifest.agentPackages).toContainEqual({
Expand Down
11 changes: 9 additions & 2 deletions src/lib/messaging/channels/metadata.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,10 +156,17 @@ describe("built-in messaging channel metadata", () => {
expect(listMessagingPackageInstallSpecs({ agent: "hermes" })).toEqual([
{
channelId: "teams",
packageId: "hermesTeamsAppsPackage",
packageId: "hermesBotbuilderCorePackage",
agents: ["hermes"],
manager: "hermes-uv-pip",
spec: "microsoft-teams-apps==2.0.13.4",
spec: "botbuilder-core==4.17.1",
},
{
channelId: "teams",
packageId: "hermesBotbuilderAiohttpPackage",
agents: ["hermes"],
manager: "hermes-uv-pip",
spec: "botbuilder-integration-aiohttp==4.17.1",
},
{
channelId: "teams",
Expand Down
11 changes: 9 additions & 2 deletions src/lib/messaging/channels/teams/manifest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,10 +195,17 @@ export const teamsManifest = {
required: true,
},
{
id: "hermesTeamsAppsPackage",
id: "hermesBotbuilderCorePackage",
agent: "hermes",
manager: "hermes-uv-pip",
spec: "microsoft-teams-apps==2.0.13.4",
spec: "botbuilder-core==4.17.1",
required: true,
},
{
id: "hermesBotbuilderAiohttpPackage",
agent: "hermes",
manager: "hermes-uv-pip",
spec: "botbuilder-integration-aiohttp==4.17.1",
required: true,
},
{
Expand Down
14 changes: 12 additions & 2 deletions src/lib/messaging/compiler/manifest-compiler.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,11 +433,21 @@ describe("ManifestCompiler", () => {
{
channelId: "teams",
kind: "package-install",
outputId: "hermesTeamsAppsPackage",
outputId: "hermesBotbuilderCorePackage",
required: true,
value: {
manager: "hermes-uv-pip",
spec: "microsoft-teams-apps==2.0.13.4",
spec: "botbuilder-core==4.17.1",
},
},
{
channelId: "teams",
kind: "package-install",
outputId: "hermesBotbuilderAiohttpPackage",
required: true,
value: {
manager: "hermes-uv-pip",
spec: "botbuilder-integration-aiohttp==4.17.1",
},
},
{
Expand Down
5 changes: 3 additions & 2 deletions test/messaging-build-applier.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -638,7 +638,8 @@ describe("messaging-build-applier.mts: agent-install", () => {
);
expect(dryRun.status, dryRun.stderr).toBe(0);
expect(JSON.parse(dryRun.stdout).hermesUvPackages).toEqual([
"microsoft-teams-apps==2.0.13.4",
"botbuilder-core==4.17.1",
"botbuilder-integration-aiohttp==4.17.1",
"aiohttp==3.14.1",
]);

Expand All @@ -662,7 +663,7 @@ describe("messaging-build-applier.mts: agent-install", () => {

expect(result.status, result.stderr).toBe(0);
expect(fs.readFileSync(tracePath, "utf-8").trim()).toBe(
"pip install --python /opt/hermes/.venv/bin/python --no-cache -- microsoft-teams-apps==2.0.13.4 aiohttp==3.14.1",
"pip install --python /opt/hermes/.venv/bin/python --no-cache -- botbuilder-core==4.17.1 botbuilder-integration-aiohttp==4.17.1 aiohttp==3.14.1",
);
} finally {
fs.rmSync(tmp, { recursive: true, force: true });
Expand Down
Loading