-
Notifications
You must be signed in to change notification settings - Fork 3.1k
fix(inference): add sandbox-scoped inference get/set commands (#5977) #5989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
1c77e7b
fix(inference): add sandbox-scoped inference get/set commands (#5977)
yimoj 62971d8
fix(inference): address review on sandbox inference set (#5977)
yimoj 1f416e1
test(inference): cover sandbox inference command adapters (#5977)
yimoj b4f8f5c
test(inference): address review on sandbox inference adapters (#5977)
yimoj 3c62843
test(inference): expand command-layer negative tests and doc cross-re…
yimoj 53500a2
test(inference): cover empty --model rejection at command boundary (#…
yimoj cb21fc0
test(inference): cover public-dispatch reporter path for sandbox infe…
yimoj 1ade1c5
Merge remote-tracking branch 'upstream/main' into fix/5977-sandbox-in…
yimoj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| // SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| import { InferenceGetError, runInferenceGet } from "../../../lib/actions/inference-get"; | ||
| import { NemoClawCommand } from "../../../lib/cli/nemoclaw-oclif-command"; | ||
| import { sandboxNameArg } from "../../../lib/sandbox/command-support"; | ||
|
|
||
| // Sandbox-first mirror of the global inference:get command; both delegate to | ||
| // the shared runInferenceGet action that reads the gateway-wide route. | ||
| export default class SandboxInferenceGetCommand extends NemoClawCommand { | ||
| static id = "sandbox:inference:get"; | ||
| static strict = true; | ||
| static enableJsonFlag = true; | ||
| static summary = "Show the active NemoClaw inference route"; | ||
| static description = | ||
| "Read the live OpenShell inference route through the NemoClaw CLI. The route is gateway-wide; the sandbox name is accepted so the sandbox-scoped grammar mirrors `inference set`."; | ||
| static usage = ["<name> inference get [--json]"]; | ||
| static examples = [ | ||
| "<%= config.bin %> my-assistant inference get", | ||
| "<%= config.bin %> my-assistant inference get --json", | ||
| ]; | ||
| static args = { | ||
| sandboxName: sandboxNameArg, | ||
| }; | ||
| static flags = {}; | ||
|
|
||
| public async run(): Promise<unknown> { | ||
| await this.parse(SandboxInferenceGetCommand); | ||
| try { | ||
| const result = await runInferenceGet({ quiet: this.jsonEnabled() }); | ||
| if (this.jsonEnabled()) return result; | ||
| } catch (error) { | ||
| if (error instanceof InferenceGetError) { | ||
| this.failWithLines([error.message], error.exitCode); | ||
| return; | ||
| } | ||
| throw error; | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.