test: make test titles behavior-oriented by cv · Pull Request #5918 · NVIDIA/NemoClaw

cv · 2026-06-28T02:05:32Z

Summary

Rewrites 316 Vitest suite and case titles so behavioral descriptions lead and local issue references use a final (#NNNN) suffix. Adds an AST-backed repository check and npm run test:spec, which uses Vitest's tree reporter to render the suite as hierarchical behavioral documentation.

Changes

Normalize issue-first, metadata-led, fragmented, and arrow-label titles across CLI, plugin, integration, package-contract, and E2E support tests.
Add scripts/checks/test-title-style.ts with unit coverage, include it in repository checks, and expose it as npm run test:titles:check.
Add npm run test:spec and document the behavioral-title convention for contributors and agents.
Leave production behavior unchanged; this PR changes test descriptions and contributor tooling only.

Type of Change

Code change (feature, bug fix, or refactor)
Code change with doc updates
Doc only (prose changes, no code sample modifications)
Doc only (includes code sample changes)

Quality Gates

Tests added or updated for changed behavior
Existing tests cover changed behavior — justification:
Tests not applicable — justification:
Docs updated for user-facing behavior changes
Docs not applicable — justification: No product-facing behavior changed; contributor guidance is updated in CONTRIBUTING.md and AGENTS.md.
Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging)
Sensitive-path review completed or maintainer-approved waiver recorded — reviewer/approval link/justification:
Non-success, skipped, or missing CI check accepted by maintainer — check name, approval link, and follow-up issue:

Verification

PR description includes the DCO sign-off declaration and every commit appears as Verified in GitHub
Git hooks passed during commit and push, or npx prek run --from-ref main --to-ref HEAD passes
Targeted tests pass for changed behavior
Full npm test passes (broad runtime changes only)
Quality Gates section completed with required justifications or waivers
No secrets, API keys, or credentials committed
npm run docs builds without warnings (doc changes only)
Doc pages follow the style guide (doc changes only)
New doc pages include SPDX header and frontmatter (new pages only)

Signed-off-by: Carlos Villela cvillela@nvidia.com

Signed-off-by: Carlos Villela <cvillela@nvidia.com>

coderabbitai · 2026-06-28T02:06:02Z

📝 Walkthrough

Walkthrough

Introduces a new scripts/checks/test-title-style.ts linter that uses the TypeScript compiler API to enforce describe/it title conventions (behavior-first phrasing, trailing (#NNN) issue suffix). Wires it into scripts/checks/run.ts and package.json, documents it in AGENTS.md and CONTRIBUTING.md, adds unit tests, and reformats test titles across ~200 test files to comply.

Changes

Test title style linter and enforcement

Layer / File(s)	Summary
Linter types, rules, and AST scanner `scripts/checks/test-title-style.ts`	Exports `TestTitleRule` and `TestTitleViolation` types, defines regex-based validation rules, AST traversal helpers, and `scanTestTitleStyle`/`findTestTitleStyleViolations` entry points with a `main()` CLI runner.
Package scripts, check runner wiring, and docs `package.json`, `scripts/checks/run.ts`, `AGENTS.md`, `CONTRIBUTING.md`	Adds `test:spec` and `test:titles:check` npm scripts, registers `test-title-style` in the `CHECKS` list, and documents the title conventions and new commands.
Linter unit tests `test/test-title-style.test.ts`	Verifies the scanner detects the expected ordered violation rules for a mixed fixture, accepts compliant titles with final issue suffixes, and ignores external `owner/repo#N` references and non-literal titles.
Mass test title reformatting `nemoclaw/src/blueprint/ssrf.test.ts`, `nemoclaw/src/security/secret-scanner.test.ts`, `src/lib/.../.test.ts`, `test/.../.test.ts`	Applies the new convention (behavior-first phrasing, trailing `(`#NNN`)` suffix) across all test files. No test logic or assertions are changed.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

NVIDIA/NemoClaw#5500: Touches src/lib/onboard/preflight-cdi.test.ts in the same shouldEnforceCdiNvidiaGpuSpec suite that this PR reformats for title-style compliance.

Suggested labels

documentation, chore

Suggested reviewers

cjagwani
sandl99

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly matches the main change: rewriting test titles to be behavior-oriented.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch codex/test-title-agiledox

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@test/repro-2749-extra.test.ts`:
- Line 46: Update the describe title in the test file from coverage/meta wording
to a behavior-oriented phrase that describes the observable tls:terminate
scenario being exercised, and keep the local issue reference only as a final
suffix like (`#2749`). Use the existing describe block for the tls:terminate guard
as the unique symbol to locate and rename the test title accordingly.

In `@test/test-title-style.test.ts`:
- Line 14: The `describe(...)` title in the `test title style scanner` suite is
subject-oriented instead of behavior-oriented. Rename the suite in the
`describe` block to a contract-style title that states the observable behavior
being verified, keeping it consistent with the `test/**/*.test.{js,ts}` naming
convention enforced by this PR.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 73d4bcb9-6cd2-424a-82f6-554908d941a1

📥 Commits

Reviewing files that changed from the base of the PR and between 047cc89 and db14e3f.

📒 Files selected for processing (117)

AGENTS.md
CONTRIBUTING.md
nemoclaw/src/blueprint/ssrf.test.ts
nemoclaw/src/security/secret-scanner.test.ts
package.json
scripts/checks/run.ts
scripts/checks/test-title-style.ts
src/lib/actions/sandbox/agent/passthrough.test.ts
src/lib/actions/sandbox/auto-pair-approval.test.ts
src/lib/actions/sandbox/auto-pair-warmup.test.ts
src/lib/actions/sandbox/gateway-wedge-diagnostics.test.ts
src/lib/actions/sandbox/policy-channel-conflict.test.ts
src/lib/actions/sandbox/process-recovery.test.ts
src/lib/actions/sandbox/rebuild-env-isolation.test.ts
src/lib/actions/sandbox/rebuild-flow.test.ts
src/lib/actions/uninstall/run-plan.test.ts
src/lib/actions/update.test.ts
src/lib/adapters/openshell/resolve.test.ts
src/lib/adapters/openshell/timeouts.test.ts
src/lib/agent/onboard.test.ts
src/lib/agent/runtime.test.ts
src/lib/build-context.test.ts
src/lib/channel-runtime-status.test.ts
src/lib/cli/oclif-runner.test.ts
src/lib/core/stdin.test.ts
src/lib/core/version.test.ts
src/lib/domain/sandbox/logs.test.ts
src/lib/domain/uninstall/paths.test.ts
src/lib/inference/config.test.ts
src/lib/inference/nim.test.ts
src/lib/inference/onboard-probes.test.ts
src/lib/inventory/index.test.ts
src/lib/onboard/bridge-dns-preflight.test.ts
src/lib/onboard/docker-gpu-local-inference.test.ts
src/lib/onboard/docker-gpu-patch.test.ts
src/lib/onboard/dockerfile-patch.test.ts
src/lib/onboard/gateway-sandbox-reachability.test.ts
src/lib/onboard/gateway-start-failure-integration.test.ts
src/lib/onboard/hermes-dashboard.test.ts
src/lib/onboard/install-ollama-linux.test.ts
src/lib/onboard/legacy-command.test.ts
src/lib/onboard/machine/handlers/finalization.test.ts
src/lib/onboard/machine/transitions.test.ts
src/lib/onboard/messaging-channel-setup.test.ts
src/lib/onboard/model-router-process.test.ts
src/lib/onboard/model-router-python.test.ts
src/lib/onboard/ollama-startup.test.ts
src/lib/onboard/preflight-cdi.test.ts
src/lib/onboard/preflight.test.ts
src/lib/registry-recovery-action.test.ts
src/lib/sandbox-base-image.test.ts
src/lib/shields/timer.test.ts
src/lib/state/onboard-session.test.ts
src/lib/tunnel/services.test.ts
src/lib/validation.test.ts
src/lib/verify-deployment.test.ts
test/channels-add-preset.test.ts
test/channels-remove-full-teardown.test.ts
test/cli/connect-recovery-settle.test.ts
test/cli/dispatch-basics.test.ts
test/cli/onboard-compatibility.test.ts
test/credentials.test.ts
test/destroy-wipe-sandbox-state.test.ts
test/e2e-scenario/live/openclaw-tui-chat-correlation.test.ts
test/e2e-scenario/support-tests/ci-compatible-inference.test.ts
test/e2e-scenario/support-tests/e2e-scenario-matrix.test.ts
test/gateway-state-reconcile-2276.test.ts
test/generate-hermes-config.test.ts
test/generate-openclaw-config.test.ts
test/generate-platform-docs.test.ts
test/hermes-gateway-wrapper.test.ts
test/host-artifact-cleanup.test.ts
test/http-proxy-fix-rewrite.test.ts
test/install-preflight.test.ts
test/install-stage-from-stdin.test.ts
test/install-upgrade-sandboxes-severity.test.ts
test/issue-4434-tui-unreachable-inference.test.ts
test/issue-5667-hosted-inference-model-namespace.test.ts
test/messaging-build-applier.test.ts
test/nemo-deepagents-alias.test.ts
test/nemoclaw-start-gateway-health.test.ts
test/nemoclaw-start-plugin-refresh.test.ts
test/nemoclaw-start.test.ts
test/nemohermes-alias.test.ts
test/ollama-tools-capability.test.ts
test/onboard-ollama-autostart.test.ts
test/onboard-preset-diff.test.ts
test/onboard.test.ts
test/openclaw-chat-send-patch.test.ts
test/openclaw-tui-chat-correlation.test.ts
test/package-contract/cli/policy-dispatch.test.ts
test/package-contract/repro-2010.test.ts
test/package-contract/ssrf-parity.test.ts
test/platform.test.ts
test/policies.test.ts
test/policy-tiers.test.ts
test/rebuild-credential-hydration.test.ts
test/rebuild-credential-preflight.test.ts
test/rebuild-shields-auto-unlock.test.ts
test/rebuild-stale-recovery.test.ts
test/repro-1751-extra.test.ts
test/repro-2201.test.ts
test/repro-2376.test.ts
test/repro-2666-silent-list-status.test.ts
test/repro-2749-extra.test.ts
test/repro-4538-raw-doctor-perms.test.ts
test/runner.test.ts
test/sandbox-init.test.ts
test/sandbox-provisioning.test.ts
test/security-sandbox-tar-traversal.test.ts
test/service-env.test.ts
test/snapshot-restore-existing-dest.test.ts
test/stale-dist-check.test.ts
test/test-title-style.test.ts
test/uninstall.test.ts
test/validate-blueprint.test.ts
test/wsl2-probe-timeout.test.ts

github-code-quality · 2026-06-28T02:22:12Z

Code Coverage Overview

Languages: TypeScript

TypeScript / code-coverage/plugin

The overall coverage in the codex/test-title-agi... branch is 96%. Coverage data for the main branch is not yet available.

Show a code coverage summary of the most covered files.

File	`main`	`codex/test-title-agi...` d11fe77	+/-
`nemoclaw/src/se...cret-scanner.ts`	—	100%	—
`nemoclaw/src/commands/slash.ts`	—	100%	—
`nemoclaw/src/li...bprocess-env.ts`	—	100%	—
`nemoclaw/src/bl...eprint/state.ts`	—	98%	—
`nemoclaw/src/onboard/config.ts`	—	98%	—
`nemoclaw/src/bl...int/snapshot.ts`	—	97%	—
`nemoclaw/src/bl...print/runner.ts`	—	95%	—
`nemoclaw/src/co...ration-state.ts`	—	94%	—
`nemoclaw/src/bl...ate-networks.ts`	—	94%	—
`nemoclaw/src/index.ts`	—	94%	—

TypeScript / code-coverage/cli

The overall coverage in the codex/test-title-agi... branch is 68%. Coverage data for the main branch is not yet available.

Show a code coverage summary of the most covered files.

File	`main`	`codex/test-title-agi...` d11fe77	+/-
`src/lib/actions...all/run-plan.ts`	—	80%	—
`src/lib/state/o...oard-session.ts`	—	79%	—
`src/lib/actions...dbox/rebuild.ts`	—	74%	—
`src/lib/state/sandbox.ts`	—	72%	—
`src/lib/shields/index.ts`	—	70%	—
`src/lib/onboard/preflight.ts`	—	69%	—
`src/lib/actions...licy-channel.ts`	—	59%	—
`src/lib/onboard...er-gpu-patch.ts`	—	59%	—
`src/lib/policy/index.ts`	—	52%	—
`src/lib/onboard.ts`	—	20%	—

_{Updated June 28, 2026 02:26 UTC
Code Coverage is in Public Preview. Learn more and provide us with your feedback.}

github-actions · 2026-06-28T02:22:20Z

🌿 Preview your docs: https://nvidia-preview-pr-5918.docs.buildwithfern.com/nemoclaw

github-actions · 2026-06-28T02:23:08Z

E2E Advisor Recommendation

Required E2E: None
Optional E2E: None

Workflow run

Full advisor summary

E2E Recommendation Advisor

Base: origin/main
Head: HEAD
Confidence: high

Required E2E

None. No E2E jobs are required. This PR is documentation, test-title rewrites, and repository test-tooling changes only. It does not modify production code paths for installer/onboarding, sandbox lifecycle, credentials, security boundaries, network policy, inference routing, deployment, or real assistant user flows.

Optional E2E

None.

New E2E recommendations

None.

github-actions · 2026-06-28T02:23:09Z

Vitest E2E Scenario Recommendation

Required Vitest E2E scenarios: openclaw-tui-chat-correlation-vitest
Optional Vitest E2E scenarios: None

Dispatch required Vitest E2E scenarios:

gh workflow run e2e-vitest-scenarios.yaml --ref <pr-head-ref> --field jobs=openclaw-tui-chat-correlation-vitest

Workflow run

Full Vitest E2E advisor summary

Vitest E2E Scenario Advisor

Base: origin/main
Head: HEAD
Confidence: high

Required Vitest E2E scenarios

openclaw-tui-chat-correlation-vitest: Focused free-standing Vitest job wired for changed live test test/e2e-scenario/live/openclaw-tui-chat-correlation.test.ts.
- Dispatch: gh workflow run e2e-vitest-scenarios.yaml --ref <pr-head-ref> --field jobs=openclaw-tui-chat-correlation-vitest

Optional Vitest E2E scenarios

None.

Relevant changed files

test/e2e-scenario/live/openclaw-tui-chat-correlation.test.ts
test/e2e-scenario/support-tests/ci-compatible-inference.test.ts
test/e2e-scenario/support-tests/e2e-scenario-matrix.test.ts

github-actions · 2026-06-28T02:24:05Z

PR Review Advisor (Nemotron Ultra) — No blocking findings

Merge posture: No blocking advisor findings
Primary next action: Add or justify PRA-T1 and any related test follow-ups.
Open items: 0 required · 0 warnings · 3 suggestions · 6 test follow-ups
Since last review: 0 prior items resolved · 0 still apply · 0 new items found

Action checklist

PRA-T1 Add or justify test follow-up: Runtime validation
PRA-T2 Add or justify test follow-up: Runtime validation
PRA-T3 Add or justify test follow-up: Runtime validation
PRA-T4 Add or justify test follow-up: Runtime validation
PRA-T5 Add or justify test follow-up: Pre-existing test title uses bare issue number without parentheses suffix
PRA-T6 Add or justify test follow-up: DEFAULT_SCAN_ROOTS and roots parameter are single-use config
PRA-1 In-scope improvement: Pre-existing test title uses bare issue number without parentheses suffix in test/destroy-wipe-sandbox-state.test.ts:72
PRA-2 In-scope improvement: DEFAULT_SCAN_ROOTS and roots parameter are single-use config in scripts/checks/test-title-style.ts:28
PRA-3 In-scope improvement: New npm scripts need runtime validation in package.json:13

Findings index

ID	Severity	Category	Location	Required action
`PRA-1`	Improvement	tests	`test/destroy-wipe-sandbox-state.test.ts:72`	Fix in follow-up PR or when file is next touched; not blocking for this mechanical refactor.
`PRA-2`	Improvement	tests	`scripts/checks/test-title-style.ts:28`	Inline the default roots array directly in `findTestTitleStyleViolations` and remove the parameter; or keep as constant but drop the parameter.
`PRA-3`	Improvement	workflow	`package.json:13`	Run `npm run test:spec` and `npm run test:titles:check` locally before merge to confirm they work as documented.

Review findings by urgency: 0 required fixes, 0 items to resolve/justify, 3 in-scope improvements

⚠️ Resolve or justify before merge

Investigate these in the current review; either fix them, explain why they are not applicable, or document the accepted risk.

None.

💡 In-scope improvements

These are lower-risk, not throwaway. Prefer fixing them in this PR when they are local to changed code; defer only with rationale or a linked follow-up.

`PRA-1` Improvement — Pre-existing test title uses bare issue number without parentheses suffix

Location: test/destroy-wipe-sandbox-state.test.ts:72
Category: tests
Problem: Test title 'also removes multi-agent workspace-* dirs (Multi-agent deployments need workspace sync strategy — docs assume single agent #1260)' uses bare `Multi-agent deployments need workspace sync strategy — docs assume single agent #1260` instead of the new `(Multi-agent deployments need workspace sync strategy — docs assume single agent #1260)` suffix convention. The linter will flag this as an 'issue-reference-suffix' violation.
Impact: Linter will report violation in CI; test documentation not fully consistent with new convention.
Suggested action: Fix in follow-up PR or when file is next touched; not blocking for this mechanical refactor.
Expected follow-up: Prefer a current-PR fix when local to changed code; defer only with rationale or linked follow-up.
Verification: Run `npm run test:titles:check` and observe violation for destroy-wipe-sandbox-state.test.ts:72
Missing regression test: None needed; linter already enforces the convention
Done when: The local improvement is applied, or the PR notes why it should be deferred.
Evidence: diff shows title unchanged at line 72; linter rule 'issue-reference-suffix' requires final '(#NNNN)' suffix

`PRA-2` Improvement — DEFAULT_SCAN_ROOTS and roots parameter are single-use config

Location: scripts/checks/test-title-style.ts:28
Category: tests
Problem: The `DEFAULT_SCAN_ROOTS` constant and `roots` parameter in `findTestTitleStyleViolations` are only ever used with the default value. No caller passes a custom roots array.
Impact: Unnecessary configurability adds cognitive overhead; a constant would be clearer until a second consumer exists.
Suggested action: Inline the default roots array directly in `findTestTitleStyleViolations` and remove the parameter; or keep as constant but drop the parameter.
Expected follow-up: Prefer a current-PR fix when local to changed code; defer only with rationale or linked follow-up.
Verification: Search for calls to `findTestTitleStyleViolations` — none pass a custom roots argument
Missing regression test: None; refactoring only
Done when: The local improvement is applied, or the PR notes why it should be deferred.
Evidence: Only call in main() uses default; no external consumers

`PRA-3` Improvement — New npm scripts need runtime validation

Location: package.json:13
Category: workflow
Problem: Scripts `test:spec` (uses `--reporter=tree`) and `test:titles:check` added but not yet verified in this review environment.
Impact: Contributors may encounter issues if tree reporter or linter integration has regressions.
Suggested action: Run `npm run test:spec` and `npm run test:titles:check` locally before merge to confirm they work as documented.
Expected follow-up: Prefer a current-PR fix when local to changed code; defer only with rationale or linked follow-up.
Verification: Execute `npm run test:spec` — should render hierarchical tree; execute `npm run test:titles:check` — should pass on refactored files
Missing regression test: Manual verification of new npm scripts; no automated test needed
Done when: The local improvement is applied, or the PR notes why it should be deferred.
Evidence: package.json adds both scripts; CONTRIBUTING.md documents them

Simplification opportunities: 1 possible cut, net -5 lines possible

These are safe simplification checks only. Do not remove validation, security controls, data-loss prevention, or required tests.

PRA-2 shrink (scripts/checks/test-title-style.ts:28): DEFAULT_SCAN_ROOTS constant and roots parameter in findTestTitleStyleViolations
- Replacement: Inline ['src', 'test', 'nemoclaw/src'] directly in function body
- Net: -5 lines
- Safety boundary: Must not change which directories are scanned; only removes unused configurability

Test follow-ups to resolve or justify

If these cover changed behavior, prefer adding them in this PR; otherwise state why existing coverage is enough or link the follow-up.

PRA-T1 Runtime validation — Run npm run test:titles:check and verify it passes on all refactored files. New npm scripts (test:spec, test:titles:check) and linter integration need runtime verification; unit tests for linter are sufficient.
PRA-T2 Runtime validation — Run npm run test:spec and verify hierarchical tree renders with issue suffixes. New npm scripts (test:spec, test:titles:check) and linter integration need runtime verification; unit tests for linter are sufficient.
PRA-T3 Runtime validation — Run npm run checks and verify test-title-style runs in pipeline after Biome/layer-import-boundaries. New npm scripts (test:spec, test:titles:check) and linter integration need runtime verification; unit tests for linter are sufficient.
PRA-T4 Runtime validation — Verify linter ignores dynamic titles (variables) and external refs (owner/repo#123). New npm scripts (test:spec, test:titles:check) and linter integration need runtime verification; unit tests for linter are sufficient.
PRA-T5 Pre-existing test title uses bare issue number without parentheses suffix — Fix in follow-up PR or when file is next touched; not blocking for this mechanical refactor.
PRA-T6 DEFAULT_SCAN_ROOTS and roots parameter are single-use config — Inline the default roots array directly in `findTestTitleStyleViolations` and remove the parameter; or keep as constant but drop the parameter.

Since last review details

Current findings, using the urgency labels above:

`PRA-1` Improvement — Pre-existing test title uses bare issue number without parentheses suffix

Location: test/destroy-wipe-sandbox-state.test.ts:72
Category: tests
Problem: Test title 'also removes multi-agent workspace-* dirs (Multi-agent deployments need workspace sync strategy — docs assume single agent #1260)' uses bare `Multi-agent deployments need workspace sync strategy — docs assume single agent #1260` instead of the new `(Multi-agent deployments need workspace sync strategy — docs assume single agent #1260)` suffix convention. The linter will flag this as an 'issue-reference-suffix' violation.
Impact: Linter will report violation in CI; test documentation not fully consistent with new convention.
Suggested action: Fix in follow-up PR or when file is next touched; not blocking for this mechanical refactor.
Expected follow-up: Prefer a current-PR fix when local to changed code; defer only with rationale or linked follow-up.
Verification: Run `npm run test:titles:check` and observe violation for destroy-wipe-sandbox-state.test.ts:72
Missing regression test: None needed; linter already enforces the convention
Done when: The local improvement is applied, or the PR notes why it should be deferred.
Evidence: diff shows title unchanged at line 72; linter rule 'issue-reference-suffix' requires final '(#NNNN)' suffix

`PRA-2` Improvement — DEFAULT_SCAN_ROOTS and roots parameter are single-use config

Location: scripts/checks/test-title-style.ts:28
Category: tests
Problem: The `DEFAULT_SCAN_ROOTS` constant and `roots` parameter in `findTestTitleStyleViolations` are only ever used with the default value. No caller passes a custom roots array.
Impact: Unnecessary configurability adds cognitive overhead; a constant would be clearer until a second consumer exists.
Suggested action: Inline the default roots array directly in `findTestTitleStyleViolations` and remove the parameter; or keep as constant but drop the parameter.
Expected follow-up: Prefer a current-PR fix when local to changed code; defer only with rationale or linked follow-up.
Verification: Search for calls to `findTestTitleStyleViolations` — none pass a custom roots argument
Missing regression test: None; refactoring only
Done when: The local improvement is applied, or the PR notes why it should be deferred.
Evidence: Only call in main() uses default; no external consumers

`PRA-3` Improvement — New npm scripts need runtime validation

Location: package.json:13
Category: workflow
Problem: Scripts `test:spec` (uses `--reporter=tree`) and `test:titles:check` added but not yet verified in this review environment.
Impact: Contributors may encounter issues if tree reporter or linter integration has regressions.
Suggested action: Run `npm run test:spec` and `npm run test:titles:check` locally before merge to confirm they work as documented.
Expected follow-up: Prefer a current-PR fix when local to changed code; defer only with rationale or linked follow-up.
Verification: Execute `npm run test:spec` — should render hierarchical tree; execute `npm run test:titles:check` — should pass on refactored files
Missing regression test: Manual verification of new npm scripts; no automated test needed
Done when: The local improvement is applied, or the PR notes why it should be deferred.
Evidence: package.json adds both scripts; CONTRIBUTING.md documents them

Workflow run details

This is an automated, non-binding review; it still expects maintainers and agents to respond to each required or warning item. Treat suggestions as current-PR improvements when they touch changed code; defer only with maintainer rationale or a linked follow-up. A human maintainer must make the final merge decision.

github-actions · 2026-06-28T02:24:07Z

PR Review Advisor — No blocking findings

Merge posture: No blocking advisor findings
Primary next action: Add or justify PRA-T1 and any related test follow-ups.
Open items: 0 required · 0 warnings · 0 suggestions · 3 test follow-ups

Action checklist

PRA-T1 Add or justify test follow-up: Runtime validation
PRA-T2 Add or justify test follow-up: Runtime validation
PRA-T3 Add or justify test follow-up: Runtime validation

Test follow-ups to resolve or justify

If these cover changed behavior, prefer adding them in this PR; otherwise state why existing coverage is enough or link the follow-up.

PRA-T1 Runtime validation — findTestTitleStyleViolations scans the default src, test, and nemoclaw/src roots while skipping dist and node_modules. The core checker behavior has focused unit coverage, and the broad title rewrites appear title-only. Additional runtime validation would mainly increase confidence in package-script/check-runner integration rather than cover a currently identified defect.
PRA-T2 Runtime validation — repository checks invoke test-title-style after vitest-project-overlap. The core checker behavior has focused unit coverage, and the broad title rewrites appear title-only. Additional runtime validation would mainly increase confidence in package-script/check-runner integration rather than cover a currently identified defect.
PRA-T3 Runtime validation — test:spec forwards --reporter=tree to the non-live Vitest run. The core checker behavior has focused unit coverage, and the broad title rewrites appear title-only. Additional runtime validation would mainly increase confidence in package-script/check-runner integration rather than cover a currently identified defect.

Workflow run details

This is an automated, non-binding review; it still expects maintainers and agents to respond to each required or warning item. Treat suggestions as current-PR improvements when they touch changed code; defer only with maintainer rationale or a linked follow-up. A human maintainer must make the final merge decision.

github-actions · 2026-06-28T02:32:02Z

Vitest E2E Scenario Results — ✅ All requested jobs passed

Run: 28308785234
Workflow ref: codex/test-title-agiledox
Requested scenarios: (default — all supported)
Requested jobs: openclaw-tui-chat-correlation-vitest
Summary: 1 passed, 0 failed, 0 cancelled, 0 skipped

Job	Result
openclaw-tui-chat-correlation-vitest	✅ success

cv · 2026-06-28T02:33:01Z

Follow-up verification is complete.

CodeRabbit's two title findings were addressed in 924f4b969; its re-review reports no new actionable comments and marks both prior threads addressed.
PR Review Advisor reports no blocking findings. Its #1260 suffix suggestion is a false positive: test/destroy-wipe-sandbox-state.test.ts already uses the final (#1260) form. The exported roots parameter remains as a useful programmatic scan seam, consistent with the repository's other test scanner.
Runtime follow-ups are satisfied: npm run test:titles:check, npm run checks, and a focused npm run test:spec -- src/lib/core/stdin.test.ts all pass; scanner unit tests cover dynamic titles and external owner/repo#123 references.
Full local npm test: 814 files passed, 2 skipped; 9,551 tests passed, 18 skipped.
Full PR matrix: 42 successful, 2 intentional skips, 0 failures.
Advisor-required live scenario openclaw-tui-chat-correlation-vitest: passed in run 28308785234.

## Summary Rewrites 316 Vitest suite and case titles so behavioral descriptions lead and local issue references use a final `(#NNNN)` suffix. Adds an AST-backed repository check and `npm run test:spec`, which uses Vitest's tree reporter to render the suite as hierarchical behavioral documentation. ## Changes  - Normalize issue-first, metadata-led, fragmented, and arrow-label titles across CLI, plugin, integration, package-contract, and E2E support tests. - Add `scripts/checks/test-title-style.ts` with unit coverage, include it in repository checks, and expose it as `npm run test:titles:check`. - Add `npm run test:spec` and document the behavioral-title convention for contributors and agents. - Leave production behavior unchanged; this PR changes test descriptions and contributor tooling only. ## Type of Change - [ ] Code change (feature, bug fix, or refactor) - [x] Code change with doc updates - [ ] Doc only (prose changes, no code sample modifications) - [ ] Doc only (includes code sample changes) ## Quality Gates  - [x] Tests added or updated for changed behavior - [ ] Existing tests cover changed behavior — justification: - [ ] Tests not applicable — justification: - [ ] Docs updated for user-facing behavior changes - [x] Docs not applicable — justification: No product-facing behavior changed; contributor guidance is updated in `CONTRIBUTING.md` and `AGENTS.md`. - [ ] Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging) - [ ] Sensitive-path review completed or maintainer-approved waiver recorded — reviewer/approval link/justification: - [ ] Non-success, skipped, or missing CI check accepted by maintainer — check name, approval link, and follow-up issue: ## Verification  - [x] PR description includes the DCO sign-off declaration and every commit appears as `Verified` in GitHub - [x] Git hooks passed during commit and push, or `npx prek run --from-ref main --to-ref HEAD` passes - [x] Targeted tests pass for changed behavior - [x] Full `npm test` passes (broad runtime changes only) - [x] Quality Gates section completed with required justifications or waivers - [x] No secrets, API keys, or credentials committed - [ ] `npm run docs` builds without warnings (doc changes only) - [ ] Doc pages follow the [style guide](https://github.com/NVIDIA/NemoClaw/blob/main/docs/CONTRIBUTING.md) (doc changes only) - [ ] New doc pages include SPDX header and frontmatter (new pages only) ---  Signed-off-by: Carlos Villela <cvillela@nvidia.com> --------- Signed-off-by: Carlos Villela <cvillela@nvidia.com>

cv added 5 commits June 27, 2026 18:38

test: normalize issue references in test titles

0920943

Signed-off-by: Carlos Villela <cvillela@nvidia.com>

test: standardize issue suffixes in test titles

ec82174

Signed-off-by: Carlos Villela <cvillela@nvidia.com>

test: rewrite metadata-led test titles as predicates

f0561e1

Signed-off-by: Carlos Villela <cvillela@nvidia.com>

test: rewrite fragmented test titles as behavior

e65b12b

Signed-off-by: Carlos Villela <cvillela@nvidia.com>

test: enforce behavior-oriented test titles

db14e3f

Signed-off-by: Carlos Villela <cvillela@nvidia.com>

cv self-assigned this Jun 28, 2026

coderabbitai Bot reviewed Jun 28, 2026

View reviewed changes

Comment thread test/repro-2749-extra.test.ts Outdated

Comment thread test/test-title-style.test.ts Outdated

cv added 2 commits June 27, 2026 19:17

test: tighten behavior-oriented suite titles

924f4b9

merge: synchronize with main

d11fe77

cv merged commit 46a5879 into main Jun 28, 2026
122 checks passed

cv deleted the codex/test-title-agiledox branch June 28, 2026 02:34

coderabbitai Bot mentioned this pull request Jul 16, 2026

refactor(checks): migrate repository check suite to .mts #7047

Merged

21 tasks

wscurran added area: e2e End-to-end tests, nightly failures, or validation infrastructure chore Build, CI, dependency, or tooling maintenance labels Aug 1, 2026

This was referenced Aug 3, 2026

fix(hermes): route WhatsApp through OpenShell proxy #8089

Merged

fix(inference): recover dual-Station runtime ownership #8158

Merged

fix(sandbox): report gateway authority migration instead of crashing #8118

Merged

Uh oh!

Conversation

cv commented Jun 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Type of Change

Quality Gates

Verification

Uh oh!

coderabbitai Bot commented Jun 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

❌ Failed checks (1 warning)

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-code-quality Bot commented Jun 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Overview

TypeScript / code-coverage/plugin

TypeScript / code-coverage/cli

Uh oh!

github-actions Bot commented Jun 28, 2026

Uh oh!

github-actions Bot commented Jun 28, 2026

E2E Advisor Recommendation

E2E Recommendation Advisor

Required E2E

Optional E2E

New E2E recommendations

Uh oh!

github-actions Bot commented Jun 28, 2026

Vitest E2E Scenario Recommendation

Vitest E2E Scenario Advisor

Required Vitest E2E scenarios

Optional Vitest E2E scenarios

Relevant changed files

Uh oh!

github-actions Bot commented Jun 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Review Advisor (Nemotron Ultra) — No blocking findings

Action checklist

Findings index

⚠️ Resolve or justify before merge

💡 In-scope improvements

PRA-1 Improvement — Pre-existing test title uses bare issue number without parentheses suffix

PRA-2 Improvement — DEFAULT_SCAN_ROOTS and roots parameter are single-use config

PRA-3 Improvement — New npm scripts need runtime validation

PRA-1 Improvement — Pre-existing test title uses bare issue number without parentheses suffix

PRA-2 Improvement — DEFAULT_SCAN_ROOTS and roots parameter are single-use config

PRA-3 Improvement — New npm scripts need runtime validation

Uh oh!

github-actions Bot commented Jun 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Review Advisor — No blocking findings

Action checklist

Uh oh!

github-actions Bot commented Jun 28, 2026

Vitest E2E Scenario Results — ✅ All requested jobs passed

Uh oh!

cv commented Jun 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

cv commented Jun 28, 2026 •

edited

Loading

coderabbitai Bot commented Jun 28, 2026 •

edited

Loading

github-code-quality Bot commented Jun 28, 2026 •

edited

Loading

github-actions Bot commented Jun 28, 2026 •

edited

Loading

`PRA-1` Improvement — Pre-existing test title uses bare issue number without parentheses suffix

`PRA-2` Improvement — DEFAULT_SCAN_ROOTS and roots parameter are single-use config

`PRA-3` Improvement — New npm scripts need runtime validation

`PRA-1` Improvement — Pre-existing test title uses bare issue number without parentheses suffix

`PRA-2` Improvement — DEFAULT_SCAN_ROOTS and roots parameter are single-use config

`PRA-3` Improvement — New npm scripts need runtime validation

github-actions Bot commented Jun 28, 2026 •

edited

Loading