-
Notifications
You must be signed in to change notification settings - Fork 3.1k
fix(policy): allowlist wttr.in in weather egress preset #5842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
ddcdedf
fix(policy): allowlist wttr.in in weather egress preset
hunglp6d 26c06d5
fix(policy): clarify weather preset wttr rationale and refresh provid…
hunglp6d a468624
Merge branch 'main' into fix/weather-skill-in-egress
hunglp6d 4827429
Merge branch 'main' into fix/weather-skill-in-egress
hunglp6d e966ee1
Merge branch 'main' into fix/weather-skill-in-egress
hunglp6d d6f6148
Merge branch 'main' into fix/weather-skill-in-egress
hunglp6d 55edc0d
fix(policy): clarify wttr.is is forward-compat in weather preset (#1417)
hunglp6d 37f2f98
Merge branch 'main' into fix/weather-skill-in-egress
hunglp6d cb81745
Merge branch 'main' into fix/weather-skill-in-egress
hunglp6d 5f0962e
fix(policy): validate bundled weather skill egress
cv 25480d4
Merge remote-tracking branch 'origin/main' into fix/weather-skill-in-…
cv f8ce4fc
test(policy): stabilize weather egress proof
cv 9775a6b
test(e2e): make weather proof single-fetch
cv 71e22cd
test(e2e): fail closed on weather proof errors
cv 99fa310
test(policy): bind weather review to OpenClaw pin
cv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| // SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| import fs from "node:fs"; | ||
|
|
||
| import { describe, expect, it } from "vitest"; | ||
| import YAML from "yaml"; | ||
|
|
||
| import { loadAgent } from "../src/lib/agent/defs.ts"; | ||
|
|
||
| type WeatherEndpoint = { | ||
| host: string; | ||
| port: number; | ||
| protocol: string; | ||
| enforcement: string; | ||
| rules: Array<{ allow: { method: string; path: string } }>; | ||
| }; | ||
|
|
||
| type WeatherPreset = { | ||
| network_policies?: { | ||
| weather?: { | ||
| endpoints?: WeatherEndpoint[]; | ||
| }; | ||
| }; | ||
| }; | ||
|
|
||
| const REVIEWED_WTTR_WEATHER_SKILL_OPENCLAW_VERSION = "2026.5.27"; | ||
|
|
||
| describe("weather policy preset", () => { | ||
| it("allows only current weather hosts and keeps wttr.in read-only (#1417)", () => { | ||
| const presetPath = new URL( | ||
| "../nemoclaw-blueprint/policies/presets/weather.yaml", | ||
| import.meta.url, | ||
| ); | ||
| const parsed = YAML.parse(fs.readFileSync(presetPath, "utf8")) as WeatherPreset; | ||
| const endpoints = parsed.network_policies?.weather?.endpoints ?? []; | ||
|
|
||
| // wttr.is remains intentionally excluded until a pinned runtime actually | ||
| // requires it; weather.yaml records the OpenClaw version review boundary. | ||
| expect(endpoints.map(({ host }) => host).sort()).toEqual([ | ||
| "api.open-meteo.com", | ||
| "api.weather.gov", | ||
| "geocoding-api.open-meteo.com", | ||
| "wttr.in", | ||
| ]); | ||
| expect(endpoints.find(({ host }) => host === "wttr.in")).toEqual({ | ||
| host: "wttr.in", | ||
| port: 443, | ||
| protocol: "rest", | ||
| enforcement: "enforce", | ||
| rules: [ | ||
| { allow: { method: "GET", path: "/**" } }, | ||
| { allow: { method: "HEAD", path: "/**" } }, | ||
| ], | ||
| }); | ||
| }); | ||
|
|
||
| it("forces wttr.in egress re-review when the OpenClaw pin changes (#1417)", () => { | ||
| const openClaw = loadAgent("openclaw"); | ||
|
|
||
| expect( | ||
| openClaw.expectedVersion, | ||
| "Revalidate the bundled OpenClaw weather skill egress and update the weather host/rule contract before changing the reviewed version", | ||
| ).toBe(REVIEWED_WTTR_WEATHER_SKILL_OPENCLAW_VERSION); | ||
| }); | ||
| }); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.