Skip to content

refactor(onboard): clarify compatibility bridge comments - #5709

Merged
cv merged 6 commits into
test/onboard-record-only-boundary-stale-resultsfrom
refactor/onboard-compat-bridge-comments
Jun 24, 2026
Merged

refactor(onboard): clarify compatibility bridge comments#5709
cv merged 6 commits into
test/onboard-record-only-boundary-stale-resultsfrom
refactor/onboard-compat-bridge-comments

Conversation

@cv

@cv cv commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

Summary

Refresh the onboarding FSM compatibility comments after the record-only migration. The comments now describe the remaining replay bridge as persisted resume/ahead-state tolerance instead of default legacy step-helper machine mutation.

Changes

  • Update initial, core, and final flow-slice compatibility comments with current source-of-truth wording.
  • Narrow runtime-boundary bridge comments to explicit legacy/test overrides and resume/ahead replay.
  • Document removal conditions around first-class FSM recovery states.

Type of Change

  • Code change (feature, bug fix, or refactor)
  • Code change with doc updates
  • Doc only (prose changes, no code sample modifications)
  • Doc only (includes code sample changes)

Verification

  • PR description includes the DCO sign-off declaration and every commit appears as Verified in GitHub
  • Git hooks passed during commit and push, or npx prek run --from-ref main --to-ref HEAD passes
  • Targeted tests pass for changed behavior
  • Full npm test passes (broad runtime changes only)
  • Tests added or updated for new or changed behavior
  • No secrets, API keys, or credentials committed
  • Docs updated for user-facing behavior changes
  • npm run docs builds without warnings (doc changes only)
  • Doc pages follow the style guide (doc changes only)
  • New doc pages include SPDX header and frontmatter (new pages only)

Signed-off-by: Carlos Villela cvillela@nvidia.com

@cv cv self-assigned this Jun 24, 2026
@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 69e9871e-cf8e-47d4-ae86-0bb884ce5da1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/onboard-compat-bridge-comments

Comment @coderabbitai help to get the list of available commands.

@github-code-quality

github-code-quality Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Code Coverage Overview

Languages: TypeScript

TypeScript / code-coverage/plugin

The overall coverage in the refactor/onboard-com... branch is 96%. Coverage data for the test/onboard-record-... branch is not yet available.

Show a code coverage summary of the most covered files.
File test/onboard-record-... refactor/onboard-com... f5f0d06 +/-
nemoclaw/src/se...cret-scanner.ts 100%
nemoclaw/src/commands/slash.ts 100%
nemoclaw/src/li...bprocess-env.ts 100%
nemoclaw/src/bl...eprint/state.ts 98%
nemoclaw/src/onboard/config.ts 98%
nemoclaw/src/bl...int/snapshot.ts 97%
nemoclaw/src/bl...print/runner.ts 95%
nemoclaw/src/co...ration-state.ts 94%
nemoclaw/src/bl...ate-networks.ts 94%
nemoclaw/src/index.ts 94%

TypeScript / code-coverage/cli

The overall coverage in the refactor/onboard-com... branch is 47%. Coverage data for the test/onboard-record-... branch is not yet available.

Show a code coverage summary of the most covered files.
File test/onboard-record-... refactor/onboard-com... f5f0d06 +/-
src/lib/state/o...oard-session.ts 91%
src/lib/inference/local.ts 76%
src/lib/sandbox/config.ts 72%
src/lib/actions...dbox/rebuild.ts 70%
src/lib/onboard/preflight.ts 64%
src/lib/actions...licy-channel.ts 58%
src/lib/state/sandbox.ts 55%
src/lib/policy/index.ts 49%
src/lib/onboard...er-gpu-patch.ts 44%
src/lib/onboard.ts 18%

Updated June 24, 2026 20:02 UTC
Code Coverage is in Public Preview. Learn more and provide us with your feedback.

@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

E2E Advisor Recommendation

Required E2E: None
Optional E2E: None

Workflow run

Full advisor summary

E2E Recommendation Advisor

Base: origin/test/onboard-record-only-boundary-stale-results
Head: HEAD
Confidence: high

Required E2E

  • None. No E2E is required because this PR is comments-only in runtime/onboarding files. It does not change installer/onboarding behavior, live slice orchestration code, resume compatibility states, repair policy, session bootstrap, state transitions, sandbox lifecycle, credentials, policy, inference routing, or user-flow execution.

Optional E2E

  • None.

New E2E recommendations

  • None.

@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Vitest E2E Scenario Recommendation

Required Vitest E2E scenarios: None
Optional Vitest E2E scenarios: None

Workflow run

Full Vitest E2E advisor summary

Vitest E2E Scenario Advisor

Base: origin/test/onboard-record-only-boundary-stale-results
Head: HEAD
Confidence: high

Required Vitest E2E scenarios

  • None. The diff only changes comments in onboarding flow/runtime-boundary source files and does not alter live slice orchestration, resume compatibility state lists, repair/backstop behavior, or other executable Vitest scenario behavior.

Optional Vitest E2E scenarios

  • None.

Relevant changed files

  • src/lib/onboard/machine/core-flow-phases.ts
  • src/lib/onboard/machine/final-flow-phases.ts
  • src/lib/onboard/machine/initial-flow-phases.ts
  • src/lib/onboard/runtime-boundary.ts

@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

PR Review Advisor — No blocking findings

Merge posture: No blocking advisor findings
Primary next action: No advisor follow-up required beyond maintainer review.
Open items: 0 required · 0 warnings · 0 suggestions · 0 test follow-ups
Since last review: 0 prior items resolved · 0 still apply · 0 new items found

Workflow run details

This is an automated, non-binding review; it still expects maintainers and agents to respond to each required or warning item. Treat suggestions as current-PR improvements when they touch changed code; defer only with maintainer rationale or a linked follow-up. A human maintainer must make the final merge decision.

@cv cv added the v0.0.68 label Jun 24, 2026
…y-stale-results' into refactor/onboard-compat-bridge-comments
@wscurran wscurran added area: onboarding Onboarding FSM, provider setup, sandbox launch, or first-run flow refactor PR restructures code without intended behavior change labels Jun 24, 2026
cv added 4 commits June 24, 2026 09:34
…y-stale-results' into refactor/onboard-compat-bridge-comments
…y-stale-results' into refactor/onboard-compat-bridge-comments
…y-stale-results' into refactor/onboard-compat-bridge-comments
@cv
cv merged commit fe4699f into test/onboard-record-only-boundary-stale-results Jun 24, 2026
37 checks passed
@cv
cv deleted the refactor/onboard-compat-bridge-comments branch June 24, 2026 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: onboarding Onboarding FSM, provider setup, sandbox launch, or first-run flow refactor PR restructures code without intended behavior change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants