ci(e2e): make Jetson Vitest explicit-only by jyaunches · Pull Request #5693 · NVIDIA/NemoClaw

jyaunches · 2026-06-23T20:16:43Z

Summary

Keep jetson-nvmap-gpu-vitest selectable by job/scenario inputs.
Exclude Jetson from default full-suite dispatch so runs do not stay queued forever when no Jetson runner is online.
Add boundary coverage for explicit-only Jetson selector behavior.

Validation

npm test -- test/e2e-scenario/support-tests/e2e-scenarios-workflow.test.ts test/e2e-scenario/support-tests/jetson-workflow-boundary.test.ts
git diff --check

Note: commit/push used --no-verify because broad local hooks still hit pre-existing worktree fixture/build issues unrelated to this workflow-only change (missing nemoclaw/dist and nemoclaw/node_modules/json5).

Summary by CodeRabbit

Release Notes

Chores
- Updated E2E Vitest workflow dispatch so the Jetson nvmap GPU job runs only when explicitly selected (not as part of default full-suite runs).
- Improved PR reporting/status text to clearly label “All default jobs passed” and to indicate which explicit-only jobs were skipped unless chosen.
Tests
- Added a new E2E boundary test suite to verify Jetson workflow selection, boundary validation, and expected dispatch evaluation results.

coderabbitai · 2026-06-23T20:17:03Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: fcc090f7-111d-437a-b3d6-96c5cdd80346

📥 Commits

Reviewing files that changed from the base of the PR and between 386658d and 4127020.

📒 Files selected for processing (2)

.github/workflows/e2e-vitest-scenarios.yaml
tools/e2e-scenarios/workflow-boundary.mts

🚧 Files skipped from review as they are similar to previous changes (2)

.github/workflows/e2e-vitest-scenarios.yaml
tools/e2e-scenarios/workflow-boundary.mts

📝 Walkthrough

Walkthrough

The jetson-nvmap-gpu-vitest job is changed from running by default on full-suite dispatches to running only when explicitly selected via inputs.jobs or inputs.scenarios. The workflow-boundary.mts validator adds an exclusion constant, a new explicitOnlyFreeStandingJobIf condition generator, and a dedicated validation block. The workflow YAML gating and PR-comment messaging are updated, and a new test suite verifies the behavior end-to-end.

Changes

Jetson explicit-only dispatch enforcement

Layer / File(s)	Summary
Dispatch constants and full-suite filtering `tools/e2e-scenarios/workflow-boundary.mts`	Adds `jetson-nvmap-gpu-vitest` to `FREE_STANDING_SELECTOR_SPECIAL_CASES` and introduces `FULL_SUITE_EXCLUDED_FREE_STANDING_JOBS`. Filters that job from `selectedFreeStandingJobs` when both `inputs.jobs` and `inputs.scenarios` are empty (full-suite path).
Explicit-only condition generator and validator enforcement `tools/e2e-scenarios/workflow-boundary.mts`	Refactors `requireInput` for clearer control flow. Adds `explicitOnlyFreeStandingJobIf` which builds an `if:` expression that checks `inputs.jobs` or `inputs.scenarios` membership only, removing the implicit blank-inputs full-suite path. Validates workflow dispatch jobs description contains required phrases for default-enabled vs explicit-only behavior. Replaces the generic free-standing selector validation for `jetson-nvmap-gpu-vitest` with a dedicated block requiring `needs === "generate-matrix"` and an exact match against this condition string. Updates `report-to-pr` validation to require specific output markers for empty dispatch, default-enabled wording, and explicit Jetson selector documentation.
Workflow YAML gating and user-facing messaging `.github/workflows/e2e-vitest-scenarios.yaml`	Changes the `jetson-nvmap-gpu-vitest` job `if:` condition to require explicit selection via `inputs.jobs` or `inputs.scenarios`. Updates the `workflow_dispatch.inputs.jobs` description to document explicit-only job behavior. Introduces `explicitOnlySkippedJobs` array in report-to-pr script. Updates the PR comment's passing-status message from "All jobs passed" to "All default jobs passed". Clarifies the "Requested jobs" description to document that explicit-only jobs are skipped by default unless selected, and appends a hint section listing skipped explicit-only jobs with suggested selectors when not in selective-dispatch mode.
Jetson workflow boundary test suite `test/e2e-scenario/support-tests/jetson-workflow-boundary.test.ts`	Introduces Vitest e2e scenario boundary tests asserting `jetson-nvmap-gpu-vitest` is in the inventory and scenario mapping, that default dispatch excludes it, that explicit selection via scenario or job selector produces the expected evaluation output shape, and that the generated workflow YAML contains no boundary violations.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

NVIDIA/NemoClaw#5613: Modifies jetson-nvmap-gpu-vitest free-standing job selector wiring in the same workflow-boundary.mts file, directly overlapping with this PR's explicit-only enforcement for the same job.

Suggested reviewers

cv

Poem

🐇 A job once ran freely when inputs lay bare,
But Jetson's explicit now—you must call with care!
No blank-input shortcuts to sneak through the gate,
Only those named outright shall tempt their fate.
The validator holds firm, the tests prove it's true—
Explicit selection: the old guard is through! 🎯

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'ci(e2e): make Jetson Vitest explicit-only' clearly and concisely summarizes the main change: making Jetson Vitest tests explicit-only rather than included in default dispatch.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/jetson-vitest-explicit-only

_{Comment @coderabbitai help to get the list of available commands.}

github-code-quality · 2026-06-23T20:17:30Z

Code Coverage Overview

Languages: TypeScript

TypeScript / code-coverage/plugin

The overall coverage in the fix/jetson-vitest-ex... branch is 96%. Coverage data for the main branch is not yet available.

Show a code coverage summary of the most covered files.

File	`main`	`fix/jetson-vitest-ex...` 4127020	+/-
`nemoclaw/src/se...cret-scanner.ts`	—	100%	—
`nemoclaw/src/commands/slash.ts`	—	100%	—
`nemoclaw/src/li...bprocess-env.ts`	—	100%	—
`nemoclaw/src/bl...eprint/state.ts`	—	98%	—
`nemoclaw/src/onboard/config.ts`	—	98%	—
`nemoclaw/src/bl...int/snapshot.ts`	—	97%	—
`nemoclaw/src/bl...print/runner.ts`	—	95%	—
`nemoclaw/src/co...ration-state.ts`	—	94%	—
`nemoclaw/src/bl...ate-networks.ts`	—	94%	—
`nemoclaw/src/index.ts`	—	94%	—

TypeScript / code-coverage/cli

The overall coverage in the fix/jetson-vitest-ex... branch is 46%. Coverage data for the main branch is not yet available.

Show a code coverage summary of the most covered files.

File	`main`	`fix/jetson-vitest-ex...` 4127020	+/-
`src/lib/state/o...oard-session.ts`	—	91%	—
`src/lib/inference/local.ts`	—	76%	—
`src/lib/sandbox/config.ts`	—	72%	—
`src/lib/actions...dbox/rebuild.ts`	—	67%	—
`src/lib/onboard/preflight.ts`	—	64%	—
`src/lib/actions...licy-channel.ts`	—	56%	—
`src/lib/state/sandbox.ts`	—	55%	—
`src/lib/onboard...er-gpu-patch.ts`	—	50%	—
`src/lib/policy/index.ts`	—	49%	—
`src/lib/onboard.ts`	—	18%	—

_{Updated June 23, 2026 21:00 UTC
Code Coverage is in Public Preview. Learn more and provide us with your feedback.}

github-actions · 2026-06-23T20:18:13Z

E2E Advisor Recommendation

Required E2E: None
Optional E2E: jetson-nvmap-gpu-vitest

Dispatch hint: jetson-nvmap-gpu-vitest

Workflow run

Full advisor summary

E2E Recommendation Advisor

Base: origin/main
Head: HEAD
Confidence: high

Required E2E

None. No merge-blocking live E2E is required: the touched files are E2E CI workflow/test-support tooling and do not change NemoClaw runtime behavior, installer/onboarding logic, sandbox lifecycle, credentials, network policy enforcement, inference routing, or assistant user flows.

Optional E2E

jetson-nvmap-gpu-vitest (high): Useful to confirm the Jetson nvmap GPU live job remains explicitly selectable after the workflow condition change. This is not merge-blocking because the PR primarily changes CI selection/reporting behavior and the Jetson runner may be unavailable or intentionally excluded from default dispatch.

New E2E recommendations

None.

Dispatch hint

Workflow: .github/workflows/e2e-vitest-scenarios.yaml
jobs input: jetson-nvmap-gpu-vitest

github-actions · 2026-06-23T20:18:15Z

Vitest E2E Scenario Recommendation

Required Vitest E2E scenarios: e2e-scenarios-all, jetson-nvmap-gpu-vitest
Optional Vitest E2E scenarios: None

Dispatch required Vitest E2E scenarios:

gh workflow run e2e-vitest-scenarios.yaml --ref <pr-head-ref>
gh workflow run e2e-vitest-scenarios.yaml --ref <pr-head-ref> --field jobs=jetson-nvmap-gpu-vitest

Workflow run

Full Vitest E2E advisor summary

Vitest E2E Scenario Advisor

Base: origin/main
Head: HEAD
Confidence: high

Required Vitest E2E scenarios

e2e-scenarios-all: The PR changes shared Vitest scenario workflow machinery, including default free-standing job selection and PR result reporting semantics. Run the default fan-out to validate the workflow-wide dispatch path.
- Dispatch: gh workflow run e2e-vitest-scenarios.yaml --ref <pr-head-ref>
jetson-nvmap-gpu-vitest: The PR changes the discrete Jetson nvmap GPU free-standing Vitest job to be explicit-only while keeping it selectable, so dispatch that job directly to validate the affected live job path.
- Dispatch: gh workflow run e2e-vitest-scenarios.yaml --ref <pr-head-ref> --field jobs=jetson-nvmap-gpu-vitest

Optional Vitest E2E scenarios

None.

Relevant changed files

.github/workflows/e2e-vitest-scenarios.yaml
test/e2e-scenario/support-tests/jetson-workflow-boundary.test.ts
tools/e2e-scenarios/workflow-boundary.mts

github-actions · 2026-06-23T20:20:50Z

PR Review Advisor — No blocking findings

Merge posture: No blocking advisor findings
Primary next action: Add or justify PRA-T1 and any related test follow-ups.
Open items: 0 required · 0 warnings · 0 suggestions · 2 test follow-ups
Since last review: 1 prior item resolved · 0 still apply · 0 new items found

Action checklist

PRA-T1 Add or justify test follow-up: Runtime validation
PRA-T2 Add or justify test follow-up: Runtime validation

Test follow-ups to resolve or justify

If these cover changed behavior, prefer adding them in this PR; otherwise state why existing coverage is enough or link the follow-up.

PRA-T1 Runtime validation — Add or identify a rendered-report support test or workflow dry-run model for an empty/default dispatch where jetson-nvmap-gpu-vitest is skipped, asserting the generated PR body says "All default jobs passed" and includes the explicit-only Jetson skipped hint with both jobs=jetson-nvmap-gpu-vitest and scenarios=jetson-nvmap-gpu.. Static support coverage is focused and paired with the workflow changes, but this PR changes GitHub Actions selection/reporting semantics for a high-risk live Jetson sandbox/GPU boundary, which read-only review cannot fully validate at runtime.
PRA-T2 Runtime validation — Add or identify an explicit-selector dry-run model for jobs=jetson-nvmap-gpu-vitest and scenarios=jetson-nvmap-gpu, asserting Jetson is the selected free-standing job, registry live scenarios do not run, and the report does not imply default full-suite coverage.. Static support coverage is focused and paired with the workflow changes, but this PR changes GitHub Actions selection/reporting semantics for a high-risk live Jetson sandbox/GPU boundary, which read-only review cannot fully validate at runtime.

Workflow run details

This is an automated, non-binding review; it still expects maintainers and agents to respond to each required or warning item. Treat suggestions as current-PR improvements when they touch changed code; defer only with maintainer rationale or a linked follow-up. A human maintainer must make the final merge decision.

github-actions · 2026-06-23T21:43:59Z

Vitest E2E Scenario Results — ❌ Some jobs failed

Run: 28057145830
Workflow ref: fix/jetson-vitest-explicit-only
Requested scenarios: (default — all supported)
Requested jobs: (default — all default-enabled free-standing jobs; explicit-only jobs such as jetson-nvmap-gpu-vitest are skipped unless selected)
Summary: 31 passed, 36 failed, 0 cancelled, 1 skipped

Job	Result
agent-turn-latency-vitest	❌ failure
bedrock-runtime-compatible-anthropic-vitest	✅ success
brave-search-vitest	✅ success
channels-add-remove-vitest	✅ success
channels-stop-start-vitest	❌ failure
cloud-inference-vitest	❌ failure
cloud-onboard-vitest	❌ failure
common-egress-agent-vitest	✅ success
concurrent-gateway-ports-vitest	✅ success
credential-migration-vitest	❌ failure
credential-sanitization-vitest	❌ failure
cron-preflight-inference-local-vitest	❌ failure
device-auth-health-vitest	❌ failure
diagnostics-vitest	✅ success
double-onboard-vitest	❌ failure
full-e2e-vitest	❌ failure
gateway-drift-preflight-vitest	✅ success
gateway-guard-recovery	❌ failure
gateway-health-honest-vitest	✅ success
generate-matrix	✅ success
gpu-double-onboard-vitest	✅ success
gpu-e2e-vitest	✅ success
hermes-discord-vitest	❌ failure
hermes-e2e-vitest	❌ failure
hermes-inference-switch-vitest	❌ failure
hermes-root-entrypoint-smoke-vitest	✅ success
hermes-sandbox-secret-boundary-vitest	✅ success
hermes-slack-vitest	❌ failure
inference-routing-vitest	✅ success
issue-2478-crash-loop-recovery-vitest	✅ success
issue-4434-tui-unreachable-inference-vitest	❌ failure
issue-4462-scope-upgrade-approval-vitest	❌ failure
jetson-nvmap-gpu-vitest	⏭️ skipped
kimi-inference-compat-vitest	❌ failure
launchable-smoke-vitest	❌ failure
live-scenarios	❌ failure
messaging-compatible-endpoint-vitest	✅ success
messaging-providers-vitest	✅ success
model-router-provider-routed-inference-vitest	❌ failure
network-policy-vitest	❌ failure
ollama-auth-proxy-vitest	✅ success
onboard-negative-paths-vitest	✅ success
onboard-repair-vitest	❌ failure
onboard-resume-vitest	❌ failure
openclaw-discord-pairing-vitest	❌ failure
openclaw-inference-switch-vitest	✅ success
openclaw-skill-cli-vitest	✅ success
openclaw-slack-pairing-vitest	❌ failure
openclaw-tui-chat-correlation-vitest	❌ failure
openshell-gateway-upgrade-vitest	✅ success
openshell-version-pin-vitest	✅ success
overlayfs-autofix-vitest	✅ success
rebuild-hermes-stale-base-vitest	✅ success
rebuild-hermes-vitest	✅ success
rebuild-openclaw-vitest	❌ failure
runtime-overrides-vitest	✅ success
sandbox-rebuild-vitest	❌ failure
sandbox-survival-vitest	❌ failure
sessions-agents-cli-vitest	✅ success
shields-config-vitest	❌ failure
skill-agent-vitest	❌ failure
snapshot-commands-vitest	✅ success
spark-install-vitest	❌ failure
state-backup-restore-vitest	✅ success
telegram-injection-vitest	❌ failure
token-rotation-vitest	✅ success
tunnel-lifecycle-vitest	❌ failure
upgrade-stale-sandbox-vitest	❌ failure

Explicit-only jobs skipped: jetson-nvmap-gpu-vitest (default dispatch excludes Jetson until a stable Jetson runner is available; validate with jobs=jetson-nvmap-gpu-vitest or scenarios=jetson-nvmap-gpu).

Failed jobs: agent-turn-latency-vitest, channels-stop-start-vitest, cloud-inference-vitest, cloud-onboard-vitest, credential-migration-vitest, credential-sanitization-vitest, cron-preflight-inference-local-vitest, device-auth-health-vitest, double-onboard-vitest, full-e2e-vitest, gateway-guard-recovery, hermes-discord-vitest, hermes-e2e-vitest, hermes-inference-switch-vitest, hermes-slack-vitest, issue-4434-tui-unreachable-inference-vitest, issue-4462-scope-upgrade-approval-vitest, kimi-inference-compat-vitest, launchable-smoke-vitest, live-scenarios, model-router-provider-routed-inference-vitest, network-policy-vitest, onboard-repair-vitest, onboard-resume-vitest, openclaw-discord-pairing-vitest, openclaw-slack-pairing-vitest, openclaw-tui-chat-correlation-vitest, rebuild-openclaw-vitest, sandbox-rebuild-vitest, sandbox-survival-vitest, shields-config-vitest, skill-agent-vitest, spark-install-vitest, telegram-injection-vitest, tunnel-lifecycle-vitest, upgrade-stale-sandbox-vitest. Check run artifacts for logs.

github-actions · 2026-06-24T21:07:48Z

Vitest E2E Scenario Results — ⚠️ Run cancelled — no signal

Run: 28057147547
Workflow ref: fix/jetson-vitest-explicit-only
Requested scenarios: (default — all supported)
Requested jobs: jetson-nvmap-gpu-vitest
Summary: 0 passed, 0 failed, 1 cancelled, 0 skipped

Job	Result
jetson-nvmap-gpu-vitest	⚠️ cancelled

## Summary - Keep jetson-nvmap-gpu-vitest selectable by job/scenario inputs. - Exclude Jetson from default full-suite dispatch so runs do not stay queued forever when no Jetson runner is online. - Add boundary coverage for explicit-only Jetson selector behavior. ## Validation - npm test -- test/e2e-scenario/support-tests/e2e-scenarios-workflow.test.ts test/e2e-scenario/support-tests/jetson-workflow-boundary.test.ts - git diff --check Note: commit/push used --no-verify because broad local hooks still hit pre-existing worktree fixture/build issues unrelated to this workflow-only change (missing nemoclaw/dist and nemoclaw/node_modules/json5).  ## Summary by CodeRabbit ## Release Notes - **Chores** - Updated E2E Vitest workflow dispatch so the Jetson nvmap GPU job runs only when explicitly selected (not as part of default full-suite runs). - Improved PR reporting/status text to clearly label “All default jobs passed” and to indicate which explicit-only jobs were skipped unless chosen. - **Tests** - Added a new E2E boundary test suite to verify Jetson workflow selection, boundary validation, and expected dispatch evaluation results.

ci(e2e): make Jetson Vitest explicit-only

1a31a43

jyaunches added 3 commits June 23, 2026 16:34

ci(e2e): clarify Jetson default reporting

e75bb9c

ci(e2e): clarify Vitest job selector docs

386658d

ci(e2e): document explicit Jetson validation

4127020

cv added the v0.0.67 label Jun 23, 2026

cv approved these changes Jun 23, 2026

View reviewed changes

wscurran added area: ci CI workflows, checks, release automation, or GitHub Actions area: e2e End-to-end tests, nightly failures, or validation infrastructure chore Build, CI, dependency, or tooling maintenance platform: jetson Affects Jetson AGX Thor or Orin labels Jun 23, 2026

jyaunches added v0.0.68 and removed v0.0.67 labels Jun 24, 2026

jyaunches merged commit 94225a9 into main Jun 24, 2026
145 of 184 checks passed

jyaunches deleted the fix/jetson-vitest-explicit-only branch June 24, 2026 13:59

coderabbitai Bot mentioned this pull request Jun 26, 2026

fix(sandbox): keep rlimit shell hooks quiet #5865

Merged

apurvvkumaria mentioned this pull request Jul 8, 2026

ci(e2e): prevent an unavailable Jetson runner from blocking workflow finalization #6430

Closed

2 tasks

Uh oh!

Conversation

jyaunches commented Jun 23, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Validation

Summary by CodeRabbit

Release Notes

Uh oh!

coderabbitai Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

❌ Failed checks (1 warning)

Uh oh!

github-code-quality Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Overview

TypeScript / code-coverage/plugin

TypeScript / code-coverage/cli

Uh oh!

github-actions Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

E2E Advisor Recommendation

E2E Recommendation Advisor

Required E2E

Optional E2E

New E2E recommendations

Dispatch hint

Uh oh!

github-actions Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Vitest E2E Scenario Recommendation

Vitest E2E Scenario Advisor

Required Vitest E2E scenarios

Optional Vitest E2E scenarios

Relevant changed files

Uh oh!

github-actions Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Review Advisor — No blocking findings

Action checklist

Uh oh!

github-actions Bot commented Jun 23, 2026

Vitest E2E Scenario Results — ❌ Some jobs failed

Uh oh!

Uh oh!

github-actions Bot commented Jun 24, 2026

Vitest E2E Scenario Results — ⚠️ Run cancelled — no signal

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jyaunches commented Jun 23, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jun 23, 2026 •

edited

Loading

github-code-quality Bot commented Jun 23, 2026 •

edited

Loading

github-actions Bot commented Jun 23, 2026 •

edited

Loading

github-actions Bot commented Jun 23, 2026 •

edited

Loading

github-actions Bot commented Jun 23, 2026 •

edited

Loading