fix(e2e): freshen live install retries - #5606
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall coverage in the Show a code coverage summary of the most covered files.
TypeScript / code-coverage/cliThe overall coverage in the Show a code coverage summary of the most covered files.
Updated |
E2E Advisor RecommendationRequired E2E: Dispatch hint: Full advisor summaryE2E Recommendation AdvisorBase: Required E2E
Optional E2E
New E2E recommendations
Dispatch hint
|
Vitest E2E Scenario RecommendationRequired Vitest E2E scenarios: Dispatch required Vitest E2E scenarios:
Full Vitest E2E advisor summaryVitest E2E Scenario AdvisorBase: Required Vitest E2E scenarios
Optional Vitest E2E scenarios
Relevant changed files
|
PR Review Advisor — No blocking findingsMerge posture: No blocking advisor findings This is an automated, non-binding review; it still expects maintainers and agents to respond to each required or warning item. Treat suggestions as current-PR improvements when they touch changed code; defer only with maintainer rationale or a linked follow-up. A human maintainer must make the final merge decision. |
Vitest E2E Scenario Results — ❌ Some jobs failedRun: 27982655769
|
cba64b9
into
fix/vitest-shared-e2e-secret-wiring
Summary
--fresh.cron-preflight-inference-localandagent-turn-latency.--freshand those callers use it.Why
The E2E equivalence run showed retries failing with
Previous onboarding session failedafter an earlier onboarding attempt failed.--freshmakes install.sh bypass failed-session auto-resume classification and lets the CLI clear stale onboarding session state before retrying.Related Issues
Refs #5098
Depends on #5600
Verification
npx vitest run --project e2e-vitest-support test/e2e-scenario/support-tests/install-sh-onboard.test.tsfailed before helper returned--fresh.npx vitest run --project e2e-vitest-support test/e2e-scenario/support-tests/install-sh-onboard.test.tsnpm run build:clinpm run typechecknpm run test-size:check -- test/e2e-scenario/live/install-sh-onboard.ts test/e2e-scenario/support-tests/install-sh-onboard.test.ts test/e2e-scenario/live/agent-turn-latency-helpers.ts test/e2e-scenario/live/cron-preflight-inference-local.test.tsgit diff --checkNotes
fix/vitest-shared-e2e-secret-wiringso it can validate after ci(e2e): centralize Vitest inference env #5600 fixes the shared hosted inference secret wiring.--no-verifyafter targeted validation above passed.