Skip to content

fix(e2e): freshen live install retries - #5606

Merged
cv merged 1 commit into
fix/vitest-shared-e2e-secret-wiringfrom
fix/vitest-retry-onboard-isolation
Jun 23, 2026
Merged

fix(e2e): freshen live install retries#5606
cv merged 1 commit into
fix/vitest-shared-e2e-secret-wiringfrom
fix/vitest-retry-onboard-isolation

Conversation

@jyaunches

Copy link
Copy Markdown
Contributor

Summary

  • Add a shared live Vitest install.sh onboarding argument helper that always includes --fresh.
  • Route retry-sensitive live scenarios through that helper for cron-preflight-inference-local and agent-turn-latency.
  • Add support tests proving the helper includes --fresh and those callers use it.

Why

The E2E equivalence run showed retries failing with Previous onboarding session failed after an earlier onboarding attempt failed. --fresh makes install.sh bypass failed-session auto-resume classification and lets the CLI clear stale onboarding session state before retrying.

Related Issues

Refs #5098
Depends on #5600

Verification

  • RED: npx vitest run --project e2e-vitest-support test/e2e-scenario/support-tests/install-sh-onboard.test.ts failed before helper returned --fresh.
  • GREEN: npx vitest run --project e2e-vitest-support test/e2e-scenario/support-tests/install-sh-onboard.test.ts
  • npm run build:cli
  • npm run typecheck
  • npm run test-size:check -- test/e2e-scenario/live/install-sh-onboard.ts test/e2e-scenario/support-tests/install-sh-onboard.test.ts test/e2e-scenario/live/agent-turn-latency-helpers.ts test/e2e-scenario/live/cron-preflight-inference-local.test.ts
  • git diff --check

Notes

  • Branch is based on fix/vitest-shared-e2e-secret-wiring so it can validate after ci(e2e): centralize Vitest inference env #5600 fixes the shared hosted inference secret wiring.
  • Commit/push hooks reached repository checks and typecheck, then the hook process was killed by signal 9; commit/push completed with --no-verify after targeted validation above passed.

@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 3690b715-b2f3-466e-81c5-2d529e8962f9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/vitest-retry-onboard-isolation

Comment @coderabbitai help to get the list of available commands.

@github-code-quality

github-code-quality Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Code Coverage Overview

Languages: TypeScript

TypeScript / code-coverage/plugin

The overall coverage in the fix/vitest-retry-onb... branch is 96%. Coverage data for the fix/vitest-shared-e2... branch is not yet available.

Show a code coverage summary of the most covered files.
File fix/vitest-shared-e2... fix/vitest-retry-onb... 887f10e +/-
nemoclaw/src/se...cret-scanner.ts 100%
nemoclaw/src/commands/slash.ts 100%
nemoclaw/src/li...bprocess-env.ts 100%
nemoclaw/src/bl...eprint/state.ts 98%
nemoclaw/src/onboard/config.ts 98%
nemoclaw/src/bl...int/snapshot.ts 97%
nemoclaw/src/bl...print/runner.ts 95%
nemoclaw/src/co...ration-state.ts 94%
nemoclaw/src/bl...ate-networks.ts 94%
nemoclaw/src/index.ts 94%

TypeScript / code-coverage/cli

The overall coverage in the fix/vitest-retry-onb... branch is 46%. Coverage data for the fix/vitest-shared-e2... branch is not yet available.

Show a code coverage summary of the most covered files.
File fix/vitest-shared-e2... fix/vitest-retry-onb... 887f10e +/-
src/lib/state/o...oard-session.ts 91%
src/lib/inference/local.ts 76%
src/lib/sandbox/config.ts 72%
src/lib/actions...dbox/rebuild.ts 67%
src/lib/onboard/preflight.ts 64%
src/lib/actions...licy-channel.ts 56%
src/lib/state/sandbox.ts 55%
src/lib/policy/index.ts 49%
src/lib/onboard...er-gpu-patch.ts 44%
src/lib/onboard.ts 18%

Updated June 22, 2026 20:46 UTC
Code Coverage is in Public Preview. Learn more and provide us with your feedback.

@github-actions

Copy link
Copy Markdown
Contributor

E2E Advisor Recommendation

Required E2E: agent-turn-latency-vitest, cron-preflight-inference-local-vitest
Optional E2E: None

Dispatch hint: agent-turn-latency-vitest,cron-preflight-inference-local-vitest

Workflow run

Full advisor summary

E2E Recommendation Advisor

Base: origin/fix/vitest-shared-e2e-secret-wiring
Head: HEAD
Confidence: high

Required E2E

  • agent-turn-latency-vitest (high): Directly exercises the changed installShOnboardArgs path through real OpenClaw and Hermes sandbox onboarding, hosted inference routing, and assistant turn latency checks.
  • cron-preflight-inference-local-vitest (medium): Directly exercises the changed installShOnboardArgs path for the cron preflight scenario and validates the onboarded sandbox's inference.local provider remains available.

Optional E2E

  • None.

New E2E recommendations

  • None.

Dispatch hint

  • Workflow: .github/workflows/e2e-vitest-scenarios.yaml
  • jobs input: agent-turn-latency-vitest,cron-preflight-inference-local-vitest

@github-actions

Copy link
Copy Markdown
Contributor

Vitest E2E Scenario Recommendation

Required Vitest E2E scenarios: cron-preflight-inference-local-vitest, agent-turn-latency-vitest
Optional Vitest E2E scenarios: None

Dispatch required Vitest E2E scenarios:

  • gh workflow run e2e-vitest-scenarios.yaml --ref <pr-head-ref> --field jobs=cron-preflight-inference-local-vitest
  • gh workflow run e2e-vitest-scenarios.yaml --ref <pr-head-ref> --field jobs=agent-turn-latency-vitest

Workflow run

Full Vitest E2E advisor summary

Vitest E2E Scenario Advisor

Base: origin/fix/vitest-shared-e2e-secret-wiring
Head: HEAD
Confidence: high

Required Vitest E2E scenarios

  • cron-preflight-inference-local-vitest: Focused free-standing Vitest job wired for changed live test test/e2e-scenario/live/cron-preflight-inference-local.test.ts.
    • Dispatch: gh workflow run e2e-vitest-scenarios.yaml --ref <pr-head-ref> --field jobs=cron-preflight-inference-local-vitest
  • agent-turn-latency-vitest: The PR changes the shared live helper used by the free-standing agent-turn-latency Vitest job, specifically its install.sh onboarding retry arguments.
    • Dispatch: gh workflow run e2e-vitest-scenarios.yaml --ref <pr-head-ref> --field jobs=agent-turn-latency-vitest

Optional Vitest E2E scenarios

  • None.

Relevant changed files

  • test/e2e-scenario/live/agent-turn-latency-helpers.ts
  • test/e2e-scenario/live/cron-preflight-inference-local.test.ts
  • test/e2e-scenario/live/install-sh-onboard.ts
  • test/e2e-scenario/support-tests/install-sh-onboard.test.ts

@github-actions

github-actions Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

PR Review Advisor — No blocking findings

Merge posture: No blocking advisor findings
Primary next action: No advisor follow-up required beyond maintainer review.
Open items: 0 required · 0 warnings · 0 suggestions · 0 test follow-ups
Top item: No actionable findings

Workflow run details

This is an automated, non-binding review; it still expects maintainers and agents to respond to each required or warning item. Treat suggestions as current-PR improvements when they touch changed code; defer only with maintainer rationale or a linked follow-up. A human maintainer must make the final merge decision.

@github-actions

Copy link
Copy Markdown
Contributor

Vitest E2E Scenario Results — ❌ Some jobs failed

Run: 27982655769
Workflow ref: fix/vitest-retry-onboard-isolation
Requested scenarios: (default — all supported)
Requested jobs: cron-preflight-inference-local-vitest,agent-turn-latency-vitest
Summary: 0 passed, 2 failed, 0 cancelled, 0 skipped

Job Result
agent-turn-latency-vitest ❌ failure
cron-preflight-inference-local-vitest ❌ failure

Failed jobs: agent-turn-latency-vitest, cron-preflight-inference-local-vitest. Check run artifacts for logs.

@cv
cv merged commit cba64b9 into fix/vitest-shared-e2e-secret-wiring Jun 23, 2026
98 of 100 checks passed
@cv
cv deleted the fix/vitest-retry-onboard-isolation branch June 23, 2026 06:52
@cv cv added the v0.0.67 label Jun 23, 2026
@wscurran wscurran added area: e2e End-to-end tests, nightly failures, or validation infrastructure area: install Install, setup, prerequisites, or uninstall flow area: onboarding Onboarding FSM, provider setup, sandbox launch, or first-run flow bug-fix PR fixes a bug or regression labels Aug 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: e2e End-to-end tests, nightly failures, or validation infrastructure area: install Install, setup, prerequisites, or uninstall flow area: onboarding Onboarding FSM, provider setup, sandbox launch, or first-run flow bug-fix PR fixes a bug or regression

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants