ci(e2e): filter Vitest result comments - #5593
Merged
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughThe Changesreport-to-pr selective dispatch & cancelled handling
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Contributor
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall coverage in the Show a code coverage summary of the most covered files.
TypeScript / code-coverage/cliThe overall coverage in the Show a code coverage summary of the most covered files.
Updated |
Contributor
E2E Advisor RecommendationRequired E2E: None Full advisor summaryE2E Recommendation AdvisorBase: Required E2E
Optional E2E
New E2E recommendations
|
Contributor
Vitest E2E Scenario RecommendationRequired Vitest E2E scenarios: Dispatch required Vitest E2E scenarios:
Full Vitest E2E advisor summaryVitest E2E Scenario AdvisorBase: Required Vitest E2E scenarios
Optional Vitest E2E scenarios
Relevant changed files
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/e2e-vitest-scenarios.yaml:
- Around line 4509-4513: The fallback logic for reportedEntries in the selective
dispatch case is incorrectly including all non-skipped entries from allEntries,
which can reintroduce the generate-matrix entry that was explicitly excluded
earlier. When selectiveDispatch is true and selectedEntries is empty, the filter
should exclude generate-matrix along with skipped entries to prevent a no-signal
run from being marked as passing. Modify the selective dispatch fallback
condition to also filter out generate-matrix entries in addition to filtering
out skipped results, matching the explicit exclusion logic that appears on line
4506.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 9d3fdcea-a520-4796-ac8e-5e96a6a71cf2
📒 Files selected for processing (3)
.github/workflows/e2e-vitest-scenarios.yamltest/e2e-scenario/support-tests/e2e-scenarios-workflow.test.tstools/e2e-scenarios/workflow-boundary.mts
Comment on lines
+4509
to
+4513
| const reportedEntries = selectedEntries.length > 0 | ||
| ? selectedEntries | ||
| : selectiveDispatch | ||
| ? allEntries.filter(([, { result }]) => result !== 'skipped') | ||
| : allEntries; |
Contributor
There was a problem hiding this comment.
reportedEntries fallback can incorrectly mark a no-signal run as passing.
On Line 4511, the selective-dispatch fallback repopulates from all non-skipped needs, which can pull generate-matrix back in as a passing entry after Line 4506 explicitly excluded it. That makes status resolve to a pass even when no selected jobs actually ran.
💡 Suggested fix
- const reportedEntries = selectedEntries.length > 0
- ? selectedEntries
- : selectiveDispatch
- ? allEntries.filter(([, { result }]) => result !== 'skipped')
- : allEntries;
+ const reportedEntries = selectedEntries.length > 0
+ ? selectedEntries
+ : selectiveDispatch
+ ? allEntries.filter(([name]) => name !== 'generate-matrix')
+ : allEntries;Also applies to: 4521-4540
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.github/workflows/e2e-vitest-scenarios.yaml around lines 4509 - 4513, The
fallback logic for reportedEntries in the selective dispatch case is incorrectly
including all non-skipped entries from allEntries, which can reintroduce the
generate-matrix entry that was explicitly excluded earlier. When
selectiveDispatch is true and selectedEntries is empty, the filter should
exclude generate-matrix along with skipped entries to prevent a no-signal run
from being marked as passing. Modify the selective dispatch fallback condition
to also filter out generate-matrix entries in addition to filtering out skipped
results, matching the explicit exclusion logic that appears on line 4506.
Contributor
PR Review Advisor — Changes requestedMerge posture: Do not merge yet Action checklist
Findings index
Review findings by urgency: 0 required fixes, 2 items to resolve/justify, 0 in-scope improvements
|
cv
approved these changes
Jun 22, 2026
wscurran
added
area: ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Summary by CodeRabbit