feat(advisor): enrich findings and retry synthesis - #5572
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThe PR enriches the PR review advisor's finding schema with three new required fields ( ChangesPR Review Advisor: enriched findings, retry synthesis, static test inventory
Sequence Diagram(s)sequenceDiagram
participant main as main()
participant writeDCA as writeDeterministicContextArtifacts
participant runAC as runAdvisorConversation
participant parseAR as parseAdvisorResult
participant rQI as reviewQualityIssues
participant buildRT as buildRetryPromptTurns
main->>writeDCA: pr.diff and deterministic context
writeDCA-->>main: context artifacts written
main->>runAC: initial advisor turns
runAC-->>main: raw output (throws on turnErrors)
main->>parseAR: normalize output
parseAR-->>main: ReviewAdvisorResult | null
main->>rQI: inspect for quality issues
rQI-->>main: issues[]
alt quality issues present
main->>buildRT: reason + previous output + metadata
buildRT-->>main: retry AdvisorPromptTurn[]
main->>runAC: retry turn
runAC-->>main: repaired output
main->>parseAR: normalize repaired result
parseAR-->>main: refined ReviewAdvisorResult
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Contributor
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall coverage in the Show a code coverage summary of the most covered files.
TypeScript / code-coverage/cliThe overall coverage in the Show a code coverage summary of the most covered files.
Updated |
Contributor
E2E Advisor RecommendationRequired E2E: None Full advisor summaryE2E Recommendation AdvisorBase: Required E2E
Optional E2E
New E2E recommendations
|
Contributor
Vitest E2E Scenario RecommendationRequired Vitest E2E scenarios: None Full Vitest E2E advisor summaryVitest E2E Scenario AdvisorBase: Required Vitest E2E scenarios
Optional Vitest E2E scenarios
Relevant changed files
|
Contributor
PR Review AdvisorAction expectation: Address required items before merge. Resolve or explicitly justify warnings. Treat suggestions as current-PR improvements when they touch changed code; defer only with maintainer rationale or a linked follow-up. Review findings by urgency: 0 required fixes, 3 items to resolve/justify, 2 in-scope improvements🚨 Required before mergeAddress these before merging unless a maintainer explicitly overrides the advisor with rationale.
|
cv
changed the title
This was referenced Jun 21, 2026
wscurran
added
area: ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds adversarial-review structure to the PR Review Advisor so findings are easier to verify and follow up. The advisor now records hidden sticky-comment metadata, emits probe-shaped finding fields, retries low-quality synthesis once, writes auditable deterministic context artifacts, and uses static test inventory to make coverage guidance less generic.
Changes
Type of Change
Verification
Verifiedin GitHubnpx prek run --from-ref main --to-ref HEADpassesnpm testpasses (broad runtime changes only)npm run docsbuilds without warnings (doc changes only)Signed-off-by: Carlos Villela cvillela@nvidia.com
Summary by CodeRabbit
Release Notes