docs(skills): add messaging channel onboarding guide - #5501
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
📝 WalkthroughWalkthroughAdds ChangesMessaging Architecture Docs and Contributor Skill
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsStopped waiting for pipeline failures after 30000ms. One of your pipelines takes longer than our 30000ms fetch window to run, so review may not consider pipeline-failure results for inline comments if any failures occurred after the fetch window. Increase the timeout if you want to wait longer or run a Comment |
E2E Advisor RecommendationRequired E2E: None Full advisor summaryE2E Recommendation AdvisorBase: Required E2E
Optional E2E
New E2E recommendations
|
Vitest E2E Scenario RecommendationRequired Vitest E2E scenarios: None Full Vitest E2E advisor summaryVitest E2E Scenario AdvisorBase: Required Vitest E2E scenarios
Optional Vitest E2E scenarios
Relevant changed files
|
PR Review AdvisorFindings: 0 needs attention, 0 worth checking, 0 nice ideas Consider writing more tests for
This is an automated advisory review. A human maintainer must make the final merge decision. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.agents/skills/nemoclaw-contributor-onboard-messaging-channel/SKILL.md (1)
8-8: 💤 Low valueHyphenate "end-to-end" in adjective position.
Line 8 uses "end to end" where it modifies "messaging channel" as a compound adjective; this should be hyphenated as "end-to-end".
✏️ Proposed fix
-Use this skill to add a messaging channel end to end without leaking channel-specific logic into core NemoClaw code. +Use this skill to add a messaging channel end-to-end without leaking channel-specific logic into core NemoClaw code.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.agents/skills/nemoclaw-contributor-onboard-messaging-channel/SKILL.md at line 8, In the SKILL.md file on line 8, the phrase "end to end" is used as a compound adjective modifying "messaging channel" and should be hyphenated. Change "end to end" to "end-to-end" in the sentence to follow standard English grammar rules for compound adjectives.Source: Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/lib/messaging/AGENTS.md`:
- Around line 1-2: Two Markdown skill files are missing SPDX license headers
that must appear at the very beginning of the file before any other content. In
`.agents/skills/nemoclaw-contributor-onboard-messaging-channel/SKILL.md` (lines
1-4), add the two SPDX header comment lines before the opening `---` of the YAML
frontmatter. Similarly, in `.agents/skills/nemoclaw-skills-guide/SKILL.md`
(lines 1-5), add the same two SPDX header comment lines at the very top before
the YAML frontmatter begins. The header to add is the two HTML comment lines for
SPDX-FileCopyrightText and SPDX-License-Identifier as shown in the anchor file
`src/lib/messaging/AGENTS.md` at lines 1-2, which already has the correct
format.
---
Nitpick comments:
In @.agents/skills/nemoclaw-contributor-onboard-messaging-channel/SKILL.md:
- Line 8: In the SKILL.md file on line 8, the phrase "end to end" is used as a
compound adjective modifying "messaging channel" and should be hyphenated.
Change "end to end" to "end-to-end" in the sentence to follow standard English
grammar rules for compound adjectives.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 79856411-218d-434a-abc0-edf5ea2f0463
📒 Files selected for processing (4)
.agents/skills/nemoclaw-contributor-onboard-messaging-channel/SKILL.md.agents/skills/nemoclaw-skills-guide/SKILL.mdAGENTS.mdsrc/lib/messaging/AGENTS.md
Signed-off-by: San Dang <sdang@nvidia.com>
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall coverage in the Show a code coverage summary of the most covered files.
TypeScript / code-coverage/cliThe overall coverage in the Show a code coverage summary of the most covered files.
Updated |
sandl99
added
the
area: messaging
2 participants
Summary
Adds a contributor skill for onboarding new messaging channels through NemoClaw's manifest-first messaging architecture. Adds a package-specific messaging AGENTS guide and links it from the repo instructions so future agents know where to start.
Related Issue
None.
Changes
nemoclaw-contributor-onboard-messaging-channelwith progressive intake, upstream source analysis, implementation workflow, quality gates, and focused verification guidance.src/lib/messaging/AGENTS.mdto document messaging architecture, package boundaries, channel extension points, and testing expectations.AGENTS.mdpackage-guide pointer.Type of Change
Verification
npx prek run --from-ref main --to-ref HEADpassesnpm testpasses (broad runtime changes only)npm run docsbuilds without warnings (doc changes only)Verification details:
npx prek run --files AGENTS.md src/lib/messaging/AGENTS.md .agents/skills/nemoclaw-contributor-onboard-messaging-channel/SKILL.md .agents/skills/nemoclaw-skills-guide/SKILL.mdpassed. Commit hooks and push hooks passed, including TypeScript (CLI) and Test (skills YAML).npm run docspassed, but Fern reported 2 warnings, so the no-warnings checkbox is intentionally left unchecked.Signed-off-by: San Dang sdang@nvidia.com
Summary by CodeRabbit