docs(inference): add model task-fit guidance - #5423
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughA new "Choosing a Model for Your Task" section is added to ChangesTask-fit guidance section and regression test
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
docs/inference/inference-options.mdx (1)
85-85: ⚡ Quick winRemove non-essential bold emphasis in routine guidance.
Line [85], Line [88], and Line [92] use bold for ordinary guidance terms rather than UI labels or warnings.
Please switch these to plain text to match the docs style rule.
LLM pattern detected.As per coding guidelines, bold in docs should be reserved for UI labels, parameter names, and genuine warnings.
Also applies to: 88-88, 92-92
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/inference/inference-options.mdx` at line 85, The documentation file contains unnecessary bold emphasis on ordinary guidance terms across three locations. Remove the bold formatting (** delimiters) from routine guidance words on lines 85, 88, and 92 that are not UI labels, parameter names, or warnings. Keep bold formatting only for actual UI element names and feature labels like "Model Router" if they function as proper nouns or UI references, but remove bold from descriptive terms that describe functionality or workflow guidance. Review each of the three affected line ranges to identify which bolded text should be converted to plain text based on whether it is a genuine UI label or a routine descriptive term.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@docs/inference/inference-options.mdx`:
- Line 85: The documentation file contains unnecessary bold emphasis on ordinary
guidance terms across three locations. Remove the bold formatting (**
delimiters) from routine guidance words on lines 85, 88, and 92 that are not UI
labels, parameter names, or warnings. Keep bold formatting only for actual UI
element names and feature labels like "Model Router" if they function as proper
nouns or UI references, but remove bold from descriptive terms that describe
functionality or workflow guidance. Review each of the three affected line
ranges to identify which bolded text should be converted to plain text based on
whether it is a genuine UI label or a routine descriptive term.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 3fa69db3-9442-440b-9fc2-6e73d354d056
📒 Files selected for processing (2)
docs/inference/inference-options.mdxtest/repro-4755-model-task-fit.test.ts
1a9961a to
c327437
Compare
Add a repo-grounded "Choosing a Model for Your Task" section to the Inference Options page that maps a use case to a recommended option, a grounded rationale, and where to configure it. Every row cites an existing page/section or NEMOCLAW_* knob; relative latency and price are intentionally not ranked because they are not repo-owned facts. Add a regression test that locks in the section, its rows, the cited NEMOCLAW_* knobs, and the internal links. Fixes NVIDIA#4755 Signed-off-by: harjoth <harjoth.khara@gmail.com>
c327437 to
ae16584
Compare
|
✨ Thanks for adding the model task-fit guidance section to the inference options page with a use-case table covering tool-heavy agentic work, cost-sensitive workloads, long-context prompts, multimodal input, and local offline use. This proposes a way to ground model selection in existing repo material like Tool-Calling Reliability, the Model Router tolerance mechanism, and the local inference guide. Related open issues: |
|
Closing this as superseded. Issue #4755 was resolved and closed (completed 2026-06-30) by #5527, which added a |
Summary
The Inference Options page compares providers and hosts but never maps a model to a task type, so a reader trying to pick the right model for their use case (JTBD-4) has no basis for the decision. This adds a repo-grounded "Choosing a Model for Your Task" section so readers can match a workload to an inference option.
Related Issue
Fixes #4755
Changes
docs/inference/inference-options.mdx, placed between the provider tables and the Nemotron routing section, with a use-case table covering tool-heavy/agentic work, cost-sensitive/mixed workloads, long-context prompts, multimodal (image input), and local/offline use.tolerancemechanism,NEMOCLAW_CONTEXT_WINDOW,NEMOCLAW_INFERENCE_INPUTS, and the local-inference guide. A short note states that relative latency and price are intentionally not ranked, since those are not repo-owned facts and vary by provider/region/revision.test/repro-4755-model-task-fit.test.ts(the doc-validation test requested in the issue): asserts the section, each use-case row, the citedNEMOCLAW_*knobs, and the internal links are present and that the section precedes the Nemotron section.vitest run test/repro-4755-model-task-fit.test.ts(14/14),npm run docs(0 errors; the only 2 warnings are pre-existing global ones — Fern redirects-auth and theme accent-contrast — not introduced by this change),biome check(clean), andnpm run typecheck:cli(0 errors).Type of Change
Verification
npx prek run --from-ref main --to-ref HEADpassesnpm testpasses (broad runtime changes only)npm run docsbuilds without warnings (doc changes only)Signed-off-by: harjoth harjoth.khara@gmail.com
Summary by CodeRabbit
Documentation
Tests