Skip to content

fix(openclaw): declare Kimi store compatibility - #5404

Merged
cv merged 1 commit into
mainfrom
fix/kimi-supports-store-compat
Jun 14, 2026
Merged

fix(openclaw): declare Kimi store compatibility#5404
cv merged 1 commit into
mainfrom
fix/kimi-supports-store-compat

Conversation

@cv

@cv cv commented Jun 14, 2026

Copy link
Copy Markdown
Collaborator

Summary

Declares supportsStore: false in the OpenClaw Kimi K2.6 model-specific setup manifest so managed NVIDIA/Kimi routes get the same compatibility shape as the previous custom mock path. This fixes the live kimi-inference-compat-e2e K2 config assertion that failed after #5401 moved the scenario to public NVIDIA Endpoints.

Related Issue

Related to #5401.

Changes

  • Add supportsStore: false to nemoclaw-blueprint/model-specific-setup/openclaw/kimi-k2.6-managed-inference.json.
  • Update test/generate-openclaw-config.test.ts so registry-only Kimi compat includes the store flag.

Type of Change

  • Code change (feature, bug fix, or refactor)
  • Code change with doc updates
  • Doc only (prose changes, no code sample modifications)
  • Doc only (includes code sample changes)

Verification

  • Git hooks passed during commit and push, or npx prek run --from-ref main --to-ref HEAD passes
  • Targeted tests pass for changed behavior
  • Full npm test passes (broad runtime changes only)
  • Tests added or updated for new or changed behavior
  • No secrets, API keys, or credentials committed
  • Docs updated for user-facing behavior changes
  • npm run docs builds without warnings (doc changes only)
  • Doc pages follow the style guide (doc changes only)
  • New doc pages include SPDX header and frontmatter (new pages only)

Targeted verification:

  • npx biome check --write nemoclaw-blueprint/model-specific-setup/openclaw/kimi-k2.6-managed-inference.json test/generate-openclaw-config.test.ts
  • npx vitest run --project cli test/generate-openclaw-config.test.ts test/validate-config-schemas.test.ts --testNamePattern "Kimi|model-specific|registry compat"

Docs review: no user-facing docs changes needed; this only completes an existing model-specific OpenClaw compatibility manifest.

Note: local broad pre-commit/pre-push hooks currently fail in unrelated runtime recovery preload tests because temp preload files are seen as group-writable (mode=664), matching the existing local hook failure observed on #5401 follow-up work. Targeted changed tests passed.


Signed-off-by: Carlos Villela cvillela@nvidia.com

Summary by CodeRabbit

  • Chores

    • Updated model-specific configuration to disable store support
  • Tests

    • Updated test case formatting

Signed-off-by: Carlos Villela <cvillela@nvidia.com>
@cv cv self-assigned this Jun 14, 2026
@coderabbitai

coderabbitai Bot commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 1963e4a3-fbc4-4223-80b2-2decdf97ffa7

📥 Commits

Reviewing files that changed from the base of the PR and between b0b1362 and 9154c40.

📒 Files selected for processing (2)
  • nemoclaw-blueprint/model-specific-setup/openclaw/kimi-k2.6-managed-inference.json
  • test/generate-openclaw-config.test.ts

📝 Walkthrough

Walkthrough

Adds supportsStore: false to the openclawCompat block in kimi-k2.6-managed-inference.json, explicitly disabling store support for that model's managed inference configuration. A whitespace-only formatting adjustment is made in the corresponding test file with no logic changes.

Changes

kimi-k2.6 Store Compat Flag

Layer / File(s) Summary
Add supportsStore: false to kimi-k2.6 compat config
nemoclaw-blueprint/model-specific-setup/openclaw/kimi-k2.6-managed-inference.json, test/generate-openclaw-config.test.ts
Sets supportsStore: false in the openclawCompat block of the kimi-k2.6 managed inference JSON config; adds a blank line for formatting in the test expected object with no assertion changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐇 A flag set to false, a store put to rest,
Kimi-k2.6 now configured its best,
One line of JSON, a small but neat feat,
The bunny hops on with a tidy white sheet!
No store for this model — simplicity wins! 🌙

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: adding the supportsStore compatibility flag to the Kimi model configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/kimi-supports-store-compat

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-code-quality

github-code-quality Bot commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

Code Coverage Overview

Languages: TypeScript

TypeScript / code-coverage/plugin

The overall coverage in the fix/kimi-supports-st... branch is 96%. Coverage data for the main branch is not yet available.

Show a code coverage summary of the most covered files.
File main fix/kimi-supports-st... 9154c40 +/-
nemoclaw/src/se...cret-scanner.ts 100%
nemoclaw/src/commands/slash.ts 100%
nemoclaw/src/li...bprocess-env.ts 100%
nemoclaw/src/bl...eprint/state.ts 98%
nemoclaw/src/onboard/config.ts 98%
nemoclaw/src/bl...int/snapshot.ts 97%
nemoclaw/src/bl...print/runner.ts 95%
nemoclaw/src/co...ration-state.ts 94%
nemoclaw/src/bl...ate-networks.ts 94%
nemoclaw/src/index.ts 94%

TypeScript / code-coverage/cli

The overall coverage in the fix/kimi-supports-st... branch is 44%. Coverage data for the main branch is not yet available.

Show a code coverage summary of the most covered files.
File main fix/kimi-supports-st... 9154c40 +/-
src/lib/state/o...oard-session.ts 90%
src/lib/inference/local.ts 77%
src/lib/sandbox/config.ts 72%
src/lib/inference/nim.ts 72%
src/lib/onboard/preflight.ts 64%
src/lib/state/sandbox.ts 55%
src/lib/onboard...er-gpu-patch.ts 50%
src/lib/actions...licy-channel.ts 49%
src/lib/policy/index.ts 48%
src/lib/onboard.ts 17%

Updated June 14, 2026 00:11 UTC
Code Coverage is in Public Preview. Learn more and provide us with your feedback.

@github-actions

Copy link
Copy Markdown
Contributor

E2E Advisor Recommendation

Required E2E: kimi-inference-compat-e2e
Optional E2E: inference-routing-vitest

Dispatch hint: kimi-inference-compat-e2e

Auto-dispatched E2E: kimi-inference-compat-e2e via nightly-e2e.yaml at 9154c405c51d089abaaaf30065318383c9d76b1enightly run

Workflow run

Full advisor summary

E2E Recommendation Advisor

Base: origin/main
Head: HEAD
Confidence: high

Required E2E

  • kimi-inference-compat-e2e (medium): Directly covers the changed Kimi K2.6 managed inference compatibility path. The existing E2E onboards a sandbox through the managed inference.local route, validates openclaw.json contains the Kimi compat/plugin wiring including supportsStore=false, and exercises a real OpenClaw agent/tool-call trajectory.

Optional E2E

  • inference-routing-vitest (low): Useful adjacent PR-safe coverage for inference route classification and cleanup behavior, but it does not specifically validate Kimi model-specific compatibility fields, so it is not merge-blocking for this change.

New E2E recommendations

  • None.

Dispatch hint

  • Workflow: .github/workflows/nightly-e2e.yaml
  • jobs input: kimi-inference-compat-e2e

@github-actions

Copy link
Copy Markdown
Contributor

Vitest E2E Scenario Recommendation

Required Vitest E2E scenarios: None
Optional Vitest E2E scenarios: None

Workflow run

Full Vitest E2E advisor summary

Vitest E2E Scenario Advisor

Base: origin/main
Head: HEAD
Confidence: high

Required Vitest E2E scenarios

  • None. No Vitest scenario dispatch is required: the PR changes a Kimi-specific OpenClaw config-generation blueprint plus a unit test outside test/e2e-scenario/, and the current live Vitest scenario workflow has no typed or free-standing scenario that specifically exercises this Kimi managed-inference manifest.

Optional Vitest E2E scenarios

  • None.

Relevant changed files

  • nemoclaw-blueprint/model-specific-setup/openclaw/kimi-k2.6-managed-inference.json

@github-actions

Copy link
Copy Markdown
Contributor

Selective E2E Results — ❌ Some jobs failed

Run: 27483108652
Target ref: 9154c405c51d089abaaaf30065318383c9d76b1e
Workflow ref: main
Requested jobs: kimi-inference-compat-e2e
Summary: 0 passed, 1 failed, 0 cancelled, 0 skipped

Job Result
kimi-inference-compat-e2e ❌ failure

Failed jobs: kimi-inference-compat-e2e. Check run artifacts for logs.

@github-actions

Copy link
Copy Markdown
Contributor

PR Review Advisor

Findings: 0 needs attention, 0 worth checking, 0 nice ideas
Top item: No actionable findings

Consider writing more tests for
  • **Mocked behavioral coverage** — Add a Kimi managed-inference config-generation case where `NEMOCLAW_INFERENCE_COMPAT_B64` decodes to `{}` and assert the manifest still supplies `supportsStore: false`, `requiresStringContent`, `maxTokensField`, and `requiresToolResultName`.. The touched manifest affects provider/config behavior in a high-risk managed-inference surface, but this PR already updates a behavioral config-generation test that exercises the real generator against controlled environment and filesystem/process helpers. Additional coverage would be confidence-improving rather than blocking.
  • **Acceptance clause:** Related to fix(e2e): stabilize nightly recovery coverage #5401. — add test evidence or identify existing coverage. The deterministic validation context did not include linked issue clauses or comments for fix(e2e): stabilize nightly recovery coverage #5401, so there was no issue acceptance text to map literally.

Workflow run details

This is an automated advisory review. A human maintainer must make the final merge decision.

@cv
cv merged commit 136f656 into main Jun 14, 2026
46 checks passed
@cv
cv deleted the fix/kimi-supports-store-compat branch June 14, 2026 00:12
@cv cv added the v0.0.65 label Jun 15, 2026
@wscurran wscurran added area: e2e End-to-end tests, nightly failures, or validation infrastructure bug-fix PR fixes a bug or regression integration: openclaw OpenClaw integration behavior labels Aug 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: e2e End-to-end tests, nightly failures, or validation infrastructure bug-fix PR fixes a bug or regression integration: openclaw OpenClaw integration behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants