Skip to content

ci: fix E2E Vitest workflow dispatch parse #5335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jyaunches merged 1 commit into from
Jun 12, 2026
Merged

ci: fix E2E Vitest workflow dispatch parse #5335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/e2e-vitest-scenarios.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1126,7 +1126,6 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 45
env:
DOCKER_CONFIG: ${{ runner.temp }}/docker-config-model-router-provider-routed-inference
E2E_ARTIFACT_DIR: ${{ github.workspace }}/e2e-artifacts/vitest/model-router-provider-routed-inference
NEMOCLAW_CLI_BIN: ${{ github.workspace }}/bin/nemoclaw.js
NEMOCLAW_RUN_E2E_SCENARIOS: "1"
Expand All @@ -1136,6 +1135,9 @@ jobs:
with:
persist-credentials: false

- name: Configure isolated Docker auth directory
run: echo "DOCKER_CONFIG=${RUNNER_TEMP}/docker-config-model-router-provider-routed-inference" >> "$GITHUB_ENV"

- name: Authenticate to Docker Hub
env:
DOCKERHUB_USERNAME: ${{ secrets.DOCKERHUB_USERNAME }}
Expand Down
20 changes: 15 additions & 5 deletions tools/e2e-scenarios/workflow-boundary.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1297,12 +1297,9 @@ function validateModelRouterProviderRoutedInferenceVitestJob(
validateFreeStandingJobSelector(errors, jobs, jobName, scenarioName);

const jobEnv = asRecord(job.env);
if (
jobEnv.DOCKER_CONFIG !==
"${{ runner.temp }}/docker-config-model-router-provider-routed-inference"
) {
if ("DOCKER_CONFIG" in jobEnv) {
errors.push(
"model-router-provider-routed-inference-vitest job must isolate Docker auth with DOCKER_CONFIG under runner.temp",
"model-router-provider-routed-inference-vitest job must not set DOCKER_CONFIG at job level",
);
}
if (
Expand Down Expand Up @@ -1364,6 +1361,19 @@ function validateModelRouterProviderRoutedInferenceVitestJob(
);
}

const configureDockerAuth = requireJobStep(
errors,
jobName,
steps,
"Configure isolated Docker auth directory",
);
requireRunContains(
errors,
configureDockerAuth,
'echo "DOCKER_CONFIG=${RUNNER_TEMP}/docker-config-model-router-provider-routed-inference" >> "$GITHUB_ENV"',
);
requireRunDoesNotContain(errors, configureDockerAuth, "${{ runner.temp }}");

const dockerLogin = requireJobStep(errors, jobName, steps, "Authenticate to Docker Hub");
const dockerLoginEnv = asRecord(dockerLogin?.env);
if (dockerLoginEnv.DOCKERHUB_USERNAME !== "${{ secrets.DOCKERHUB_USERNAME }}") {
Expand Down