Skip to content

fix(e2e): restore macOS Docker VM compat comment after onboard refactor #5258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hunglp6d wants to merge 1 commit into from
Closed

fix(e2e): restore macOS Docker VM compat comment after onboard refactor #5258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/lib/onboard/sandbox-dockerfile-patch-flow.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,8 @@ export async function prepareSandboxDockerfilePatch({
preferredInferenceApi,
webSearchConfig,
resolved ? resolved.ref : null,
// Docker-on-Colima uses normal container ownership; keep the old VM chmod
// compatibility path disabled unless a future VM-specific flow opts in.
false,
null,
hermesToolGateways,
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/test-openshell-gateway-upgrade.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,7 @@ exercise_macos_docker_rootfs_permission_regression() {
|| fail "Dockerfile is missing the macOS VM rootfs compatibility ARG"
grep -Fq "ARG NEMOCLAW_DARWIN_VM_COMPAT=\${sanitizeDockerArg(darwinVmCompat ? \"1\" : \"0\")}" src/lib/onboard/dockerfile-patch.ts \
|| fail "Dockerfile patch helper does not patch the macOS VM rootfs compatibility ARG"
grep -Fq "Docker-on-Colima uses normal container ownership" src/lib/onboard.ts \
grep -Fq "Docker-on-Colima uses normal container ownership" src/lib/onboard/sandbox-dockerfile-patch-flow.ts \
|| fail "onboard does not keep macOS Docker sandbox builds out of the VM rootfs compatibility path"
grep -q "chmod -R a+rwX /sandbox/.openclaw" Dockerfile \
|| fail "Dockerfile does not relax OpenClaw state permissions for macOS VM rootfs remapping"
Expand Down
Loading