Skip to content

fix(ci): bucket cancelled jobs in Selective E2E Results comment #5246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jyaunches merged 1 commit into from
Jun 11, 2026
Merged

fix(ci): bucket cancelled jobs in Selective E2E Results comment #5246

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions .github/workflows/nightly-e2e.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2486,13 +2486,21 @@ jobs:
const passed = ran.filter(([, v]) => v.result === 'success');
const failed = ran.filter(([, v]) => v.result === 'failure');
const skipped = reportedEntries.filter(([, v]) => v.result === 'skipped');
// Cancelled jobs (e.g. cancel-in-progress superseding an older run)
// are neither success, failure, nor skipped. Without a bucket for
// them they slipped through the status tally and the comment fell
// through to the default "✅ All requested jobs passed" — masking
// the fact that the run produced no signal at all.
const cancelled = ran.filter(([, v]) => v.result === 'cancelled');

const status =
failed.length > 0 || missingRequested.length > 0
? '❌ Some jobs failed'
: skipped.length > 0 && passed.length === 0
? '⚠️ No requested jobs ran'
: '✅ All requested jobs passed';
: cancelled.length > 0 && passed.length === 0
? '⚠️ Run cancelled — no signal'
: skipped.length > 0 && passed.length === 0
? '⚠️ No requested jobs ran'
: '✅ All requested jobs passed';

const body = [
`### Selective E2E Results — ${status}`,
Expand All @@ -2501,7 +2509,7 @@ jobs:
`**Target ref:** \`${displayRef}\``,
targetRef ? `**Workflow ref:** \`${workflowBranch}\`` : undefined,
requestedJobs ? `**Requested jobs:** \`${requestedJobs}\`` : '**Requested jobs:** all (no filter)',
`**Summary:** ${passed.length} passed, ${failed.length} failed, ${skipped.length} skipped`,
`**Summary:** ${passed.length} passed, ${failed.length} failed, ${cancelled.length} cancelled, ${skipped.length} skipped`,
'',
'| Job | Result |',
'|-----|--------|',
Expand Down