Skip to content

test(onboard): cover Windows Ollama negative probe paths #4719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cv merged 2 commits into from
Jun 4, 2026
Merged

test(onboard): cover Windows Ollama negative probe paths #4719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c9f120
test(onboard): cover Windows Ollama negative probe paths
Thabhelo Jun 3, 2026
ac1b0a6
Merge branch 'main' into test/onboard-windows-ollama-negative-paths
Thabhelo Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions src/lib/onboard/windows-host-ollama.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,4 +40,25 @@ describe("detectWindowsHostOllama", () => {
loopbackOnly: false,
});
});

it("returns uninstalled when not on WSL", () => {
vi.mocked(isWsl).mockReturnValue(false);

expect(detectWindowsHostOllama()).toEqual({
installed: false,
installedPath: "",
loopbackOnly: false,
});
expect(runCapture).not.toHaveBeenCalled();
});

it("returns uninstalled when all Windows Ollama probes miss", () => {
runCapture.mockImplementation(() => "");

expect(detectWindowsHostOllama()).toEqual({
installed: false,
installedPath: "",
loopbackOnly: false,
});
});
});
2 changes: 2 additions & 0 deletions src/lib/onboard/windows-host-ollama.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,8 @@ export function detectWindowsHostOllama(): WindowsHostOllamaState {
return { installed: false, installedPath: "", loopbackOnly: false };
}
const installedPath = probeInstalledPath();
// `installed` reflects binary presence on disk, not a live daemon. Onboard
// still gates Start/Restart on reachability and loopback binding (#3949).
const installed = installedPath.length > 0;
const loopbackOnly = installed ? probeLoopbackOnly() : false;
return { installed, installedPath, loopbackOnly };
Expand Down