docs: update sub-agent config exec examples - #4698
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThis PR updates three sub-agent setup reference documentation files to replace Kubernetes kubectl exec patterns with nemoclaw CLI commands and direct docker exec invocations for sandbox configuration management, addressing the removal of k3s infrastructure. ChangesSub-Agent Setup Documentation Modernization
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Remote validation update: re-ran the PR checks on the user-designated remote test machine rather than the local host. Validated:
|
|
✨ Thanks for submitting this detailed PR about updating sub-agent config exec examples in the documentation. This proposes improvements to the documentation and sub-agent setup guide. Related open issues: |
Signed-off-by: Glenn-Agent <glenn_agent@163.com>
dd7ca60 to
dd9d2a0
Compare
miyoungc
left a comment
There was a problem hiding this comment.
Thanks for the docs cleanup here. Please revise this PR so it only changes the source docs page under docs/.
The contributor guide points doc updates at the docs/ source tree, and docs/CONTRIBUTING.md is explicit that generated user-skill output should not be edited in contributor doc PRs: docs/ is the source of truth, generated nemoclaw-user-* skill files are overwritten by the docs-to-skills pipeline, and NemoClaw maintainers refresh those generated skills during release prep.
Please revert the generated skill/reference changes in:
.agents/skills/nemoclaw-user-configure-inference/references/set-up-sub-agent.mdskills/nemoclaw-user-configure-inference/references/set-up-sub-agent.md
Keeping the docs/inference/set-up-sub-agent.mdx change is the right shape; maintainers will handle any generated skill refresh separately.
|
I also checked the proposed command examples against the current codebase. The source-docs command shape looks correct: So I do not see a correctness blocker in the Validation I ran locally: npm test -- src/lib/actions/sandbox/exec.test.ts src/lib/cli/public-argv-translation.test.ts |
Signed-off-by: Glenn-Agent <glenn_agent@163.com>
|
Thanks for the review. I updated the branch to keep only the source docs page change under Validation rerun: npm run docs:check-agent-variants
git diff --check
git diff --cached --check
git verify-commit HEADThe latest commit is signed and DCO-signed. |
|
Thanks for taking this on and for helping clean up the docs. We merged #5247, which resolves the QA-reported command drift covered by #5084, #3720, #3685, and #3686, so I’m closing this PR as superseded to keep the queue tidy. If there are unrelated doc fixes from this branch that you still want to pursue, a smaller follow-up PR would be welcome. |
Summary
openshell-cluster-nemoclaw/kubectl execexamples in the sub-agent setup guidenemoclaw <sandbox> execfor read-only config inspectionsandbox:sandbox/660config stateCloses #3720
Tests
npm run docs:check-agent-variantsgit diff --checkgit verify-commit HEADSigned-off-by: Glenn-Agent glenn_agent@163.com
Summary by CodeRabbit