Skip to content

fix(e2e): accept non-root WhatsApp QR preload owner #4671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cv merged 2 commits into from
Jun 2, 2026
Merged

fix(e2e): accept non-root WhatsApp QR preload owner #4671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f56f48b
fix(e2e): accept non-root WhatsApp QR preload owner
sandl99 Jun 2, 2026
8f05400
fix(e2e): gate WhatsApp preload owner fallback
sandl99 Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions test/e2e-script-workflow.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
// SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
// SPDX-License-Identifier: Apache-2.0

import { readFileSync } from "node:fs";

import { describe, expect, it } from "vitest";

import { loadE2eWorkflowContract, reusableNightlyJobs } from "./helpers/e2e-workflow-contract";
Expand Down Expand Up @@ -109,4 +111,16 @@ describe("E2E reusable workflow contract", () => {
expect(cloudJob.with?.script).toBe("test/e2e/test-full-e2e.sh");
expect(cloudJob.with?.ref).toBe("${{ inputs.target_ref || github.ref }}");
});

it("gates WhatsApp sandbox-owned preload acceptance on non-root entrypoint evidence", () => {
const script = readFileSync(new URL("./e2e/test-messaging-providers.sh", import.meta.url), "utf8");

expect(script).toContain(
"entrypoint_start_log_stat=$(sandbox_exec \"stat -c '%U:%a' /tmp/nemoclaw-start.log",
);
expect(script).toContain(
"[ \"$whatsapp_qr_preload_stat\" = \"sandbox:444\" ] && [ \"$entrypoint_start_log_stat\" = \"sandbox:600\" ]",
);
expect(script).toContain("entrypoint start log: ${entrypoint_start_log_stat}");
});
});
12 changes: 10 additions & 2 deletions test/e2e/test-messaging-providers.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -921,14 +921,22 @@ fi
# `{ small: true }` half-block rendering so the in-sandbox pairing QR fits a
# phone-camera frame, and the openclaw() guard injects it for the single
# `channels login --channel whatsapp` invocation. Verify both the preload file
# (root-owned, read-only) and the guard wiring are present in the sandbox.
# (root-owned/read-only in root mode; read-only in non-root mode) and the guard
# wiring are present in the sandbox.
whatsapp_qr_preload_stat=$(sandbox_exec "stat -c '%U:%a' /tmp/nemoclaw-whatsapp-qr-compact.js 2>/dev/null || echo missing")
entrypoint_start_log_stat=$(sandbox_exec "stat -c '%U:%a' /tmp/nemoclaw-start.log 2>/dev/null || echo missing")
if [ "$whatsapp_qr_preload_stat" = "root:444" ]; then
pass "M-WA6b: WhatsApp compact-QR preload installed root:444 (#4522)"
elif [ "$whatsapp_qr_preload_stat" = "sandbox:444" ] && [ "$entrypoint_start_log_stat" = "sandbox:600" ]; then
# /tmp/nemoclaw-start.log is written before sandbox-init.sh is sourced:
# root mode creates root:600, while non-root mode creates sandbox:600.
# Only accept sandbox-owned sourced files when that independent init-time
# signal proves privilege separation was already disabled.
pass "M-WA6b: WhatsApp compact-QR preload installed sandbox:444 (non-root mode) (#4522)"
elif [ "$whatsapp_qr_preload_stat" = "missing" ]; then
fail "M-WA6b: WhatsApp compact-QR preload not installed in sandbox (#4522)"
else
fail "M-WA6b: WhatsApp compact-QR preload has unexpected owner/mode: ${whatsapp_qr_preload_stat} (#4522)"
fail "M-WA6b: WhatsApp compact-QR preload has unexpected owner/mode: ${whatsapp_qr_preload_stat} (entrypoint start log: ${entrypoint_start_log_stat}) (#4522)"
fi

# Assert on the actual NODE_OPTIONS injection line, not just the filename: the
Expand Down
Loading