Skip to content

test(e2e): guard scenario workflow drift #4655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cv merged 4 commits into from
Jun 7, 2026
Merged

test(e2e): guard scenario workflow drift #4655

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dbc672f
test(e2e): add scenario aliases for layered plans
cv Jun 2, 2026
c66d2a3
docs(e2e): reconcile scenario migration docs
cv Jun 2, 2026
401c631
test(e2e): guard scenario workflow drift
cv Jun 2, 2026
8f51ab5
merge(main): resolve PR 4655 conflicts
cv Jun 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/e2e-scenarios.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,12 +60,15 @@ jobs:
[wsl-repo-cloud-openclaw]=windows-latest
[gpu-repo-local-ollama-openclaw]=linux-amd64-gpu-rtxpro6000-latest-1
[brev-launchable-cloud-openclaw]=ubuntu-latest
[ubuntu-gateway-port-conflict-negative]=ubuntu-latest
[ubuntu-invalid-nvidia-key-negative]=ubuntu-latest
[ubuntu-no-docker-preflight-negative]=ubuntu-latest
[ubuntu-repo-cloud-hermes]=ubuntu-latest
[ubuntu-repo-cloud-hermes-discord]=ubuntu-latest
[ubuntu-repo-cloud-hermes-slack]=ubuntu-latest
[ubuntu-repo-cloud-openclaw]=ubuntu-latest
[ubuntu-repo-cloud-openclaw-brave]=ubuntu-latest
[ubuntu-repo-cloud-openclaw-custom-policies]=ubuntu-latest
[ubuntu-repo-cloud-openclaw-discord]=ubuntu-latest
[ubuntu-repo-cloud-openclaw-double-provider-switch]=ubuntu-latest
[ubuntu-repo-cloud-openclaw-double-same-provider]=ubuntu-latest
Expand Down
2 changes: 2 additions & 0 deletions test/e2e-scenario/framework-tests/e2e-coverage-report.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ describe("coverage report", () => {
it("should_render_single_coverage_table", () => {
const meta = loadMetadataFromDir(E2E_DIR);
const md = renderCoverageReport(meta);
expect(md).toContain("test/e2e-scenario/nemoclaw_scenarios/{scenarios,expected-states}.yaml");
expect(md).toContain("test/e2e-scenario/validation_suites/suites.yaml");
// Exactly one primary Scenario Coverage table.
const headers = md.match(/\|\s*Scenario\s*\|\s*Platform\s*\|\s*Install\s*\|\s*Runtime\s*\|\s*Onboarding\s*\|\s*Expected state\s*\|\s*Suites\s*\|/g);
expect(headers).toBeTruthy();
Expand Down
45 changes: 45 additions & 0 deletions test/e2e-scenario/framework-tests/e2e-scenarios-workflow.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,58 @@ import path from "node:path";

import { describe, expect, it } from "vitest";

import { listScenarios } from "../scenarios/registry.ts";
import { resolveRunnerForScenario } from "../scenarios/runner-routing.ts";
import { validateE2eScenariosWorkflowBoundary } from "../../../tools/e2e-scenarios/workflow-boundary.mts";

const REPO_ROOT = path.resolve(import.meta.dirname, "../../..");
const WORKFLOW_PATH = path.join(REPO_ROOT, ".github", "workflows", "e2e-scenarios.yaml");

function routesFromWorkflow(workflowPath = WORKFLOW_PATH): Map<string, string> {
const workflow = fs.readFileSync(workflowPath, "utf8");
const match = /declare -A ROUTES=\(\n(?<body>[\s\S]*?)\n\s*\)/.exec(workflow);
if (!match?.groups?.body) {
throw new Error("Could not find ROUTES table in e2e-scenarios.yaml");
}
return new Map(
Array.from(match.groups.body.matchAll(/^\s*\[([^\]]+)\]=([^\s)]+)\s*$/gm), ([, id, runner]) => [
id,
runner,
]),
);
}

describe("e2e-scenarios workflow boundary", () => {
it("keeps scenario execution manual/reusable and artifact-safe", () => {
expect(validateE2eScenariosWorkflowBoundary()).toEqual([]);
});

it("routes_every_typed_scenario_id_to_its_resolved_runner", () => {
const scenarios = listScenarios().sort((left, right) => left.id.localeCompare(right.id));
const routes = routesFromWorkflow();
const typedIds = scenarios.map((scenario) => scenario.id);
const routeIds = Array.from(routes.keys()).sort();
const missing = typedIds.filter((id) => !routeIds.includes(id));
const extra = routeIds.filter((id) => !typedIds.includes(id));
const runnerMismatches = scenarios.flatMap((scenario) => {
const workflowRunner = routes.get(scenario.id);
if (!workflowRunner) {
return [];
}
const resolvedRunner = resolveRunnerForScenario(scenario).runner;
return workflowRunner === resolvedRunner
? []
: [`${scenario.id}: workflow=${workflowRunner}, typed=${resolvedRunner}`];
});

expect(missing, `workflow ROUTES missing typed scenario IDs: ${missing.join(", ")}`).toEqual([]);
expect(extra, `workflow ROUTES has unknown scenario IDs: ${extra.join(", ")}`).toEqual([]);
expect(
runnerMismatches,
`workflow ROUTES has runner mismatches: ${runnerMismatches.join("; ")}`,
).toEqual([]);
});

it("flags unsafe trigger and contract regressions", () => {
const tmp = fs.mkdtempSync(path.join(os.tmpdir(), "e2e-scenarios-workflow-"));
const workflowPath = path.join(tmp, "workflow.yaml");
Expand Down
2 changes: 1 addition & 1 deletion test/e2e-scenario/runtime/resolver/coverage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export function renderCoverageReport(
lines.push("# E2E Setup Scenario Coverage");
lines.push("");
lines.push(
"_Generated from `test/e2e/{scenarios,expected-states,suites}.yaml`._",
"_Generated from `test/e2e-scenario/nemoclaw_scenarios/{scenarios,expected-states}.yaml` and `test/e2e-scenario/validation_suites/suites.yaml`._",
);
lines.push("");
lines.push("## Base Scenarios");
Expand Down
Loading