Skip to content

fix(e2e): unconditionally skip Telegram reachability probe for fake-token tests #4555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cv merged 3 commits into from
May 30, 2026
Merged

fix(e2e): unconditionally skip Telegram reachability probe for fake-token tests #4555

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c06c57a
fix(e2e): unconditionally skip Telegram reachability probe for fake-t…
hunglp6d May 30, 2026
dd8b33f
Merge remote-tracking branch 'origin/main' into fix/nightly-e2e-teleg…
sandl99 May 30, 2026
b88c011
test(e2e): scope Telegram probe skip to fake tokens
cv May 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions test/e2e/test-channels-stop-start.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,12 +419,10 @@ install_for_active_agent() {
export NEMOCLAW_RECREATE_SANDBOX=1
export NEMOCLAW_FRESH=1

if [ -z "${NEMOCLAW_SKIP_TELEGRAM_REACHABILITY:-}" ]; then
if ! curl -fsS --max-time 10 https://api.telegram.org/ >/dev/null 2>&1; then
export NEMOCLAW_SKIP_TELEGRAM_REACHABILITY=1
info "api.telegram.org unreachable from host; setting NEMOCLAW_SKIP_TELEGRAM_REACHABILITY=1"
fi
fi
# Always skip the Telegram reachability probe in E2E: fake tokens trigger
# HTTP 401/404 which the new probe treats as "skip Telegram", breaking the
# test even when api.telegram.org is reachable.
export NEMOCLAW_SKIP_TELEGRAM_REACHABILITY=1

info "Running install.sh --non-interactive for ${ACTIVE_AGENT} (${ACTIVE_SANDBOX})..."
bash install.sh --non-interactive >"$log" 2>&1 &
Expand Down
13 changes: 4 additions & 9 deletions test/e2e/test-messaging-providers.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -671,15 +671,10 @@ if openshell --version >/dev/null 2>&1; then
fi
pass "Pre-cleanup complete"

if [ -z "${NEMOCLAW_SKIP_TELEGRAM_REACHABILITY:-}" ]; then
if [ -z "${TELEGRAM_BOT_TOKEN_REAL:-}" ] && [[ "$TELEGRAM_TOKEN" == test-fake-* ]]; then
export NEMOCLAW_SKIP_TELEGRAM_REACHABILITY=1
info "Skipping onboarding Telegram reachability probe for fake-token E2E"
elif ! curl -fsS --max-time 10 https://api.telegram.org/ >/dev/null 2>&1; then
export NEMOCLAW_SKIP_TELEGRAM_REACHABILITY=1
info "Host cannot reach api.telegram.org; skipping onboarding Telegram reachability probe for fake-token E2E"
fi
fi
# Always skip the Telegram reachability probe in E2E: these tests use fake
# tokens that fail the HTTP 401/404 check even when api.telegram.org is
# reachable, causing onboard to silently drop the Telegram channel.
export NEMOCLAW_SKIP_TELEGRAM_REACHABILITY=1

# Pre-merge Slack policy into the base sandbox policy.
#
Expand Down
5 changes: 5 additions & 0 deletions test/e2e/test-token-rotation.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,11 @@ section "Phase 0: Install NemoClaw and first onboard with token A"
openshell sandbox delete "$SANDBOX_NAME" 2>/dev/null || true
openshell gateway destroy -g nemoclaw 2>/dev/null || true

# Always skip the Telegram reachability probe in E2E: fake tokens trigger
# HTTP 401/404 which the new probe treats as "skip Telegram", breaking the
# test even when api.telegram.org is reachable.
export NEMOCLAW_SKIP_TELEGRAM_REACHABILITY=1

export TELEGRAM_BOT_TOKEN="$TELEGRAM_BOT_TOKEN_A"
export DISCORD_BOT_TOKEN="$DISCORD_BOT_TOKEN_A"
export SLACK_BOT_TOKEN="$SLACK_BOT_TOKEN_A"
Expand Down
Loading