Skip to content

fix(policy): keep preset descriptions line-scoped (Fixes #4312) #4328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cv merged 1 commit into from
Jun 5, 2026
Merged

fix(policy): keep preset descriptions line-scoped (Fixes #4312) #4328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nemoclaw-blueprint/policies/presets/whatsapp.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# SPDX-License-Identifier: Apache-2.0
preset:
name: whatsapp
description: WhatsApp Web WebSocket and media access
description: "WhatsApp Web WebSocket and media access"
network_policies:
whatsapp:
name: whatsapp
Expand Down
2 changes: 1 addition & 1 deletion src/lib/policy/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ function listPresets(): PresetInfo[] {
.map((f: string) => {
const content = fs.readFileSync(path.join(PRESETS_DIR, f), "utf-8");
const nameMatch = content.match(/^\s*name:\s*(.+)$/m);
const descMatch = content.match(/^\s*description:\s*"?([^"]*)"?$/m);
const descMatch = content.match(/^\s*description:\s*"?([^\n"]*)"?$/m);
return {
file: f,
name: nameMatch ? nameMatch[1].trim() : f.replace(".yaml", ""),
Expand Down
6 changes: 6 additions & 0 deletions test/policies.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,12 @@ describe("policies", () => {
}
});

it("does not include the WhatsApp preset YAML body in the description", () => {
const whatsapp = policies.listPresets().find((p) => p.name === "whatsapp");
expect(whatsapp?.description).toBe("WhatsApp Web WebSocket and media access");
expect(whatsapp?.description).not.toContain("network_policies:");
});

it("returns expected preset names", () => {
const names = policies
.listPresets()
Expand Down
Loading