Skip to content

test(installer): accept npm ci in preflight stubs #4203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chengjiew wants to merge 1 commit into from
Closed

test(installer): accept npm ci in preflight stubs #4203

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 78 additions & 0 deletions test/install-preflight.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ function writeNodeStub(fakeBin: string) {
path.join(fakeBin, "node"),
`#!/usr/bin/env bash
if [ "$1" = "--version" ] || [ "$1" = "-v" ]; then echo "v22.16.0"; exit 0; fi
if [[ "\${1:-}" == */bin/lib/usage-notice.js ]]; then exit 0; fi
if [ -n "\${1:-}" ] && [ -f "$1" ]; then
exec ${JSON.stringify(process.execPath)} "$@"
fi
Expand All @@ -87,6 +88,9 @@ exit 99`,
/**
* Minimal npm stub. Handles --version, config-get-prefix, and a custom
* install handler injected as a shell snippet via NPM_INSTALL_HANDLER.
* If a test does not need custom ci behavior, succeed after the custom
* snippet has had a chance to log. Tests that need npm ci's cleanup behavior
* model it explicitly in their snippet.
*/
function writeNpmStub(fakeBin: string, installSnippet: string = "exit 0") {
writeExecutable(
Expand All @@ -97,6 +101,7 @@ if [ "$1" = "--version" ]; then echo "10.9.2"; exit 0; fi
if [ "$1" = "config" ] && [ "$2" = "get" ] && [ "$3" = "prefix" ]; then echo "$NPM_PREFIX"; exit 0; fi
if [ "$1" = "ci" ] || [ "$1" = "install" ] || [ "$1" = "link" ] || [ "$1" = "uninstall" ] || [ "$1" = "pack" ] || [ "$1" = "run" ]; then
${installSnippet}
if [ "$1" = "ci" ]; then exit 0; fi
fi
echo "unexpected npm invocation: $*" >&2; exit 98`,
);
Expand Down Expand Up @@ -252,6 +257,9 @@ if [ "$1" = "--version" ]; then
echo "v22.16.0"
exit 0
fi
if [[ "\${1:-}" == */bin/lib/usage-notice.js ]]; then
exit 0
fi
if [ -n "\${1:-}" ] && [ -f "$1" ]; then
exec ${JSON.stringify(process.execPath)} "$@"
fi
Expand Down Expand Up @@ -296,6 +304,9 @@ fi
if [ "$1" = "pack" ]; then
exit 1
fi
if [ "$1" = "ci" ] && [[ "$*" == *"--ignore-scripts"* ]]; then
exit 0
fi
if [ "$1" = "install" ] && [[ "$*" == *"--ignore-scripts"* ]]; then
exit 0
fi
Expand Down Expand Up @@ -399,6 +410,9 @@ fi
if [ "$1" = "pack" ]; then
exit 1
fi
if [ "$1" = "ci" ] && [[ "$*" == *"--ignore-scripts"* ]]; then
exit 0
fi
if [ "$1" = "install" ] && [[ "$*" == *"--ignore-scripts"* ]]; then
exit 0
fi
Expand Down Expand Up @@ -990,6 +1004,30 @@ fi`,
const onboardLog = path.join(tmp, "onboard.log");
fs.mkdirSync(fakeBin);
fs.mkdirSync(path.join(prefix, "bin"), { recursive: true });
fs.mkdirSync(path.join(tmp, "nemoclaw"), { recursive: true });
fs.mkdirSync(path.join(tmp, "bin", "lib"), { recursive: true });
fs.mkdirSync(path.join(tmp, "dist", "lib", "onboard"), { recursive: true });
fs.writeFileSync(
path.join(tmp, "package.json"),
JSON.stringify({ name: "nemoclaw", version: "0.1.0", dependencies: { openclaw: "2026.3.11" } }, null, 2),
);
fs.writeFileSync(
path.join(tmp, "nemoclaw", "package.json"),
JSON.stringify({ name: "nemoclaw-plugin", version: "0.1.0" }, null, 2),
);
fs.writeFileSync(path.join(tmp, "bin", "lib", "usage-notice.js"), "process.exit(0);\n");
fs.writeFileSync(
path.join(tmp, "dist", "lib", "onboard", "preflight.js"),
`
exports.assessHost = () => ({ runtime: "unknown", notes: [] });
exports.planHostRemediation = () => [{
title: "Start Docker",
reason: "Docker daemon is not reachable",
commands: ["Start Docker"],
blocking: true,
}];
`,
);

writeNodeStub(fakeBin);
writeExecutable(
Expand Down Expand Up @@ -1059,6 +1097,7 @@ fi`,
PATH: `${fakeBin}:${TEST_SYSTEM_PATH}`,
NEMOCLAW_NON_INTERACTIVE: "1",
NEMOCLAW_ACCEPT_THIRD_PARTY_SOFTWARE: "1",
NEMOCLAW_REPO_ROOT: tmp,
NPM_PREFIX: prefix,
NEMOCLAW_ONBOARD_LOG: onboardLog,
},
Expand Down Expand Up @@ -1255,6 +1294,30 @@ exit 1
const onboardLog = path.join(tmp, "onboard.log");
fs.mkdirSync(fakeBin);
fs.mkdirSync(path.join(prefix, "bin"), { recursive: true });
fs.mkdirSync(path.join(tmp, "nemoclaw"), { recursive: true });
fs.mkdirSync(path.join(tmp, "bin", "lib"), { recursive: true });
fs.mkdirSync(path.join(tmp, "dist", "lib", "onboard"), { recursive: true });
fs.writeFileSync(
path.join(tmp, "package.json"),
JSON.stringify({ name: "nemoclaw", version: "0.1.0", dependencies: { openclaw: "2026.3.11" } }, null, 2),
);
fs.writeFileSync(
path.join(tmp, "nemoclaw", "package.json"),
JSON.stringify({ name: "nemoclaw-plugin", version: "0.1.0" }, null, 2),
);
fs.writeFileSync(path.join(tmp, "bin", "lib", "usage-notice.js"), "process.exit(0);\n");
fs.writeFileSync(
path.join(tmp, "dist", "lib", "onboard", "preflight.js"),
`
exports.assessHost = () => ({ runtime: "podman", notes: [] });
exports.planHostRemediation = () => [{
title: "Use Docker",
reason: "Podman may work in some environments, but it is not a supported runtime",
commands: [],
blocking: false,
}];
`,
);

writeNodeStub(fakeBin);
writeExecutable(
Expand Down Expand Up @@ -1308,6 +1371,7 @@ exit 0
PATH: `${fakeBin}:${TEST_SYSTEM_PATH}`,
NEMOCLAW_NON_INTERACTIVE: "1",
NEMOCLAW_ACCEPT_THIRD_PARTY_SOFTWARE: "1",
NEMOCLAW_REPO_ROOT: tmp,
NPM_PREFIX: prefix,
NEMOCLAW_ONBOARD_LOG: onboardLog,
},
Expand Down Expand Up @@ -1537,6 +1601,9 @@ if [ "$1" = "-v" ] || [ "$1" = "--version" ]; then
echo "v22.16.0"
exit 0
fi
if [[ "\${1:-}" == */bin/lib/usage-notice.js ]]; then
exit 0
fi
if [ -n "\${1:-}" ] && [ -f "$1" ]; then
exec ${JSON.stringify(process.execPath)} "$@"
fi
Expand Down Expand Up @@ -1590,6 +1657,9 @@ fi
if [ "$1" = "pack" ]; then
exit 1
fi
if [ "$1" = "ci" ] && [[ "$*" == *"--ignore-scripts"* ]]; then
exit 0
fi
if [ "$1" = "install" ] && [[ "$*" == *"--ignore-scripts"* ]]; then
exit 0
fi
Expand Down Expand Up @@ -1680,6 +1750,9 @@ if [ "$1" = "-v" ] || [ "$1" = "--version" ]; then
echo "v22.16.0"
exit 0
fi
if [[ "\${1:-}" == */bin/lib/usage-notice.js ]]; then
exit 0
fi
if [ -n "\${1:-}" ] && [ -f "$1" ]; then
exec ${JSON.stringify(process.execPath)} "$@"
fi
Expand Down Expand Up @@ -1722,6 +1795,9 @@ fi
if [ "$1" = "pack" ]; then
exit 1
fi
if [ "$1" = "ci" ] && [[ "$*" == *"--ignore-scripts"* ]]; then
exit 0
fi
if [ "$1" = "install" ] && [[ "$*" == *"--ignore-scripts"* ]]; then
exit 0
fi
Expand Down Expand Up @@ -3344,6 +3420,7 @@ describe("curl-pipe installer release-tag resolution", () => {
path.join(fakeBin, "node"),
`#!/usr/bin/env bash
if [ "$1" = "-v" ] || [ "$1" = "--version" ]; then echo "v22.16.0"; exit 0; fi
if [[ "\${1:-}" == */bin/lib/usage-notice.js ]]; then exit 0; fi
if [ -n "\${1:-}" ] && [ -f "$1" ]; then
exec ${JSON.stringify(process.execPath)} "$@"
fi
Expand All @@ -3358,6 +3435,7 @@ set -euo pipefail
if [ "$1" = "--version" ]; then echo "10.9.2"; exit 0; fi
if [ "$1" = "config" ] && [ "$2" = "get" ] && [ "$3" = "prefix" ]; then echo "$NPM_PREFIX"; exit 0; fi
if [ "$1" = "pack" ]; then exit 1; fi
if [ "$1" = "ci" ] && [[ "$*" == *"--ignore-scripts"* ]]; then exit 0; fi
if [ "$1" = "install" ] && [[ "$*" == *"--ignore-scripts"* ]]; then exit 0; fi
if [ "$1" = "run" ]; then exit 0; fi
if [ "$1" = "uninstall" ]; then exit 0; fi
Expand Down
Loading