fix: keep Kimi compat off OpenClaw tool search - #4120
Conversation
ericksoa
added
v0.0.50
integration: openclaw
📝 WalkthroughWalkthroughThe PR introduces per-model OpenClaw tool search configuration overrides. A new ChangesOpenClaw Tool Search Configuration Override
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Comment |
PR Review AdvisorFindings: 0 needs attention, 1 worth checking, 0 nice ideas Review findings🛠️ Needs attention
🔎 Worth checking
🌱 Nice ideas
This is an automated advisory review. A human maintainer must make the final merge decision. |
E2E Advisor RecommendationRequired E2E: Dispatch hint: Auto-dispatched E2E: Full advisor summaryE2E Recommendation AdvisorBase: Required E2E
Optional E2E
New E2E recommendations
Dispatch hint
|
E2E Scenario Advisor RecommendationRequired scenario E2E: None Full scenario advisor summaryE2E Scenario AdvisorBase: Required scenario E2E
Optional scenario E2E
Relevant changed files
|
Selective E2E Results — ✅ All requested jobs passedRun: 26322973647
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@nemoclaw-blueprint/model-specific-setup/openclaw/kimi-k2.6-managed-inference.json`:
- Around line 18-20: Add a top-of-file SPDX license header to this JSON
manifest: insert a single-line comment-style SPDX header (e.g., including
copyright owner and "SPDX-License-Identifier: Apache-2.0") at the very top of
the file that contains the "openclawTools" object so the file complies with the
required SPDX header rule for JSON sources.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 6d06e495-13a8-4043-a5b3-c20f56b8f7c4
📒 Files selected for processing (5)
nemoclaw-blueprint/model-specific-setup/openclaw/kimi-k2.6-managed-inference.jsonnemoclaw-blueprint/model-specific-setup/schema.jsonscripts/generate-openclaw-config.pytest/e2e/test-kimi-inference-compat.shtest/generate-openclaw-config.test.ts
| "openclawTools": { | ||
| "toolSearch": false | ||
| }, |
There was a problem hiding this comment.
Add the required SPDX license header to this manifest.
This JSON source file is missing the required SPDX copyright/license header.
💡 Suggested update
{
+ "$comment": "SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. SPDX-License-Identifier: Apache-2.0",
"$schema": "../schema.json",
"id": "kimi-k2.6-managed-inference",As per coding guidelines, **/*.{js,ts,tsx,jsx,sh,yaml,yml,json,md,mdx}: Every source file must include an SPDX license header for copyright and Apache-2.0 license.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@nemoclaw-blueprint/model-specific-setup/openclaw/kimi-k2.6-managed-inference.json`
around lines 18 - 20, Add a top-of-file SPDX license header to this JSON
manifest: insert a single-line comment-style SPDX header (e.g., including
copyright owner and "SPDX-License-Identifier: Apache-2.0") at the very top of
the file that contains the "openclawTools" object so the file complies with the
required SPDX header rule for JSON sources.
Selective E2E Results — ✅ All requested jobs passedRun: 26322994830
|
wscurran
added
area: cli
2 participants
Summary
effects.openclawTools.toolSearchin the model-specific setup schema/generatortools.toolSearch === falseand validates the final assistant response instead of matching prompt text in logsTests
python3 -m json.tool nemoclaw-blueprint/model-specific-setup/schema.jsonpython3 -m json.tool nemoclaw-blueprint/model-specific-setup/openclaw/kimi-k2.6-managed-inference.jsonpython3 -m py_compile scripts/generate-openclaw-config.pybash -n test/e2e/test-kimi-inference-compat.shgit diff --checknpx vitest run test/generate-openclaw-config.test.ts test/validate-config-schemas.test.ts test/kimi-inference-compat-plugin.test.tsnpm run build:clinpm run typecheck:clinpm run source-shape:checknpm run checksnpm run lintSummary by CodeRabbit
New Features
Configuration Updates
Tests