ci(actions): update workflows for Node 24 - #4046
Conversation
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (13)
📝 WalkthroughWalkthroughFourteen GitHub Actions workflow files are updated to pin specific versions of Docker build actions (v4.1.0 and v7.2.0), artifact upload action (v7.0.1), artifact download action (v8.0.1), and path-filter action (v4.0.1) by replacing version tags with commit SHAs for reproducibility. ChangesGitHub Actions Version Pinning
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
E2E Advisor RecommendationRequired E2E: None Full advisor summaryE2E Recommendation AdvisorBase: Required E2E
Optional E2E
New E2E recommendations
|
PR Review AdvisorRecommendation: blocked This is an automated advisory review. A human maintainer must make the final merge decision. Limitations: Review used the supplied trusted deterministic context and diff; I did not execute workflows, package-manager commands, tests, actionlint, or network lookups.; The diff was truncated after 160000 characters, so detailed per-line inspection of the tail of wsl-e2e.yaml and any omitted unchanged context is limited.; I did not independently verify that the pinned GitHub Action SHAs correspond to the intended upstream tags/releases or that their action.yml files declare Node 24 runtimes.; No linked issues were present, so acceptance coverage is based on PR body clauses and E2E Advisor comment evidence rather than issue acceptance criteria.; Optional E2E jobs were in progress in the supplied status rollup; their final outcomes were not available. Full advisor summaryPR Review AdvisorBase: Workflow action-pin updates look narrowly scoped and mostly improve supply-chain pinning, but the PR is currently blocked by mergeStateStatus=BLOCKED/review required and lacks direct workflow-infrastructure smoke coverage for the new action pins. Gate status
🔴 Blockers
🟡 Warnings
🔵 Suggestions
Acceptance coverage
Security review
Test / E2E status
✅ What looks good
Review completeness
|
Summary
Updates GitHub Actions workflow dependencies that still ran on the deprecated Node.js 20 runtime. Pins the affected artifact, Docker, and path-filter actions to Node.js 24-compatible releases ahead of GitHub's runner runtime migration.
Changes
actions/upload-artifactusages tov7.0.1andactions/download-artifactusages tov8.0.1SHAs.docker/login-action,docker/build-push-action, anddorny/paths-filterto Node.js 24-compatible pinned releases.uses:entries, including nested composite actions, resolve to Node.js 24 or composite-only actions.Type of Change
Verification
npx prek run --all-filespassesnpm testpassesmake docsbuilds without warnings (doc changes only)Signed-off-by: Carlos Villela cvillela@nvidia.com
Summary by CodeRabbit