fix(ci): paginate nightly scorecard trend lookup - #3922
Conversation
This test demonstrates the bug where the nightly scorecard only checks the first workflow-runs API page for prior scheduled runs. Expected: find the prior scheduled run even when selective dispatches fill page one. Actual: returns no prior-day data.
Resolves the nightly scorecard reporting no prior-day data when selective dispatch volume pushes the previous scheduled run beyond the first workflow-runs API page. The fix checks additional pages until it finds a prior scheduled run or reaches a bounded page limit.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe nightly-e2e workflow's scorecard job now fetches prior-day scheduled runs using pagination (up to 10 pages, 100 items per page) to improve trend comparison lookup, replacing a fixed single-page call. A new test suite validates the core pagination filtering logic. ChangesNightly Scorecard Prior-Run Pagination
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Comment |
Summary
Validation
Summary by CodeRabbit
Tests
Chores