Repository navigation
refactor(cli): extract onboard sandbox handler #3872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 12 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
9ee6cfa
refactor(cli): add onboard FSM transition types
cv 450716b
Merge remote-tracking branch 'origin/main' into refactor/3802-1/types
cv b9e4545
refactor(cli): emit onboard session machine events
cv 651e2a0
refactor(cli): persist onboard machine snapshots
cv f756907
refactor(cli): add onboard runtime shell
cv 702454b
refactor(cli): route onboard step boundaries through runtime
cv 60acb65
refactor(cli): add observe-only onboard hooks
cv c2a58e6
refactor(cli): extract onboard preflight handler
cv f17000a
refactor(cli): extract onboard gateway handler
cv 3038da4
refactor(cli): extract provider inference handlers
cv 18ef7e7
refactor(cli): extract onboard sandbox handler
cv f4be452
merge(main): sync sandbox handler PR
cv b40dfa1
fix(cli): keep provider selection failures user-facing
cv 7fcaf6b
fix(cli): harden sandbox handler extraction
cv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Widen the credential cleanup scope.
credentialEnvcan already be staged before these blocks, but the newfinallyonly starts afterpromptValidatedSandboxName(...)/startRecordedStep(...). If either of those rejects, the staged secret is left inprocess.env. Wrap the whole post-selection inference path, not justdeps.setupInference(...), at both call sites.Suggested shape
Mirror the same change in the non-resume branch.
Also applies to: 273-286
🤖 Prompt for AI Agents