feat(skills): add nemoclaw-maintainer-close-superseded-issues skill

[cjagwani]

Summary

Closes a batch of superseded issues with evidence-bearing comments and audit trail. Reads a JSON sidecar from find-already-fixed or scope-issues and applies a 3-step sequence per issue (assignee, evidence comment, close).

Behavior

• Local-only by default — drafts only, never posts to GitHub.
• Emits a JSON sidecar (/tmp/nemoclaw-skill-output-close-superseded-issues-<run_id>.json) for chaining with sibling maintainer skills in the suite.

Conformance audit — Claude Agent Skills best practices

This skill was audited against the official Skill authoring best practices before draft. Per-item evidence:

Core quality

Item	Status	Evidence
Description specific + key terms	✓	description is 541 chars (under 1024 cap), first word Closes (third-person, per spec)
Description has WHAT + WHEN	✓	Explicit Use when… trigger phrase present in the description
SKILL.md body under 500 lines	✓	Currently 222 lines (44%)
Additional details in separate files	✓	Supporting files: MULTI-MODEL-TESTING.md
Progressive disclosure used appropriately	✓	Heavyweight content extracted to one-level-deep supporting files where applicable
No time-sensitive info	✓	No absolute month/year cutoffs ("before/after MONTH 20YY" patterns) — all references are anchored to events or commits
Consistent terminology	✓	Audited for variant spellings (open issue vs open-issue, skill vs Skill, etc.)
Examples are concrete	✓	3 real PR/issue references in SKILL.md: #3268, #3280, #3418
File references one level deep	✓	All supporting files linked directly from SKILL.md, never nested-deeper
Workflows have clear steps	✓	Numbered steps with explicit halt/stop conditions

Code and scripts

Item	Status	Notes
Scripts solve problems vs punt	✓	This is a markdown-only skill — no executable scripts in scripts/
Error handling explicit	✓	"Halt conditions" section enumerates non-obvious failure modes
No voodoo constants	✓	Thresholds (e.g. --min-confidence 0.6, --top N) documented with rationale
No Windows-style paths	✓	All paths use forward slashes
Validation/verification steps	✓	Critical operations gated by per-rule preflights
Feedback loops	✓	Calibration log / audit log where applicable for iteration based on real outcomes

Testing

Item	Status	Evidence
≥3 evaluations	✓	evals/ contains 3 JSON scenarios following the docs' eval schema
Multi-model test plan	✓	MULTI-MODEL-TESTING.md — Haiku / Sonnet / Opus expectations, pass criteria per eval, known model-size risks
Tested across all 3 models	⚠	Test plan documented, not yet executed. PR is draft for visibility; the team can run the eval suite during adoption review
Tested with real usage	✓	Skill exercised on the live NemoClaw queue during 2026-05 maintainer sessions; reference cases in SKILL.md

Frontmatter constraints (validated)

• name: nemoclaw-maintainer-close-superseded-issues — under 64 chars, lowercase + hyphens, no reserved words ("anthropic" / "claude")
• description: third-person verb-initial, under 1024 chars, no XML tags, includes explicit Use when… trigger

Notes for reviewers

Part of an 11-skill maintainer suite. Draft for visibility. The team's <10 open-PR policy means 6 are open and 5 are closed-but-branch-preserved; reopen via gh pr reopen <num> as slots free up.

🤖 Generated with Claude Code

[copy-pr-bot]

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 7cdc19a7-1440-4f52-9aae-4e3fe6a4d1ce

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch ship-skill-close-superseded-issues

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

E2E Advisor Recommendation

Required E2E: None
Optional E2E: cloud-inference-e2e

Dispatch hint: cloud-inference-e2e

Workflow run

Full advisor summary

E2E Recommendation Advisor

Base: origin/main
Head: HEAD
Confidence: high

Required E2E

• None. No required E2E: the PR only adds agent skill markdown and eval JSON assets under .agents/skills. It does not modify NemoClaw runtime code, installer/onboarding paths, sandbox lifecycle, credentials, security policy, inference routing, deployment, or network policy. Existing E2E coverage for these runtime/user flows is not needed as a merge blocker.

Optional E2E

• cloud-inference-e2e (medium; live install/onboard plus cloud inference): Optional confidence check only: test/e2e/test-cloud-inference-e2e.sh validates repo .agents/skills SKILL.md frontmatter/body via validate_repo_skills.sh, which would catch malformed skill metadata. It is not merge-blocking here because the PR changes skill/documentation/eval assets only and does not alter runtime behavior.

New E2E recommendations

• agent-skill-evals (medium): No existing E2E appears to run .agents/skills//evals/.json against the corresponding SKILL.md. A lightweight validation could load the new close-superseded-issues eval sidecars and assert required behavior strings, sidecar field references, and safety/audit-log requirements are present.
  • Suggested test: Add a hermetic skill-eval validation job for .agents/skills/**/evals/*.json and SKILL.md consistency.
• maintainer-issue-close-safety (medium): The new skill describes safety-critical GitHub issue actions such as comment-before-close, priority+QA confirmation, recent external comment skip, raced close handling, revival-only scheduling, and local audit logging. Existing NemoClaw E2E suites do not simulate this maintainer workflow with a mocked gh CLI.
  • Suggested test: Add a hermetic mocked-gh E2E or integration test for nemoclaw-maintainer-close-superseded-issues that verifies comment/close ordering, per-issue gates, race handling, revival-only behavior, and ~/.nemoclaw/close-audit.jsonl append semantics.

Dispatch hint

• Workflow: .github/workflows/nightly-e2e.yaml
• jobs input: cloud-inference-e2e

[jyaunches]

Superseded by the NemoClaw team skills GitLab repository snapshot: https://gitlab-master.nvidia.com/jyaunches/nemoclaw-team-skills. Closing this PR so skill sharing continues in the dedicated team-skills repo instead of merging these skills into NemoClaw directly.