fix(onboard): avoid literal proc wildcard in GPU sandbox policy

[zyang-dev]

Summary

Fix direct-GPU sandbox onboarding by removing NemoClaw’s create-time procfs entries that OpenShell should own at runtime. This avoids the literal /proc/self/task/*/comm policy path crash and makes GPU verification compatible with newer OpenShell command validation.

Related Issue

Fixes #3416

Changes

• Remove /proc and /proc/self/task/*/comm from direct-GPU create policies so OpenShell can apply GPU procfs enrichment.
• Convert GPU proof shell payloads to single-line commands for OpenShell 0.0.39 compatibility.
• Fix the proc comm write proof to target the shell’s own /proc/<pid>/task/<tid>/comm entry instead of a short-lived child process.
• Update onboarding tests for the proc policy behavior and GPU proof command shape.

Type of Change

• Code change (feature, bug fix, or refactor)
• Code change with doc updates
• Doc only (prose changes, no code sample modifications)
• Doc only (includes code sample changes)

Verification

• npx prek run --all-files passes
• npm test passes
• Tests added or updated for new or changed behavior
• No secrets, API keys, or credentials committed
• Docs updated for user-facing behavior changes
• make docs builds without warnings (doc changes only)
• Doc pages follow the style guide (doc changes only)
• New doc pages include SPDX header and frontmatter (new pages only)

---

Signed-off-by: zyang-dev 267119621+zyang-dev@users.noreply.github.com

Summary by CodeRabbit

• Improvements

  • GPU policy generation now properly excludes /proc filesystem entries based on actual usage patterns rather than static paths.
  • GPU proof command generation includes improved path handling and validation.

• Tests

  • Expanded test coverage for GPU policy generation with validation of /proc entry removal from policies.
  • Enhanced test assertions for GPU proof command formatting and correctness.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 1fe1f7d6-bc60-4ff0-aa6a-0b36bd060284

📥 Commits

Reviewing files that changed from the base of the PR and between d4ae22d and ae131a6.

📒 Files selected for processing (2)

• src/lib/onboard/initial-policy.ts
• test/onboard.test.ts

---

📝 Walkthrough

Walkthrough

GPU policy generation for direct GPU sandboxes now filters /proc filesystem entries owned by OpenShell using a new classification helper. GPU proof command strings were refactored from template literals to command arrays, updating paths from /proc/self/ to /proc/<pid>/task/<tid>/comm format. Tests verify complete /proc removal from policies and updated command path references.

Changes

GPU Policy /proc Filtering and Proof Commands

Layer / File(s)	Summary
/proc filtering infrastructure src/lib/onboard/initial-policy.ts	New PROC_PATH constant and isProcEntryOwnedByOpenShell helper classify filesystem entries. buildDirectGpuPolicyYaml filters both read_only and read_write policies to remove /proc-owned entries instead of fixed /proc checks.
GPU proof command construction and path updates src/lib/onboard/initial-policy.ts	PROC_COMM_WRITE_PROBE and CUDA_INIT_PROBE refactored from template literals to command arrays joined into one-liners. Comm probe path changes to /proc/$$/task/$$/comm. buildDirectSandboxGpuProofCommands label updated to /proc/<pid>/task/<tid>/comm write.
Test coverage for filtering and commands test/onboard.test.ts	New test verifies buildDirectGpuPolicyYaml strips /proc. Stricter stale /proc test expects exactly ["/usr"] and ["/tmp"]. Proof commands test verifies /proc/<pid>/task/<tid>/comm paths and no /proc/self/task references.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested labels

OpenShell, fix

Suggested reviewers

• cv

Poem

🐇 The /proc paths now dance with purpose,
OpenShell's entries banished from the surface,
Arrays replace templates, one-liners take flight,
GPU policies gleaming, filtering done right! ✨

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Linked Issues check	❓ Inconclusive	The PR addresses procfs policy issues for GPU sandbox onboarding, but the linked issue #3416 describes sandbox readiness timeout and container creation problems rather than procfs wildcard handling.	Clarify how removing /proc entries and converting to single-line commands specifically addresses the 'Create stream exited with code 1' and 180s timeout root causes in #3416.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely summarizes the main change: fixing GPU sandbox policy by removing literal /proc wildcards to allow OpenShell to properly manage procfs entries.
Out of Scope Changes check	✅ Passed	All code changes directly address the PR objective of removing /proc and /proc/self/task/*/comm entries from GPU policies and updating proof commands to single-line format with proper pid/tid references.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/spark-gpu-proc-policy

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[ericksoa]

Approving the narrow GPU procfs policy/proof fix. The current WSL failure is in unrelated Ollama auth-proxy selection tests; this PR is limited to direct-GPU policy generation and proof command shape.