Revert "ci(nightly): enable brev-e2e job with long-lived BREV_API_TOKEN (#3350)"

[ericksoa]

Summary

Reverts #3350 because the new brev-e2e reusable workflow call breaks nightly-e2e at startup on main.

GitHub rejects nightly-e2e.yaml before jobs are created because the caller only grants contents: read, while the called workflow requests checks: write and pull-requests: write.

Failing runs:

• https://github.com/NVIDIA/NemoClaw/actions/runs/25705100581
• https://github.com/NVIDIA/NemoClaw/actions/runs/25705179290

Verification

• git diff --check origin/main..HEAD
• Confirmed nightly-e2e.yaml no longer contains the new brev-e2e job wiring.

Summary by CodeRabbit

• Infrastructure Updates

  • Simplified E2E branch validation workflow with updated authentication configuration
  • Streamlined E2E test provisioning to use a unified setup script approach
  • Removed one nightly E2E test job from the test suite

• Tests

  • Updated E2E test configuration and readiness checks to reflect infrastructure changes

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: ddc8e584-9426-4e31-a4e9-bb18fda87d80

📥 Commits

Reviewing files that changed from the base of the PR and between a2e251d and 7089183.

📒 Files selected for processing (4)

• .github/workflows/e2e-branch-validation.yaml
• .github/workflows/nightly-e2e.yaml
• test/e2e/brev-e2e.test.ts
• vitest.config.ts

---

📝 Walkthrough

Walkthrough

Brev E2E testing infrastructure migrated from API-key-based authentication with published launchable images to refresh-token-based BREV_API_TOKEN with source-based startup-script provisioning. The nightly brev-e2e job was removed. Instance readiness detection simplified to sentinel-file check.

Changes

Brev E2E Token Auth & Startup-Script Provisioning

Layer / File(s)	Summary
Authentication Contract: Inputs, Secrets, & Test Enablement .github/workflows/e2e-branch-validation.yaml, vitest.config.ts	Workflow inputs added brev_token override and use_launchable mode flag; required secrets changed from BREV_API_KEY + BREV_ORG_ID to single BREV_API_TOKEN; vitest e2e-branch-validation project enabled condition updated to require only BREV_API_TOKEN.
Brev CLI Authentication Setup .github/workflows/e2e-branch-validation.yaml	Brev CLI setup validates BREV_API_TOKEN and writes refresh_token directly to ~/.brev/credentials.json, replacing prior brev login --api-key flow and removing retry logic.
Workflow Execution & Checkout Flow .github/workflows/e2e-branch-validation.yaml	Workflow header updated to describe source installation on Brev instances; workflow dispatch inputs adjusted; job-level repository gating removed; checkout ref default changed to 'main'.
Test Instance Provisioning: Setup Script & Creation test/e2e/brev-e2e.test.ts	Configuration simplified to single setup script (DEFAULT_SETUP_SCRIPT_PATH from LAUNCHABLE_SETUP_SCRIPT); createBrevInstance rewritten to optionally download HTTP-based setup scripts and provision via --startup-script @<path> with instance existence verification; old published-launchable helpers removed.
Test Helper Functions: Instance Enumeration & Readiness test/e2e/brev-e2e.test.ts	listBrevInstances simplified to single-pass JSON parsing; waitForSsh adjusted to use fixed default attempt count; waitForLaunchableReady replaced with sentinel-file check (/var/run/nemoclaw-launchable-ready) including setup log tail output.
Nightly Workflow: brev-e2e Job Removal .github/workflows/nightly-e2e.yaml	Entire brev-e2e job definition removed, including header comment, removal from workflow_dispatch jobs list, and elimination from notify-on-failure and report-to-pr dependency matrices.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

• NVIDIA/NemoClaw#3350: Parallel E2E workflow migration updating the same Brev authentication and provisioning interfaces with an alternative authentication strategy.

Suggested labels

CI/CD, fix, E2E

Poem

🐰 A rabbit hops through Brev's new gate,
With tokens fresh and startup scripts straight,
No launchables needed, from source we build,
The sentinel file—our readiness guild.
The nightly brev job now takes its rest,
As source-born instances prove the best! 🚀

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch revert-3350-nightly-brev

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

E2E Advisor Recommendation

Required E2E: None
Optional E2E: None

Workflow run

Full advisor summary

Pi Semantic E2E Advisor

Failed: pi exited with status 1; see /home/runner/work/NemoClaw/NemoClaw/artifacts/e2e-advisor/e2e-advisor-pi-raw-output.txt

[ericksoa]

Closing in favor of the signed replacement revert PR. The original branch cannot be force-pushed under repo rules, and the revert commit needed DCO signoff.