Skip to content

fix(hermes): replay Discord facade connection fixes - #3292

Closed
ericksoa wants to merge 1 commit into
fix/hermes-discord-proxy-bridgefrom
aerickson/pr-3238-discord-facade-replay
Closed

fix(hermes): replay Discord facade connection fixes#3292
ericksoa wants to merge 1 commit into
fix/hermes-discord-proxy-bridgefrom
aerickson/pr-3238-discord-facade-replay

Conversation

@ericksoa

@ericksoa ericksoa commented May 8, 2026

Copy link
Copy Markdown
Contributor

Replays the resolved diff from #3238 onto a maintainer-owned branch so maintainers can edit it and run the normal validation gates.

Original PR/author: #3238 by Ben Barclay / NousResearch.

Changes:

  • Runs the Hermes Discord decode proxy and facade under /opt/hermes/.venv/bin/python.
  • Preserves the target branch's hardened recovery log setup and exact port readiness checks.
  • Adds the preload, policy, and test coverage needed by the Discord facade path.

Local validation:

  • npm run build:cli
  • npx vitest run src/lib/agent/runtime.test.ts test/sandbox-init.test.ts test/sandbox-provisioning.test.ts test/policies.test.ts
  • git diff --check --cached && git diff --check

Signed-off-by: Aaron Erickson aerickson@nvidia.com

Replays the resolved diff from #3238 onto a maintainer-owned branch.

Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
@coderabbitai

coderabbitai Bot commented May 8, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: a4c4373c-7cd5-4166-84db-a7cc78ff39b3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch aerickson/pr-3238-discord-facade-replay

Comment @coderabbitai help to get the list of available commands and usage tips.

@ericksoa

ericksoa commented May 8, 2026

Copy link
Copy Markdown
Contributor Author

Closing this wrong-base replay as superseded by #3293, which replays the Discord facade stack onto main and adds the maintainer finish commit there.

@ericksoa ericksoa closed this May 8, 2026
@wscurran wscurran added bug-fix PR fixes a bug or regression and removed status: superseded labels Jun 3, 2026
@cv
cv deleted the aerickson/pr-3238-discord-facade-replay branch June 28, 2026 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug-fix PR fixes a bug or regression

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants