refactor(cli): group docker adapters - #2991
Merged
Merged
Conversation
This reverts commit 4ebeae4.
wscurran
added
NemoClaw CLI
refactor
Collaborator
Author
|
@coderabbitai review |
Contributor
✅ Actions performedReview triggered.
|
cv
added a commit
that referenced
this pull request
May 6, 2026
## Summary Move registry, config, path, gateway, session, and sandbox persistence modules into `src/lib/state/**` so persistence boundaries are visible in paths. ## Stack Navigation - Position: 59 of 60 - Previous PR: [#2988 — refactor(cli): group global actions](#2988) - Next PR: [#2991 — refactor(cli): group docker adapters](#2991) ## Changes - Moved registry/config/path/gateway/session/sandbox state modules under `src/lib/state/`. - Moved co-located state tests and updated dist/source paths in integration tests. - Updated action, command, onboarding, policy, service, and test imports to the new state paths. - Updated CodeRabbit path instructions and migrated-path guard canonical paths for moved state modules. - Kept behavior unchanged; this PR is a structural move plus import updates. ## Type of Change - [x] Code change (feature, bug fix, or refactor) - [ ] Code change with doc updates - [ ] Doc only (prose changes, no code sample modifications) - [ ] Doc only (includes code sample changes) ## Verification - [x] `npx prek run --all-files --stage pre-push` passes - [x] `npm run build:cli` - [x] `npm run typecheck:cli` - [x] `npx tsx scripts/check-layer-import-boundaries.ts` - [x] State and registry targeted tests pass - [x] No secrets, API keys, or credentials committed - [ ] Docs updated for user-facing behavior changes - [ ] `make docs` builds without warnings (doc changes only) - [ ] Doc pages follow the style guide (doc changes only) - [ ] New doc pages include SPDX header and frontmatter (new pages only) --- Signed-off-by: Carlos Villela <cvillela@nvidia.com> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Refactor** * Reorganized internal state management modules into a dedicated directory structure to improve code organization and maintainability. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Carlos Villela <cvillela@nvidia.com>
cv
marked this pull request as ready for review
May 6, 2026 18:32
cv
enabled auto-merge (squash)
May 6, 2026 18:32
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
prekshivyas
approved these changes
May 6, 2026
prekshivyas
left a comment
prekshivyas
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Last PR in the 60-PR stack — same file-organization pattern, 26 files / +26 / -26.
Docker adapter modules moved src/lib/docker/** → src/lib/adapters/docker/** (11 files). Most are 0+/0- pure renames; image.ts and run.ts have +1/-1 internal sibling-import updates. 15 consumer files have +1/-1 import-path migrations.
Docker abstraction guard test updated for the new path — necessary companion, not drift.
Verification checklist explicitly cites check-layer-import-boundaries.ts from #2986.
CI: pr.yaml mostly green (lint/dco/check-hash/legacy-path-guard/changes PASS); macos-e2e/wsl-e2e/checks + pr-self-hosted builds still in flight at review time. No failures.
wscurran
added
area: cli
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move the Docker adapter package under
src/lib/adapters/docker/**so Docker process boundaries live with the other adapter modules.Stack Navigation
Changes
src/lib/docker/**tosrc/lib/adapters/docker/**.Type of Change
Verification
npx prek run --all-files --stage pre-pushpassesnpm run build:clinpm run typecheck:clinpx tsx scripts/check-layer-import-boundaries.tsmake docsbuilds without warnings (doc changes only)Signed-off-by: Carlos Villela cvillela@nvidia.com
Summary by CodeRabbit