test(cli): cover global action facade - #2943
Merged
cv merged 2 commits intoMay 3, 2026
Merged
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
cv
changed the title
This was referenced May 4, 2026
cv
added a commit
that referenced
this pull request
May 5, 2026
## Summary Remove broad coverage ignores from the remaining simple global oclif adapters and the credentials adapter, then cover their parser-to-action mappings directly. ## Stack Navigation - Position: 43 of 60 - Previous PR: [#2940 — test(cli): narrow sandbox logs coverage ignores](#2940) - Next PR: [#2943 — test(cli): cover global action facade](#2943) ## Changes - Removed file-level V8 ignores from debug, deploy, gateway-token, root help/version, tunnel, uninstall, and credentials adapters. - Added direct source-level adapter tests with mocked action/runtime dependencies. - Added source-level credentials tests for top-level usage, provider listing, and `credentials reset --yes`. - Added a test hook for the gateway-token adapter so source tests avoid loading the heavy onboard module. ## Type of Change - [x] Code change (feature, bug fix, or refactor) - [ ] Code change with doc updates - [ ] Doc only (prose changes, no code sample modifications) - [ ] Doc only (includes code sample changes) ## Verification - [x] `npx prek run --all-files` passes - [x] `npm test` passes - [x] Tests added or updated for new or changed behavior - [x] No secrets, API keys, or credentials committed - [ ] Docs updated for user-facing behavior changes - [ ] `make docs` builds without warnings (doc changes only) - [ ] Doc pages follow the [style guide](https://github.com/NVIDIA/NemoClaw/blob/main/docs/CONTRIBUTING.md) (doc changes only) - [ ] New doc pages include SPDX header and frontmatter (new pages only) --- Signed-off-by: Carlos Villela <cvillela@nvidia.com> --------- Signed-off-by: Carlos Villela <cvillela@nvidia.com>
cv
added a commit
that referenced
this pull request
May 5, 2026
## Summary Remove broad coverage ignores from small runtime utility modules that already have or can have direct tests. ## Stack Navigation - Position: 45 of 60 - Previous PR: [#2943 — test(cli): cover global action facade](#2943) - Next PR: [#2961 — test(cli): stabilize coverage dist sourcemaps](#2961) ## Changes - Removed the file-level V8 ignore from the oclif runner, which is already directly tested. - Removed the file-level V8 ignore from terminal style constants. - Added a small terminal style export test to keep the presentation constants covered. ## Type of Change - [x] Code change (feature, bug fix, or refactor) - [ ] Code change with doc updates - [ ] Doc only (prose changes, no code sample modifications) - [ ] Doc only (includes code sample changes) ## Verification - [x] `npx prek run --all-files` passes - [x] `npm test` passes - [x] Tests added or updated for new or changed behavior - [x] No secrets, API keys, or credentials committed - [ ] Docs updated for user-facing behavior changes - [ ] `make docs` builds without warnings (doc changes only) - [ ] Doc pages follow the [style guide](https://github.com/NVIDIA/NemoClaw/blob/main/docs/CONTRIBUTING.md) (doc changes only) - [ ] New doc pages include SPDX header and frontmatter (new pages only) --- Signed-off-by: Carlos Villela <cvillela@nvidia.com> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Extended CLI actions with optional runtime hook configuration for sandbox upgrades, enabling customizable upgrade handling. * **Chores** * Cleaned up obsolete code annotations. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Carlos Villela <cvillela@nvidia.com> Co-authored-by: Prekshi Vyas <34834085+prekshivyas@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove another broad coverage ignore by covering the global CLI action facade directly with mocked action/runtime dependencies.
Stack Navigation
Changes
global-cli-actions.ts.Type of Change
Verification
npx prek run --all-filespassesnpm testpassesmake docsbuilds without warnings (doc changes only)Signed-off-by: Carlos Villela cvillela@nvidia.com