refactor(cli): normalize gateway token command id - #2924
Conversation
This reverts commit 4ebeae4.
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe command identifier for the gateway token command is renamed from ChangesGateway Token Command Identifier Update
Estimated Code Review Effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
## Summary Replace switch-heavy sandbox command dispatch with route tables. Public CLI behavior is preserved while making the mapping between public sandbox syntax and internal oclif command IDs easier to review and extend. ## Stack Navigation - Position: 30 of 60 - Previous PR: [#2922 — refactor(cli): use oclif summaries in root help](#2922) - Next PR: [#2924 — refactor(cli): normalize gateway token command id](#2924) ## Changes - Added flat sandbox route metadata for single-action commands. - Added nested sandbox route metadata for skill, share, snapshot, shields, channels, and config. - Kept public help and compatibility routing behavior stable. ## Type of Change - [x] Code change (feature, bug fix, or refactor) - [ ] Code change with doc updates - [ ] Doc only (prose changes, no code sample modifications) - [ ] Doc only (includes code sample changes) ## Verification - [x] `npx prek run --all-files` passes - [x] `npm test` passes - [x] Tests added or updated for new or changed behavior - [x] No secrets, API keys, or credentials committed - [ ] Docs updated for user-facing behavior changes - [ ] `make docs` builds without warnings (doc changes only) - [ ] Doc pages follow the [style guide](https://github.com/NVIDIA/NemoClaw/blob/main/docs/CONTRIBUTING.md) (doc changes only) - [ ] New doc pages include SPDX header and frontmatter (new pages only) --- Signed-off-by: Carlos Villela <cvillela@nvidia.com> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Release Notes * **Refactor** * Restructured CLI command routing system * Modified help behavior for nested commands (channels, config, shields) <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
## Summary Introduce a public oclif help renderer for sandbox-scoped help paths that still use compatibility routing. This lets those paths display public NemoClaw syntax while pulling summaries and examples from oclif command metadata. ## Stack Navigation - Position: 32 of 60 - Previous PR: [#2924 — refactor(cli): normalize gateway token command id](#2924) - Next PR: [#2926 — refactor(cli): add shared oclif command base](#2926) ## Changes - Added a public help renderer that combines public usage with registered oclif metadata. - Extended help dispatch results with the oclif command ID that owns the help text. - Updated the top-level dispatcher to render public oclif help when command metadata is available. - Added coverage that public help output avoids internal command IDs. ## Type of Change - [x] Code change (feature, bug fix, or refactor) - [ ] Code change with doc updates - [ ] Doc only (prose changes, no code sample modifications) - [ ] Doc only (includes code sample changes) ## Verification - [x] `npx prek run --all-files` passes - [x] `npm test` passes - [x] Tests added or updated for new or changed behavior - [x] No secrets, API keys, or credentials committed - [ ] Docs updated for user-facing behavior changes - [ ] `make docs` builds without warnings (doc changes only) - [ ] Doc pages follow the [style guide](https://github.com/NVIDIA/NemoClaw/blob/main/docs/CONTRIBUTING.md) (doc changes only) - [ ] New doc pages include SPDX header and frontmatter (new pages only) --- Signed-off-by: Carlos Villela <cvillela@nvidia.com> --------- Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Summary
Continue internal command ID normalization by moving the sandbox gateway token adapter to a topic-style oclif ID. Public syntax remains
nemoclaw <name> gateway-token.Stack Navigation
Changes
sandbox:gateway:token.Type of Change
Verification
npx prek run --all-filespassesnpm testpassesmake docsbuilds without warnings (doc changes only)Signed-off-by: Carlos Villela cvillela@nvidia.com
Summary by CodeRabbit