refactor(cli): add lifecycle confirmation flag aliases - #2910
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
## Summary Move missing `skill install <path>` validation into the oclif adapter while keeping plugin-shape detection in the skill install action. This also adds help examples for the parent skill command and direct install command. ## Stack Navigation - Position: 17 of 60 - Previous PR: [#2908 — refactor(cli): improve snapshot command metadata](#2908) - Next PR: [#2910 — refactor(cli): add lifecycle confirmation flag aliases](#2910) ## Changes - Added examples for `skill` and `skill install` command metadata. - Made `sandbox:skill:install` require a skill directory or `SKILL.md` path before dispatch. - Kept filesystem and OpenClaw plugin detection in the action layer for friendly remediation text. - Updated CLI/unit coverage for missing install paths. ## Type of Change - [x] Code change (feature, bug fix, or refactor) - [ ] Code change with doc updates - [ ] Doc only (prose changes, no code sample modifications) - [ ] Doc only (includes code sample changes) ## Verification - [x] `npx prek run --all-files` passes - [x] `npm test` passes - [x] Tests added or updated for new or changed behavior - [x] No secrets, API keys, or credentials committed - [ ] Docs updated for user-facing behavior changes - [ ] `make docs` builds without warnings (doc changes only) - [ ] Doc pages follow the [style guide](https://github.com/NVIDIA/NemoClaw/blob/main/docs/CONTRIBUTING.md) (doc changes only) - [ ] New doc pages include SPDX header and frontmatter (new pages only) --- Signed-off-by: Carlos Villela <cvillela@nvidia.com> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Documentation** * Added usage examples for the `skill install` command, showing how to install a skill package from a directory or SKILL.md file. * **Bug Fixes** * The `skill install` command now enforces the requirement for a path argument. The command previously allowed invocation without specifying a path. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Carlos Villela <cvillela@nvidia.com>
## Summary Split the sandbox share command into explicit oclif subcommands for mount, unmount, and status. This keeps the public `nemoclaw <name> share ...` syntax stable while moving subcommand routing and unknown-subcommand handling into oclif. ## Stack Navigation - Position: 19 of 60 - Previous PR: [#2910 — refactor(cli): add lifecycle confirmation flag aliases](#2910) - Next PR: [#2912 — refactor(cli): model debug flags with oclif](#2912) ## Changes - Added `sandbox:share`, `sandbox:share:mount`, `sandbox:share:unmount`, and `sandbox:share:status` command adapters. - Moved share mount/unmount/status behavior into exported action helpers reused by the adapters and tests. - Updated sandbox dispatch to route share subcommands to explicit oclif command IDs. - Added CLI coverage for unknown share subcommands failing before action dispatch. ## Type of Change - [x] Code change (feature, bug fix, or refactor) - [ ] Code change with doc updates - [ ] Doc only (prose changes, no code sample modifications) - [ ] Doc only (includes code sample changes) ## Verification - [x] `npx prek run --all-files` passes - [x] `npm test` passes - [x] Tests added or updated for new or changed behavior - [x] No secrets, API keys, or credentials committed - [ ] Docs updated for user-facing behavior changes - [ ] `make docs` builds without warnings (doc changes only) - [ ] Doc pages follow the [style guide](https://github.com/NVIDIA/NemoClaw/blob/main/docs/CONTRIBUTING.md) (doc changes only) - [ ] New doc pages include SPDX header and frontmatter (new pages only) --- Signed-off-by: Carlos Villela <cvillela@nvidia.com> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added sandbox-scoped share subcommands: share mount/unmount/status and improved share help/usage. * Added `-y` short flag for `--yes` across destroy, rebuild, upgrade, and garbage-collection; rebuild docs also show `-v/--verbose`. * Added `sandbox:doctor` command and added CLI usage examples for several commands. * **Bug Fixes** * Improved help/usage and argument validation to surface unexpected arguments earlier. * **Tests** * Expanded tests for share help, destroy short-flag usage, and maintenance command help. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Carlos Villela <cvillela@nvidia.com> Co-authored-by: Prekshi Vyas <34834085+prekshivyas@users.noreply.github.com>
Summary
Add consistent
-yconfirmation aliases and examples across lifecycle-oriented oclif commands. This keeps confirmation semantics unchanged while documenting the parser-owned aliases in command help and root help metadata.Stack Navigation
Changes
-yaliases fordestroy,rebuild,upgrade-sandboxes, andgcconfirmation flags.destroyandrebuildcommand metadata.destroy -ythrough an existing lifecycle CLI subprocess test.Type of Change
Verification
npx prek run --all-filespassesnpm testpassesmake docsbuilds without warnings (doc changes only)Signed-off-by: Carlos Villela cvillela@nvidia.com