refactor(cli): remove runtime bridge

[cv]

Summary

Remove the now-empty transitional NemoClaw runtime bridge from the oclif CLI layer. Credentials tests now inject gateway/OpenShell hooks directly through global-cli-actions instead of stubbing ../nemoclaw.

Stack Navigation

• Position: 9 of 60
• Previous PR: #2897 — refactor(cli): extract upgrade sandboxes action
• Next PR: #2899 — refactor(cli): remove legacy dispatch fallbacks

Changes

• Deleted src/lib/nemoclaw-runtime-bridge.ts.
• Added explicit test/runtime hook injection to src/lib/global-cli-actions.ts for credential command gateway recovery and provider operations.
• Updated credentials CLI tests to use the explicit global action hooks instead of stubbing dist/nemoclaw.js.
• Verified no src/lib code imports or requires ../nemoclaw.

Type of Change

• Code change (feature, bug fix, or refactor)
• Code change with doc updates
• Doc only (prose changes, no code sample modifications)
• Doc only (includes code sample changes)

Verification

• npx prek run --all-files passes
• npm test passes
• Tests added or updated for new or changed behavior
• No secrets, API keys, or credentials committed
• Docs updated for user-facing behavior changes
• make docs builds without warnings (doc changes only)
• Doc pages follow the style guide (doc changes only)
• New doc pages include SPDX header and frontmatter (new pages only)

---

Signed-off-by: Carlos Villela cvillela@nvidia.com

Summary by CodeRabbit

• Refactor

  • Refactored internal runtime architecture to streamline dependencies and enhance code modularity.

• Tests

  • Enhanced test infrastructure with improved runtime mocking mechanism for better test isolation and control.

[copy-pr-bot]

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: c77e66cd-4583-4f74-959d-6594c4a49ee9

📥 Commits

Reviewing files that changed from the base of the PR and between b832004 and eae7ea0.

📒 Files selected for processing (3)

• src/lib/global-cli-actions.ts
• src/lib/nemoclaw-runtime-bridge.ts
• test/credentials-cli-command.test.ts

💤 Files with no reviewable changes (1)

• src/lib/nemoclaw-runtime-bridge.ts

---

📝 Walkthrough

Walkthrough

The PR refactors CLI runtime dependency injection by introducing a test-only runtime hooks mechanism in global-cli-actions.ts and removing the dedicated nemoclaw-runtime-bridge module. Functions now check for overridden hooks before falling back to default implementations. Tests are updated to use the new setter function.

Changes

Test-Only Runtime Hooks Refactoring

Layer / File(s)	Summary
Interface & Type Definitions src/lib/global-cli-actions.ts	Introduces GatewayRecovery and GlobalCliActionRuntimeHooks types, adds module-level runtimeHooks variable, and exports setGlobalCliActionRuntimeHooksForTest() setter. Removes import of getNemoClawRuntimeBridge.
Core Implementation src/lib/global-cli-actions.ts	recoverNamedGatewayRuntime() and runOpenshellProviderCommand() now prefer runtimeHooks when provided, otherwise fall back to existing implementations.
Module Removal src/lib/nemoclaw-runtime-bridge.ts	Entire module deleted, including NemoClawRuntimeBridge interface and exported factory functions setNemoClawRuntimeBridgeFactoryForTest() and getNemoClawRuntimeBridge().
Test Updates test/credentials-cli-command.test.ts	Replaces require.cache injection via RUNTIME_PATH with direct call to setGlobalCliActionRuntimeHooksForTest(). Adds GLOBAL_ACTIONS_PATH constant and updates cache cleanup to clear global-cli-actions.js entry.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• NVIDIA/NemoClaw#2841: Both PRs refactor how global-cli-actions obtains/uses runOpenshell and modify the runtime bridge pattern.

Suggested labels

NemoClaw CLI, refactor

Suggested reviewers

• cjagwani

Poem

🐰 The bridge has crossed, now hooks remain,

A cleaner path for test domain,

Where runtime flows through gentle seams,

And mocks inject their testing dreams,

The old foundation cleared away,

Makes room for brighter CLIs today! 🌟

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'refactor(cli): remove runtime bridge' accurately captures the main change: deletion of the nemoclaw-runtime-bridge.ts module and refactoring of CLI action dependencies to use direct runtime hooks instead.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch refactor/oclif-remove-runtime-bridge

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[prekshivyas]

LGTM. Clean removal of the now-empty runtime bridge.

• src/lib/nemoclaw-runtime-bridge.ts deleted; the single global-cli-actions.ts consumer rewires recoverNamedGatewayRuntime and runOpenshellProviderCommand through a local runtimeHooks object with production fall-through to the real implementations.
• Test refactor in test/credentials-cli-command.test.ts swaps require.cache[dist/nemoclaw.js] injection for the explicit setGlobalCliActionRuntimeHooksForTest API — strict improvement, no spooky cache-mutation seam.
• Zero new orphans in src/nemoclaw.ts (this PR doesn't touch it). Cumulative ~16-orphan debt from earlier stack PRs still pending the dedicated cleanup PR.

CI: pr.yaml fully green; pr-self-hosted build-sandbox-images/arm64 still in flight at review time, plus wsl-e2e. No failures so far — worth confirming green before merging.