-
Notifications
You must be signed in to change notification settings - Fork 3.1k
fix(hermes): scope prebaked dependencies to supported integrations #2846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
3a25bbc
Correctly install Hermes Agent dependencies
benbarclay 886a8b5
fix(hermes): scope prebaked dependencies to onboarding support
ericksoa 763ef91
fix(hermes): allow gateway runtime state writes
ericksoa 8c1b796
fix(hermes): start gateway log under gateway user
ericksoa 7bdd6cf
test(hermes): surface startup logs in e2e
ericksoa ad69173
test(hermes): keep runtime diagnostics single-line
ericksoa 91e8273
fix(hermes): allow policy read access to venv
ericksoa 2e5fddb
Fix Hermes runtime permissions and e2e feedback
ericksoa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,6 +17,7 @@ filesystem_policy: | |
| read_only: | ||
| - /usr | ||
| - /lib | ||
| - /opt/hermes | ||
| - /proc | ||
| - /dev/urandom | ||
| - /app | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,6 +18,7 @@ filesystem_policy: | |
| read_only: | ||
| - /usr | ||
| - /lib | ||
| - /opt/hermes | ||
| - /proc | ||
| - /dev/urandom | ||
| - /app | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: NVIDIA/NemoClaw
Length of output: 1102
🏁 Script executed:
# Check if the file has SPDX headers head -5 agents/hermes/start.shRepository: NVIDIA/NemoClaw
Length of output: 266
🏁 Script executed:
Repository: NVIDIA/NemoClaw
Length of output: 898
🌐 Web query:
GNU coreutils mv -T flag symlink directory behavior💡 Result:
The GNU coreutils mv command with the -T (or --no-target-directory) flag does not treat the destination operand specially if it is a directory or a symbolic link to a directory. Normally, without -T, if the destination is a directory or symlink to a directory, mv moves the source into that directory (e.g., mv source dest becomes mv source dest/source). With -T, mv treats the destination as a normal file path, attempting to rename or move the source directly to that exact path, even if dest exists as a directory or symlink to one. This enables overwriting or replacing a directory symlink atomically with another file or symlink. This behavior holds regardless of whether the destination is a symlink to a directory; the check for special treatment explicitly includes "a directory or a symbolic link to a directory". The mv source code confirms that when no_target_directory is set, it skips the directory detection logic for the last operand and performs a direct rename operation. Note that symlink handling also depends on trailing slashes (use --strip-trailing-slashes if needed) and the underlying rename(2) syscall behavior, which varies by OS/kernel (e.g., modern Linux fails with ENOTDIR for symlink-to-dir sources with trailing slash, while others may dereference).
Citations:
🏁 Script executed:
Repository: NVIDIA/NemoClaw
Length of output: 175
🏁 Script executed:
Repository: NVIDIA/NemoClaw
Length of output: 41
🏁 Script executed:
Repository: NVIDIA/NemoClaw
Length of output: 41
🏁 Script executed:
Repository: NVIDIA/NemoClaw
Length of output: 354
🏁 Script executed:
Repository: NVIDIA/NemoClaw
Length of output: 908
🏁 Script executed:
Repository: NVIDIA/NemoClaw
Length of output: 1042
🏁 Script executed:
Repository: NVIDIA/NemoClaw
Length of output: 311
🏁 Script executed:
Repository: NVIDIA/NemoClaw
Length of output: 3064
Use
mv -Twhen publishing the restricted log file.On line 66,
mv -ftreats a destination symlink-to-directory as a directory, so a pre-planted/tmp/nemoclaw-start.logor/tmp/gateway.loglink can redirect the temp file into an attacker-chosen directory instead of replacing the log path. Because this helper is reused for both restricted logs, the/tmphardening is incomplete.🔒 Proposed hardening
🤖 Prompt for AI Agents