Skip to content

fix(setup): use dynamic sandbox name instead of hardcoded 'nemoclaw' #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kagura-chen wants to merge 3 commits into from
Closed

fix(setup): use dynamic sandbox name instead of hardcoded 'nemoclaw' #284

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5352c8d
fix(setup): use dynamic sandbox name instead of hardcoded 'nemoclaw'
Mar 18, 2026
6468740
fix: harden sandbox name resolution and readiness check
Mar 18, 2026
7ba6721
fix: differentiate sandbox list command failures from not-found
Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 44 additions & 9 deletions scripts/setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,10 @@
#
# Usage:
# export NVIDIA_API_KEY=nvapi-...
# ./scripts/setup.sh
# ./scripts/setup.sh [sandbox-name]
#
# The sandbox name can also be set via the onboard wizard's
# ~/.nemoclaw/sandboxes.json registry. Defaults to "nemoclaw".
#
# What it does:
# 1. Starts an OpenShell gateway (or reuses existing)
Expand Down Expand Up @@ -71,10 +74,33 @@ command -v docker > /dev/null || fail "docker not found"
SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)"
REPO_DIR="$(cd "$SCRIPT_DIR/.." && pwd)"

# Sandbox name — can be passed as $1, read from onboard config, or defaults to "nemoclaw".
# This ensures setup.sh respects the name chosen during `nemoclaw onboard`.
if [ -n "${1:-}" ]; then
SANDBOX_NAME="$1"
elif [ -f "$HOME/.nemoclaw/sandboxes.json" ]; then
if command -v node > /dev/null 2>&1; then
_sb_name="$(node -e 'const p=process.argv[1];const s=require(p);process.stdout.write(Object.keys(s)[0]||"")' "$HOME/.nemoclaw/sandboxes.json" 2>/dev/null || true)"
if [ -n "${_sb_name}" ]; then
SANDBOX_NAME="${_sb_name}"
else
warn "Could not read sandbox name from ~/.nemoclaw/sandboxes.json; defaulting to \"nemoclaw\""
SANDBOX_NAME="nemoclaw"
fi
unset _sb_name
else
warn "Node.js not found; cannot read ~/.nemoclaw/sandboxes.json. Defaulting to \"nemoclaw\""
SANDBOX_NAME="nemoclaw"
fi
else
SANDBOX_NAME="nemoclaw"
fi
info "Using sandbox name: ${SANDBOX_NAME}"

# 1. Gateway — always start fresh to avoid stale state
info "Starting OpenShell gateway..."
openshell gateway destroy -g nemoclaw > /dev/null 2>&1 || true
GATEWAY_ARGS=(--name nemoclaw)
openshell gateway destroy -g "$SANDBOX_NAME" > /dev/null 2>&1 || true
GATEWAY_ARGS=(--name "$SANDBOX_NAME")
command -v nvidia-smi > /dev/null 2>&1 && GATEWAY_ARGS+=(--gpu)
openshell gateway start "${GATEWAY_ARGS[@]}" 2>&1 | grep -E "Gateway|✓|Error|error" || true

Expand Down Expand Up @@ -139,8 +165,8 @@ info "Setting inference route to nvidia-nim / Nemotron 3 Super..."
openshell inference set --no-verify --provider nvidia-nim --model nvidia/nemotron-3-super-120b-a12b > /dev/null 2>&1

# 5. Build and create sandbox
info "Deleting old nemoclaw sandbox (if any)..."
openshell sandbox delete nemoclaw > /dev/null 2>&1 || true
info "Deleting old ${SANDBOX_NAME} sandbox (if any)..."
openshell sandbox delete "$SANDBOX_NAME" > /dev/null 2>&1 || true

info "Building and creating NemoClaw sandbox (this takes a few minutes on first run)..."

Expand All @@ -162,7 +188,7 @@ fi
# detect failures. The raw log is kept on failure for debugging.
CREATE_LOG=$(mktemp /tmp/nemoclaw-create-XXXXXX.log)
set +e
openshell sandbox create --from "$BUILD_CTX/Dockerfile" --name nemoclaw \
openshell sandbox create --from "$BUILD_CTX/Dockerfile" --name "$SANDBOX_NAME" \
--provider nvidia-nim \
-- env NVIDIA_API_KEY="$NVIDIA_API_KEY" > "$CREATE_LOG" 2>&1
CREATE_RC=$?
Expand All @@ -183,20 +209,29 @@ rm -f "$CREATE_LOG"

# Verify sandbox is Ready (not just that a record exists)
# Strip ANSI color codes before checking phase
SANDBOX_LINE=$(openshell sandbox list 2>&1 | sed 's/\x1b\[[0-9;]*m//g' | grep "nemoclaw")
# Use awk for exact name match to avoid substring collisions, with || true to prevent
# set -euo pipefail from aborting on no match
SANDBOX_LINE=$(
openshell sandbox list 2>&1 \
| sed 's/\x1b\[[0-9;]*m//g' \
| awk -v name="$SANDBOX_NAME" '$1 == name { print; exit }' || true
)
if [ -z "$SANDBOX_LINE" ]; then
fail "Sandbox '${SANDBOX_NAME}' not found in 'openshell sandbox list'."
fi
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Resolved
if ! echo "$SANDBOX_LINE" | grep -q "Ready"; then
SANDBOX_PHASE=$(echo "$SANDBOX_LINE" | awk '{print $NF}')
echo ""
warn "Sandbox phase: ${SANDBOX_PHASE:-unknown}"
# Check for common failure modes
SB_DETAIL=$(openshell sandbox get nemoclaw 2>&1 || true)
SB_DETAIL=$(openshell sandbox get "$SANDBOX_NAME" 2>&1 || true)
if echo "$SB_DETAIL" | grep -qi "ImagePull\|ErrImagePull\|image.*not found"; then
warn "Image pull failure detected. The sandbox image was built inside the"
warn "gateway but k3s can't find it. This is a known openshell issue."
warn "Workaround: run 'openshell gateway destroy && openshell gateway start'"
warn "and re-run this script."
fi
fail "Sandbox created but not Ready (phase: ${SANDBOX_PHASE:-unknown}). Check 'openshell sandbox get nemoclaw'."
fail "Sandbox created but not Ready (phase: ${SANDBOX_PHASE:-unknown}). Check 'openshell sandbox get ${SANDBOX_NAME}'."
fi

# 6. Done
Expand Down