refactor(cli): migrate destroy command to oclif

[cv]

Summary

Migrates the destructive destroy sandbox command to oclif while preserving the existing destroy implementation. Confirmation prompts, active-session warnings, NIM cleanup, sandbox deletion, registry cleanup, and gateway cleanup stay unchanged.

Changes

• Add src/lib/destroy-cli-command.ts for sandbox:destroy.\n- Route <name> destroy [--yes|--force] through runOclif().\n- Preserve public help output for the sandbox-scoped command.\n- Reuse the existing sandboxDestroy() implementation behind the wrapper.

Type of Change

• Code change (feature, bug fix, or refactor)
• Code change with doc updates
• Doc only (prose changes, no code sample modifications)
• Doc only (includes code sample changes)

Verification

• npx prek run --all-files passes
• npm test passes
• Tests added or updated for new or changed behavior
• No secrets, API keys, or credentials committed
• Docs updated for user-facing behavior changes
• make docs builds without warnings (doc changes only)
• Doc pages follow the style guide (doc changes only)
• New doc pages include SPDX header and frontmatter (new pages only)

AI Disclosure

• AI-assisted — tool: OpenAI Codex

---

Signed-off-by: Carlos Villela cvillela@nvidia.com

Stack position

Note

This PR is part of a stacked refactor. Please review/merge in stack order.
The current PR is highlighted below.

This is PR #2806 in the stacked CLI oclif refactor series.

• Merge after: refactor(cli): migrate snapshot restore command to oclif #2805
• Next PR: refactor(cli): migrate rebuild command to oclif #2807
• Stack position: 13 / 37

Full stack

Merge from top to bottom.

Order	PR	Merge after	Title
1	#2775	main	refactor(cli): migrate status and tunnel commands to oclif
2	#2776	#2775	refactor(cli): migrate debug uninstall and gateway-token to oclif
3	#2786	#2776	refactor(cli): migrate credentials commands to oclif
4	#2787	#2786	refactor(cli): migrate sandbox inspection commands to oclif
5	#2788	#2787	refactor(cli): migrate maintenance commands to oclif
6	#2796	#2788	refactor(cli): migrate sandbox logs command to oclif
7	#2797	#2796	refactor(cli): migrate skill install command to oclif
8	#2798	#2797	refactor(cli): migrate snapshot list and create to oclif
9	#2802	#2798	refactor(cli): migrate shields commands to oclif
10	#2803	#2802	refactor(cli): migrate channels mutation commands to oclif
11	#2804	#2803	refactor(cli): migrate policy mutation commands to oclif
12	#2805	#2804	refactor(cli): migrate snapshot restore command to oclif
13	#2806	#2805	refactor(cli): migrate destroy command to oclif
14	#2807	#2806	refactor(cli): migrate rebuild command to oclif
15	#2808	#2807	refactor(cli): migrate connect command to oclif
16	#2809	#2808	refactor(cli): migrate deploy command to oclif
17	#2810	#2809	refactor(cli): migrate onboard aliases to oclif
18	#2811	#2810	refactor(cli): migrate help and version commands to oclif
19	#2814	#2811	refactor(cli): centralize legacy oclif dispatch
20	#2815	#2814	refactor(cli): drop trivial oclif wrapper helpers
21	#2816	#2815	refactor(cli): centralize sandbox runtime bridge
22	#2817	#2816	refactor(cli): centralize policy and channels runtime bridge
23	#2818	#2817	refactor(cli): centralize global runtime bridge
24	#2819	#2818	refactor(cli): collapse runtime bridge exports
25	#2826	#2819	refactor(cli): introduce sandbox runtime action facade
26	#2827	#2826	refactor(cli): introduce policy and channels action facade
27	#2828	#2827	refactor(cli): introduce global command action facade
28	#2830	#2828	refactor(cli): extract root help action
29	#2831	#2830	refactor(cli): extract deploy action
30	#2832	#2831	refactor(cli): extract onboard actions
31	#2835	#2832	refactor(cli): extract openshell runtime helpers
32	#2836	#2835	refactor(cli): extract sandbox logs action
33	#2837	#2836	refactor(cli): extract maintenance actions
34	#2838	#2837	refactor(cli): extract snapshot actions
35	#2839	#2838	refactor(cli): extract policy and channels actions
36	#2840	#2839	refactor(cli): extract credentials and list runtime bits
37	#2841	#2840	refactor(cli): shrink runtime bridge

Summary by CodeRabbit

• New Features

  • Added a new sandbox destroy command that allows users to delete sandboxes. The command includes a --yes flag to automatically confirm deletion without prompting and a --force flag to override safety restrictions.

• Tests

  • Added CLI command test coverage for the destroy functionality to ensure proper help output and usage information display.

[copy-pr-bot]

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR introduces a new oclif CLI command sandbox:destroy for destroying sandboxes. The command accepts a required sandbox name argument and optional --yes and --force flags, then delegates to the existing sandboxDestroy function via a runtime bridge. The nemoclaw dispatcher is updated to route sandbox destroy requests through oclif instead of direct invocation, and help test coverage is extended.

Changes

Sandbox Destroy CLI Command

Layer / File(s)	Summary
Core Command Implementation src/lib/destroy-cli-command.ts	New oclif DestroyCliCommand class with required sandboxName argument and optional --yes/--force flags. The run() method converts flags into legacy arguments and calls sandboxDestroy via a runtime bridge loaded from nemoclaw.
Command Registration src/lib/oclif-commands.ts	DestroyCliCommand is imported and registered in the command map under the "sandbox:destroy" key.
Runtime Bridge & Dispatch src/nemoclaw.ts	sandboxDestroy function is explicitly exported. The <sandbox> destroy dispatch path switches from direct function call to oclif command dispatch (runOclif("sandbox:destroy", ...)) with a help-flag guard.
Test Coverage test/cli.test.ts	Assertions added to verify destroy --help shows the public-facing usage (<name> destroy [--yes|--force]) and does not expose the internal sandbox:destroy identifier.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

🐰 A sandbox falls away, clean and free,
With flags for force and yes's decree,
Through oclif's bridge, the command flows,
Destruction swift—as every rabbit knows! 🌿

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'refactor(cli): migrate destroy command to oclif' accurately describes the main change—migrating the destroy sandbox command to oclif—and is concise and clear.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch refactor/oclif-destroy

---

_{Review rate limit: 9/10 reviews remaining, refill in 6 minutes.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

src/lib/destroy-cli-command.ts (1)

12-14: ⚡ Quick win

Add a runtime shape guard for the bridge object.

Line 13 relies on a type assertion only; if the bridge export drifts, this fails late with a generic TypeError. Add an explicit function check and throw a clear error.

Proposed hardening

 function getRuntimeBridge(): RuntimeBridge {
-  return require("../nemoclaw") as RuntimeBridge;
+  const bridge = require("../nemoclaw") as Partial<RuntimeBridge>;
+  if (typeof bridge?.sandboxDestroy !== "function") {
+    throw new Error("Runtime bridge misconfigured: sandboxDestroy is unavailable.");
+  }
+  return bridge as RuntimeBridge;
 }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/lib/destroy-cli-command.ts` around lines 12 - 14, The getRuntimeBridge
function currently uses a type assertion and can throw a generic TypeError if
the "../nemoclaw" export shape drifts; update getRuntimeBridge to
require("../nemoclaw") into a local const, validate that the object conforms to
the expected RuntimeBridge shape (e.g., required functions/properties you rely
on on the returned bridge), and if the checks fail throw a clear, descriptive
Error (mentioning getRuntimeBridge and the missing/invalid members) instead of
relying on the assertion so callers fail fast with a helpful message.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@src/lib/destroy-cli-command.ts`:
- Around line 12-14: The getRuntimeBridge function currently uses a type
assertion and can throw a generic TypeError if the "../nemoclaw" export shape
drifts; update getRuntimeBridge to require("../nemoclaw") into a local const,
validate that the object conforms to the expected RuntimeBridge shape (e.g.,
required functions/properties you rely on on the returned bridge), and if the
checks fail throw a clear, descriptive Error (mentioning getRuntimeBridge and
the missing/invalid members) instead of relying on the assertion so callers fail
fast with a helpful message.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: c0915405-9bd5-4575-a4d2-a6ae3ff05612

📥 Commits

Reviewing files that changed from the base of the PR and between 5e6694a and fd59cd0.

📒 Files selected for processing (4)

• src/lib/destroy-cli-command.ts
• src/lib/oclif-commands.ts
• src/nemoclaw.ts
• test/cli.test.ts