fix(sandbox): stage generate-openclaw-config.py in optimised build context - #2508
fix(sandbox): stage generate-openclaw-config.py in optimised build context#2508laitingsheng wants to merge 2 commits into
Conversation
…ntext The optimised sandbox build context staging in `stageOptimizedSandboxBuildContext` only copied `nemoclaw-start.sh` and `lib/sandbox-init.sh` into the staged scripts directory, but the Dockerfile (line 195) also COPYs `scripts/generate-openclaw-config.py`. The script was added in ca46f47 ("feat: extract inline Python config to scripts/generate-openclaw-config.py") which updated the Dockerfile but not the staging function, so `nemoclaw onboard` fails at the COPY step. The legacy staging path (`stageLegacySandboxBuildContext`) recursively copies the entire `scripts/` directory and is therefore unaffected. Also extend the optimised-staging test to assert both `generate-openclaw-config.py` and `lib/sandbox-init.sh` are present in the staged context, so future Dockerfile additions that miss the staging function will be caught immediately. Fixes #2503 Signed-off-by: Tinson Lai <tinsonl@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe PR adds Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
✨ Thanks for submitting this pull request that proposes a way to fix a bug that causes the sandbox build context staging to fail when copying the generate-openclaw-config.py script. Related open issues: |
|
Thanks for the proposed fix. This was covered by #2565, which was merged earlier today with the same correction to include generate-openclaw-config.py in the optimized build context. Closing to keep the queue clean; feel free to reopen if there's behavior from this PR that didn't carry over. |
Summary
The optimised sandbox build context staging in
stageOptimizedSandboxBuildContextonly copiednemoclaw-start.shandlib/sandbox-init.shinto the staged scripts directory, but the Dockerfile (line 195) also COPYsscripts/generate-openclaw-config.py. The script was added in ca46f47 ("feat: extract inline Python config to scripts/generate-openclaw-config.py") which updated the Dockerfile but not the staging function, sonemoclaw onboardfails at the COPY step.Related Issue
Fixes #2503
Changes
The legacy staging path (
stageLegacySandboxBuildContext) recursively copies the entirescripts/directory and is therefore unaffected.Also extend the optimised-staging test to assert both
generate-openclaw-config.pyandlib/sandbox-init.share present in the staged context, so future Dockerfile additions that miss the staging function will be caught immediately.Type of Change
Verification
npx prek run --all-filespassesnpm testpassesmake docsbuilds without warnings (doc changes only)AI Disclosure
Signed-off-by: Tinson Lai tinsonl@nvidia.com
Summary by CodeRabbit
Chores
Tests