Skip to content

fix(test): satisfy strict typecheck on Slack token validation tests #2458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericksoa merged 1 commit into from
Apr 24, 2026
Merged

fix(test): satisfy strict typecheck on Slack token validation tests #2458

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions test/onboard.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5066,7 +5066,7 @@ const { setupMessagingChannels, MESSAGING_CHANNELS } = require(${onboardPath});
input: "\n",
});
assert.equal(introspect.status, 0, introspect.stderr);
const introspectOut = JSON.parse(introspect.stdout.trim().split("\n").pop());
const introspectOut = JSON.parse(introspect.stdout.trim().split("\n").pop()!);
const slackIdx = introspectOut.slackIndex1Based;
assert.ok(slackIdx >= 1, `unexpected slack index: ${slackIdx}`);

Expand All @@ -5085,14 +5085,14 @@ const { setupMessagingChannels, MESSAGING_CHANNELS } = require(${onboardPath});
});

assert.equal(result.status, 0, result.stderr);
const out = JSON.parse(result.stdout.trim().split("\n").pop());
const out = JSON.parse(result.stdout.trim().split("\n").pop()!);

assert.ok(
!out.result.includes("slack"),
`slack should have been dropped after invalid token; got ${JSON.stringify(out.result)}`,
);
assert.ok(
!out.saveCalls.some((c) => c.key === "SLACK_BOT_TOKEN"),
!out.saveCalls.some((c: { key: string }) => c.key === "SLACK_BOT_TOKEN"),
`SLACK_BOT_TOKEN should NOT have been persisted; saveCalls=${JSON.stringify(out.saveCalls)}`,
);
assert.ok(
Expand Down Expand Up @@ -5177,7 +5177,7 @@ const { setupMessagingChannels, MESSAGING_CHANNELS } = require(${onboardPath});
});
assert.equal(introspect.status, 0, introspect.stderr);
const slackIdx = JSON.parse(
introspect.stdout.trim().split("\n").pop(),
introspect.stdout.trim().split("\n").pop()!,
).slackIndex1Based;
assert.ok(slackIdx >= 1, `unexpected slack index: ${slackIdx}`);

Expand All @@ -5195,7 +5195,7 @@ const { setupMessagingChannels, MESSAGING_CHANNELS } = require(${onboardPath});
});

assert.equal(result.status, 0, result.stderr);
const out = JSON.parse(result.stdout.trim().split("\n").pop());
const out = JSON.parse(result.stdout.trim().split("\n").pop()!);

assert.ok(
!out.result.includes("slack"),
Expand All @@ -5205,11 +5205,11 @@ const { setupMessagingChannels, MESSAGING_CHANNELS } = require(${onboardPath});
// user can retry later and the pre-saved bot token will light up as
// "already configured" on the next onboard.
assert.ok(
out.saveCalls.some((c) => c.key === "SLACK_BOT_TOKEN"),
out.saveCalls.some((c: { key: string }) => c.key === "SLACK_BOT_TOKEN"),
`SLACK_BOT_TOKEN should have been persisted (valid format); saveCalls=${JSON.stringify(out.saveCalls)}`,
);
assert.ok(
!out.saveCalls.some((c) => c.key === "SLACK_APP_TOKEN"),
!out.saveCalls.some((c: { key: string }) => c.key === "SLACK_APP_TOKEN"),
`SLACK_APP_TOKEN should NOT have been persisted (invalid format); saveCalls=${JSON.stringify(out.saveCalls)}`,
);
assert.ok(
Expand All @@ -5225,7 +5225,7 @@ const { setupMessagingChannels, MESSAGING_CHANNELS } = require(${onboardPath});
// Cache-bust the dynamic import so repeated test runs pick up rebuilds.
const onboardUrl = `${pathToFileURL(onboardPath).href}?update=${Date.now()}`;
const { MESSAGING_CHANNELS } = await import(onboardUrl);
const slack = MESSAGING_CHANNELS.find((c) => c.name === "slack");
const slack = MESSAGING_CHANNELS.find((c: { name: string }) => c.name === "slack");

assert.ok(slack, "slack messaging channel definition present");
assert.ok(slack.tokenFormat instanceof RegExp, "slack.tokenFormat is a regex");
Expand Down
Loading